Page MenuHomePhabricator

All links inside jQuery UI dialogs are black since update
Closed, ResolvedPublic1 Story Points

Description

Betalabs: Links in 'Leave feedback'
<a href="#">report a bug</a> and <a href="/wiki/Wikipedia:VisualEditor/Feedback" target="_blank" style="white-space: nowrap;">VisualEditor/Feedback</a>
have a color #362b36.

test2 and production have #0b0080.

Details

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a project: VisualEditor.
Etonkovidova added a subscriber: Etonkovidova.
Krenair added a subscriber: Krenair.

I think this is mw.Feedback and we don't have much control over how that's styled, do we?

Catrope set Security to None.Jan 5 2015, 9:30 PM
Catrope added subscribers: matmarex, Krinkle.
Krenair renamed this task from Links color #362b36 instead of #0b0080 to All links inside jQuery UI dialogs are black since update.Jan 5 2015, 9:32 PM
Krenair added a project: Vector.
Krenair added a subscriber: Paladox.

Found the problem in https://gerrit.wikimedia.org/r/#/c/154024/26/skinStyles/jquery.ui/jquery.ui.theme.css. it was this css code .ui-widget-content a { color: #362b36; } it could be removed in a new patch.

Change 182891 had a related patch set uploaded (by Paladox):
All links inside jQuery UI dialogs are black

https://gerrit.wikimedia.org/r/182891

Patch-For-Review

The same issue affects all other skins, via the default jQuery UI theme in MediaWiki core. This appears to be a conscious decision by the jQuery UI developers, and is not overridable with their "ThemeRoller", so if we decide to override this, we'll need to "fork" the code and we should document it somewhere, so that this doesn't happen again when we upgrade.

This was previously fixed as T69851.

Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

Change 182891 merged by jenkins-bot:
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/182891

matmarex added a comment.EditedJan 7 2015, 12:47 PM

Should be also fixed in MediaWiki core, for skins other than Vector, no?

matmarex reopened this task as Open.Jan 7 2015, 1:00 PM
matmarex removed a project: Patch-For-Review.
Krinkle closed this task as Resolved.Jan 7 2015, 3:51 PM

Should be also fixed in MediaWiki core, for skins other than Vector, no?

MediaWiki isn't as monolithic as it used to be. This task is for Vector. If there's issues in other skins, file separate issues with those. Re-closing as resolved.

As for this the other skins, only Vector has its own jQuery UI theme. Other skins use the default theme. Dialogs and other widgets aren't styled like the theme there anyway, so links being black is just in line with that theme. I don't see a problem with that. Skins are free to implement their own jQuery UI theme.

Jdforrester-WMF reopened this task as Open.Jan 7 2015, 4:06 PM
Jdforrester-WMF added a project: MonoBook.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Let's not create tasks for no reason. This can be fixed in MonoBook in this task too.

Change 183286 had a related patch set uploaded (by Bartosz Dziewoński):
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/183286

Patch-For-Review

matmarex closed this task as Resolved.Jan 7 2015, 6:36 PM
matmarex removed projects: Patch-For-Review, MonoBook.

Change 183286 merged by jenkins-bot:
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/183286

Change 183299 had a related patch set uploaded (by Paladox):
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/183299

Patch-For-Review

Change 183299 abandoned by Jforrester:
jquery-ui: Remove dark color from links inside dialogs

Reason:
Not necessary to cherry-pick given it's only for Monobook.

https://gerrit.wikimedia.org/r/183299

The links are back to blue in betalabs and test2.

Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Jan 7 2015, 9:18 PM
gerritbot added a subscriber: gerritbot.

Change 189141 had a related patch set uploaded (by Paladox):
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/189141

Patch-For-Review

Change 189141 merged by jenkins-bot:
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/189141