Page MenuHomePhabricator
Create Task
Maniphest T85857

All links inside jQuery UI dialogs are black since update
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Paladox
Authored By
Etonkovidova
Jan 5 2015, 9:17 PM
Tags
Referenced Files
F26660: Screen_Shot_2015-01-05_at_1.07.21_PM.png
Jan 5 2015, 9:17 PM
Subscribers
Aklapper
Catrope
Etonkovidova
gerritbot
Jdforrester-WMF
Krenair
Krinkle
View All 9 Subscribers
Tokens
"Grey Medal" token, awarded by RandomDSdevel.

Description

Betalabs: Links in 'Leave feedback'
<a href="#">report a bug</a> and <a href="/wiki/Wikipedia:VisualEditor/Feedback" target="_blank" style="white-space: nowrap;">VisualEditor/Feedback</a>
have a color #362b36.

test2 and production have #0b0080.

Screen_Shot_2015-01-05_at_1.07.21_PM.png (587×1 px, 139 KB)

Details

SubjectRepoBranchLines +/-
jquery-ui: Remove dark color from links inside dialogsmediawiki/skins/VectorREL1_24+3 -3
jquery-ui: Remove dark color from links inside dialogsmediawiki/skins/Vectormaster+3 -3
jquery-ui: Remove dark color from links inside dialogsmediawiki/corewmf/1.25wmf14+4 -3
jquery-ui: Remove dark color from links inside dialogsmediawiki/coremaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jan 5 2015, 9:17 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a project: VisualEditor.
Etonkovidova subscribed.
Krenair added a project: VisualEditor-MediaWiki.Jan 5 2015, 9:20 PM
Krenair subscribed.

I think this is mw.Feedback and we don't have much control over how that's styled, do we?

Catrope subscribed.Jan 5 2015, 9:27 PM

Caused by https://gerrit.wikimedia.org/r/#/c/154024/

Catrope set Security to None.Jan 5 2015, 9:30 PM
Catrope added subscribers: matmarex, Krinkle.
Krenair renamed this task from Links color #362b36 instead of #0b0080 to All links inside jQuery UI dialogs are black since update.Jan 5 2015, 9:32 PM
Krenair added a project: Vector (legacy skin).
Krenair added a subscriber: Paladox.
Paladox added a comment.Jan 5 2015, 9:36 PM

Found the problem in https://gerrit.wikimedia.org/r/#/c/154024/26/skinStyles/jquery.ui/jquery.ui.theme.css. it was this css code .ui-widget-content a { color: #362b36; } it could be removed in a new patch.

gerritbot added a project: Patch-For-Review.Jan 5 2015, 9:42 PM

Change 182891 had a related patch set uploaded (by Paladox):
All links inside jQuery UI dialogs are black

https://gerrit.wikimedia.org/r/182891

Patch-For-Review

matmarex added a project: MediaWiki-User-Interface.Jan 6 2015, 2:28 AM

The same issue affects all other skins, via the default jQuery UI theme in MediaWiki core. This appears to be a conscious decision by the jQuery UI developers, and is not overridable with their "ThemeRoller", so if we decide to override this, we'll need to "fork" the code and we should document it somewhere, so that this doesn't happen again when we upgrade.

matmarex added a project: Regression.Jan 6 2015, 2:32 AM

This was previously fixed as T69851.

Jdforrester-WMF assigned this task to Paladox.Jan 6 2015, 4:19 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
gerritbot added a comment.Jan 7 2015, 1:11 AM

Change 182891 merged by jenkins-bot:
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/182891

Krinkle mentioned this in rSVECa16d29f8a88e: jquery-ui: Remove dark color from links inside dialogs.Jan 7 2015, 1:14 AM
Jdforrester-WMF closed this task as Resolved.Jan 7 2015, 2:49 AM
Jdforrester-WMF added a project: WMF-deploy-2015-01-07_(1.25wmf14).
matmarex added a comment.EditedJan 7 2015, 12:47 PM

Should be also fixed in MediaWiki core, for skins other than Vector, no?

matmarex reopened this task as Open.Jan 7 2015, 1:00 PM
matmarex removed a project: Patch-For-Review.
Krinkle closed this task as Resolved.Jan 7 2015, 3:51 PM
In T85857#959223, @matmarex wrote:

Should be also fixed in MediaWiki core, for skins other than Vector, no?

MediaWiki isn't as monolithic as it used to be. This task is for Vector. If there's issues in other skins, file separate issues with those. Re-closing as resolved.

As for this the other skins, only Vector has its own jQuery UI theme. Other skins use the default theme. Dialogs and other widgets aren't styled like the theme there anyway, so links being black is just in line with that theme. I don't see a problem with that. Skins are free to implement their own jQuery UI theme.

Jdforrester-WMF reopened this task as Open.Jan 7 2015, 4:06 PM
Jdforrester-WMF added a project: MonoBook.
Jdforrester-WMF subscribed.

Let's not create tasks for no reason. This can be fixed in MonoBook in this task too.

gerritbot added a project: Patch-For-Review.Jan 7 2015, 6:31 PM

Change 183286 had a related patch set uploaded (by Bartosz Dziewoński):
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/183286

Patch-For-Review

matmarex closed this task as Resolved.Jan 7 2015, 6:36 PM
matmarex removed projects: Patch-For-Review, MonoBook.
gerritbot added a comment.Jan 7 2015, 6:41 PM

Change 183286 merged by jenkins-bot:
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/183286

matmarex mentioned this in rMW5e772e39dd8a: jquery-ui: Remove dark color from links inside dialogs.Jan 7 2015, 6:41 PM
gerritbot added a project: Patch-For-Review.Jan 7 2015, 7:08 PM

Change 183299 had a related patch set uploaded (by Paladox):
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/183299

Patch-For-Review

gerritbot added a comment.Jan 7 2015, 7:12 PM

Change 183299 abandoned by Jforrester:
jquery-ui: Remove dark color from links inside dialogs

Reason:
Not necessary to cherry-pick given it's only for Monobook.

https://gerrit.wikimedia.org/r/183299

Etonkovidova added a comment.Jan 7 2015, 8:47 PM

The links are back to blue in betalabs and test2.

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 7 2015, 9:18 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jan 7 2015, 9:25 PM
Etonkovidova added a project: Verified-in-Phase0.Jan 8 2015, 12:50 AM
gerritbot added a project: Patch-For-Review.Feb 7 2015, 12:36 AM
gerritbot subscribed.

Change 189141 had a related patch set uploaded (by Paladox):
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/189141

Patch-For-Review

gerritbot added a comment.Feb 8 2015, 10:23 AM

Change 189141 merged by jenkins-bot:
jquery-ui: Remove dark color from links inside dialogs

https://gerrit.wikimedia.org/r/189141

Paladox mentioned this in rSVEC9ace28f253d4: jquery-ui: Remove dark color from links inside dialogs.Feb 8 2015, 10:24 AM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 19 2015, 9:36 PM
RandomDSdevel awarded a token.Mar 5 2015, 7:36 PM
Paladox mentioned this in rSKIN40013337feea: Updated mediawiki/skins Project: mediawiki/skins/Vector….Mar 19 2015, 1:44 PM
Krinkle mentioned this in rSLATa16d29f8a88e: jquery-ui: Remove dark color from links inside dialogs.Mar 19 2015, 1:45 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:27 PM
Jdforrester-WMF edited a custom field.Mar 29 2015, 11:33 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 29 2015, 11:49 PM
Krinkle mentioned this in rSVEVa16d29f8a88e: jquery-ui: Remove dark color from links inside dialogs.Mar 8 2016, 3:29 PM
Paladox mentioned this in rSVEV9ace28f253d4: jquery-ui: Remove dark color from links inside dialogs.Mar 8 2016, 3:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL