Can't make table cell selections in read mode (like in VE)
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To

None

Authored By

	Lokal_Profil
	Jan 8 2015, 1:35 PM

Description

Highlighting cells in a table normally result in cells being highlighted row by row, with no possibility of highlighting a column. After having entered (and left) VE however it is now possible to select cells as desired.

Note that the unexpected behaviour is IMHO an improvement over the normal behaviour since it allows you to select by cells better and to copy their contents and past these elsewhere. Something you cannot do in either VE editing mode or in the normal view mode.

Screencast (ogv): F26987

To reproduce:

Go to any page with a table (e.g. this)
Attempt to highlight the middle column
Go into editmode in VE
Leave VE (by e.g. clicking View)
Highlight the middle column

Related Objects

Mentioned In: T142234: Consider providing a table contents selection system in read mode that lets you copy parts of tables (e.g. the first three columns), over-riding default browser behaviour
Mentioned Here: T142234: Consider providing a table contents selection system in read mode that lets you copy parts of tables (e.g. the first three columns), over-riding default browser behaviour
T75990: Ogv videos doesn't show any image on Phabricator (as "application/ogg" is listed under files.audio-mime-types by default)

Event Timeline

Lokal_Profil created this task.Jan 8 2015, 1:35 PM

Lokal_Profil raised the priority of this task from to Needs Triage.

Lokal_Profil updated the task description. (Show Details)

Lokal_Profil added a project: VisualEditor-Tables.

Lokal_Profil subscribed.

Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 8 2015, 1:35 PM

It sounds to me like you are reporting a feature as a bug...?
Also, is that really an ogg (audio) file or has Phabricator broken it while uploading?

Krenair updated the task description. (Show Details)Jan 8 2015, 2:28 PM

Krenair set Security to None.

In T86164#962678, @Krenair wrote:

Also, is that really an ogg (audio) file or has Phabricator broken it while uploading?

It's an ogg video file, but Phabricator currently assumes that all ogg files are audio-only. There's a bug for this somewhere. You can download it from the file's page.

yep, here: https://secure.phabricator.com/T6674

@Krenair @matmarex : T75990

In T86164#962678, @Krenair wrote:

It sounds to me like you are reporting a feature as a bug...?

It's a bug in that it is unexpected and inconsistent behaviour (because the page reacts differently before and after editing it). The ideal solution (IMHO) would be to make this the standard behaviour.

So maybe I'm reporting that a bug should be a feature...?

Ryasmeen triaged this task as Medium priority.Jan 15 2015, 2:08 AM

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jan 15 2015, 4:44 PM

This is by design and very deliberate. We have no plans to change VE selection of cells, nor override the system default in read mode.

Restricted Application added a subscriber: Josve05a. · View Herald TranscriptJan 31 2016, 3:04 PM

Re-assigning to reading-web. The request is to be able make cell selections in reading mode (presumable for copy-paste). Not sure if that is worth exploring though.

Esanders renamed this task from Highlighting table cells differ before and after entering VEedit to Can't make table cell selections in read mode (like in VE).Jan 31 2016, 3:08 PM

In T86164#1984908, @Esanders wrote:

This is by design and very deliberate. We have no plans to change VE selection of cells, nor override the system default in read mode.

It is still unexpected behaviour that highlighting works differently before and after entering VE (see Task description). If it is really on purpose that you cannot select columns when in reading mode then clicking "view" should disable it again. (Although I'll admit that that is of lower priority.

Esanders removed Esanders as the assignee of this task.Feb 3 2016, 10:56 AM

Almost everything behaves differently in VE (links, images, templates etc). That is expected behaviour.

In T86164#1993485, @Esanders wrote:

Almost everything behaves differently in VE (links, images, templates etc). That is expected behaviour.

But it should not continue to behave differently after pressing "View" again (exiting VE-mode).

I'm downgrading this to Low for the time being given the tone of the thread. Speaking from the Reading Web side of things, at the moment it's not well aligned with quarterly or annual objectives, plus it's unclear what the ideal behavior is here in the Vector skin. There's an argument to be made that users want to select specific text in a cell, although I imagine at times users also want to get the cells as cells. I don't frankly know if any change is worth it.

That said, I think the latest comment was about having consistent pre- and post-toolbar tab change behavior. I'm totally unsure of how easy or hard that is from a technical perspective. There's a fair amount of wizardry involved in editable DOMs.

dr0ptp4kt moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog board.Aug 5 2016, 4:49 PM

In T86164#1993790, @Josve05a wrote:

In T86164#1993485, @Esanders wrote:

Almost everything behaves differently in VE (links, images, templates etc). That is expected behaviour.

But it should not continue to behave differently after pressing "View" again (exiting VE-mode).

And it doesn't in testing in Firefox or Chrome on Mac or Linux. The video is (I'm pretty sure) because @Lokal_Profil must have been pressing Ctrl which triggers Firefox's alternate table selection system; it's nothing to do with VE. I'm re-closing this as Invalid, but have put that idea into T142234: Consider providing a table contents selection system in read mode that lets you copy parts of tables (e.g. the first three columns), over-riding default browser behaviour.

matmarex closed this task as Invalid.Aug 5 2016, 6:10 PM

In T86164#2528100, @Jdforrester-WMF wrote:

In T86164#1993790, @Josve05a wrote:

In T86164#1993485, @Esanders wrote:

Almost everything behaves differently in VE (links, images, templates etc). That is expected behaviour.

But it should not continue to behave differently after pressing "View" again (exiting VE-mode).

And it doesn't in testing in Firefox or Chrome on Mac or Linux. The video is (I'm pretty sure) because @Lokal_Profil must have been pressing Ctrl which triggers Firefox's alternate table selection system; it's nothing to do with VE. I'm re-closing this as Invalid, but have put that idea into T142234: Consider providing a table contents selection system in read mode that lets you copy parts of tables (e.g. the first three columns), over-riding default browser behaviour.

I didn't do the selection using Ctrl-key, had I done that then step 2 would have produced the same result (column selection only).

That said I now get the same behaviour at step 2 as step 5 (row by row selection) which means the bug (different behaviour when returning to view mode) has been resolved in the meantime.

Jdforrester-WMF moved this task from Freezer to External and Administrivia on the VisualEditor board.Aug 18 2016, 4:56 PM

Jdforrester-WMF set the point value for this task to 0.Aug 22 2016, 5:28 PM

• Phabricator_maintenance moved this task from 2014-15 Q4 to 2016-17 Q1 on the Web-Team-Backlog board.Mar 6 2018, 11:49 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 6 2018, 11:49 PM

Can't make table cell selections in read mode (like in VE)Closed, ResolvedPublic0 Estimated Story PointsActions

Description

Related Objects

Event Timeline

Can't make table cell selections in read mode (like in VE)
Closed, ResolvedPublic0 Estimated Story Points
Actions