Page MenuHomePhabricator
Create Task
Maniphest T87420

OO.ui.PopupWidget.toggle triggers recalc style
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Need to determine visibility on our own so that we don't require on getComputedStyle.

Details

SubjectRepoBranchLines +/-
Use css class instead of jquery show/hidemediawiki/extensions/VisualEditorwmf/1.25wmf16+25 -25
Use css class instead of jquery show/hidemediawiki/extensions/VisualEditormaster+25 -25
Use css class rather than jQuery show/hideVisualEditor/VisualEditormaster+23 -20
Use css class instead of jQuery .show()/hide()/toggle()oojs/uimaster+68 -36
Customize query in gerrit

Related Objects
Search...

Event Timeline

ori created this task.Jan 23 2015, 7:43 AM
ori raised the priority of this task from to Needs Triage.
ori updated the task description. (Show Details)
ori added projects: OOUI, VisualEditor-Performance.
ori added subscribers: ori, matmarex, Catrope, Krinkle.
Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 23 2015, 7:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF moved this task from Backlog to Next up on the VisualEditor-Performance board.Jan 23 2015, 6:40 PM
Jdforrester-WMF triaged this task as High priority.Jan 23 2015, 9:56 PM
Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM
Jdforrester-WMF set Security to None.Jan 23 2015, 11:53 PM
Jdforrester-WMF edited a custom field.
gerritbot added a project: Patch-For-Review.Jan 29 2015, 11:37 PM
gerritbot subscribed.

Change 187614 had a related patch set uploaded (by Mooeypoo):
[BREAKING CHANGE] Use css class instead of jQuery .show()/hide()/toggle()

https://gerrit.wikimedia.org/r/187614

Patch-For-Review

gerritbot added a comment.Jan 29 2015, 11:47 PM

Change 187618 had a related patch set uploaded (by Mooeypoo):
Use css class instead of jquery show/hide

https://gerrit.wikimedia.org/r/187618

Patch-For-Review

Ricordisamoa subscribed.Jan 30 2015, 12:45 AM
Mooeypoo claimed this task.Feb 2 2015, 7:30 PM
Jdforrester-WMF edited a custom field.Feb 2 2015, 8:07 PM
Mooeypoo moved this task from Bug Fixes to Blocked on the VisualEditor board.Feb 2 2015, 9:40 PM
gerritbot added a comment.Feb 2 2015, 11:30 PM

Change 187614 merged by jenkins-bot:
Use css class instead of jQuery .show()/hide()/toggle()

https://gerrit.wikimedia.org/r/187614

Jdforrester-WMF closed this task as Resolved.Feb 2 2015, 11:44 PM
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.
Jdforrester-WMF added a project: WMF-deploy-2015-02-11_(1.25wmf17).
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:01 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-02-04_(1.25wmf16); removed WMF-deploy-2015-02-11_(1.25wmf17), Patch-For-Review.Feb 4 2015, 4:17 PM
• TrevorParscal edited a custom field.Feb 4 2015, 7:09 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Feb 5 2015, 1:08 AM
Krinkle added a parent task: T87160: ~200ms spent on CSSStyleDeclaration.getPropertyValue() due to jQuery hide()/show().Feb 5 2015, 2:56 AM
gerritbot added a project: Patch-For-Review.Feb 5 2015, 10:22 PM

Change 187617 had a related patch set uploaded (by Mooeypoo):
Use css class rather than jQuery show/hide

https://gerrit.wikimedia.org/r/187617

Patch-For-Review

gerritbot added a comment.Feb 6 2015, 7:08 PM

Change 187618 merged by jenkins-bot:
Use css class instead of jquery show/hide

https://gerrit.wikimedia.org/r/187618

Mooeypoo mentioned this in rEVED8a53b2cd07ec: Use css class instead of jquery show/hide.Feb 6 2015, 7:09 PM
gerritbot added a comment.Feb 6 2015, 11:31 PM

Change 187617 merged by jenkins-bot:
Use css class rather than jQuery show/hide

https://gerrit.wikimedia.org/r/187617

gerritbot added a comment.Feb 7 2015, 12:43 AM

Change 189144 had a related patch set uploaded (by Catrope):
Use css class instead of jquery show/hide

https://gerrit.wikimedia.org/r/189144

Patch-For-Review

gerritbot added a comment.Feb 9 2015, 11:56 PM

Change 189144 merged by jenkins-bot:
Use css class instead of jquery show/hide

https://gerrit.wikimedia.org/r/189144

Catrope mentioned this in rEVED0054f33d7f6a: Use css class instead of jquery show/hide.Feb 9 2015, 11:57 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 19 2015, 9:36 PM
ori moved this task from Next up to Doing on the VisualEditor-Performance board.Feb 21 2015, 6:12 AM
ori moved this task from Doing to Done on the VisualEditor-Performance board.
Mooeypoo mentioned this in rGVEDce11fb3ed97b: Use css class rather than jQuery show/hide.Mar 3 2015, 7:38 PM
Mooeypoo mentioned this in rGOJUc762da42fd40: Use css class instead of jQuery .show()/hide()/toggle().Mar 3 2015, 7:50 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL