Page MenuHomePhabricator
Create Task
Maniphest T87928

Convert GWToolset to use extension registration
Closed, ResolvedPublic
Actions

Description

The GWToolset extension needs to be converted to use the new extension registration system. More details are available on T87875.

Details

SubjectRepoBranchLines +/-
Convert GWToolset to extension.json etcoperations/mediawiki-configmaster+4 -8
Re-instate "Convert GWToolset to extension registration"mediawiki/extensions/GWToolsetmaster+178 -163
GWToolset migratory configoperations/mediawiki-configmaster+5 -1
Add extension.jsonmediawiki/extensions/GWToolsetmaster+152 -0
Revert "Convert GWToolset to extension registration"mediawiki/extensions/GWToolsetmaster+147 -167
Convert GWToolset to extension registrationmediawiki/extensions/GWToolsetmaster+167 -147
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT87875 Convert all Wikimedia-deployed extensions and skins to use extension registration
ResolvedJeanFredT87928 Convert GWToolset to use extension registration
Resolvedbd808T126830 GWToolset causes fatal error on beta cluster
· · ·

Event Timeline

Legoktm added a project: MediaWiki-extensions-GWToolset.Jan 29 2015, 7:32 PM
Legoktm subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptJan 29 2015, 7:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Legoktm added a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Jan 29 2015, 7:37 PM
Liuxinyu970226 subscribed.Feb 1 2015, 2:26 AM
Jdforrester-WMF triaged this task as Low priority.Sep 4 2015, 6:56 PM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptSep 4 2015, 6:56 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 7:03 PM
Liuxinyu970226 updated the task description. (Show Details)Sep 6 2015, 11:15 PM
Liuxinyu970226 set Security to None.
JeanFred moved this task from Backlog to Internals on the MediaWiki-extensions-GWToolset board.Feb 2 2016, 6:39 PM
Restricted Application added a project: Commons. · View Herald TranscriptFeb 2 2016, 6:39 PM
JeanFred subscribed.Feb 6 2016, 10:11 PM

(Disclaimer: I have close to no clue to what I’m doing here :-D)

I submitted a patch at https://gerrit.wikimedia.org/r/#/c/268897 (not sure why GerritBot did not pick it up), based on the conversion script and looking up other converted extensions (mainly Gadgets).

@Legoktm, does the patch make sense?

Liuxinyu970226 assigned this task to JeanFred.Feb 7 2016, 12:13 AM
Liuxinyu970226 added a project: Patch-For-Review.
gerritbot subscribed.Feb 11 2016, 9:34 PM

Change 268897 had a related patch set uploaded (by Jean-Frédéric):
Convert GWToolset to extension registration

https://gerrit.wikimedia.org/r/268897

gerritbot added a comment.Feb 12 2016, 8:23 PM

Change 268897 merged by jenkins-bot:
Convert GWToolset to extension registration

https://gerrit.wikimedia.org/r/268897

JeanFred closed this task as Resolved.Feb 12 2016, 8:34 PM

Done :)

hashar subscribed.Feb 13 2016, 12:11 AM

Probably causes fatal error on beta cluster T126830: GWToolset causes fatal error on beta cluster

Liuxinyu970226 unsubscribed.Feb 13 2016, 3:01 AM
bd808 subscribed.Feb 13 2016, 5:56 AM

This should have been reverted due to the beta cluster breakage.

gerritbot added a comment.Feb 13 2016, 6:00 AM

Change 270468 had a related patch set uploaded (by BryanDavis):
Revert "Convert GWToolset to extension registration"

https://gerrit.wikimedia.org/r/270468

bd808 added a subtask: T126830: GWToolset causes fatal error on beta cluster.Feb 13 2016, 6:02 AM
gerritbot added a comment.Feb 13 2016, 6:05 AM

Change 270468 merged by jenkins-bot:
Revert "Convert GWToolset to extension registration"

https://gerrit.wikimedia.org/r/270468

bd808 reopened this task as Open.Feb 13 2016, 6:28 AM

Changes have been temporarily reverted to fix T126830: GWToolset causes fatal error on beta cluster

bd808 mentioned this in T126830: GWToolset causes fatal error on beta cluster.Feb 13 2016, 6:30 AM
bd808 closed subtask T126830: GWToolset causes fatal error on beta cluster as Resolved.
Stashbot subscribed.Feb 13 2016, 6:32 AM

Mentioned in SAL [2016-02-13T06:32:22Z] <bd808> jobrunner on deployment-jobrunner01 enabled after reverting changes from T87928 that caused T126830

Legoktm added a comment.Feb 13 2016, 7:21 AM

Sorry, I should have been more suspicious about no config options in extension.json :/

We'll need some kind of back compat wrapper for that Config class in the PHP shim, and transition it over to a global variable, kind of like what MaxSem did.

Steinsplitter moved this task from Incoming to Backlog on the Commons board.Feb 13 2016, 5:35 PM
JeanFred added a comment.Feb 14 2016, 4:48 PM

Arf, sorry this caused a mess :-/

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 16 2016, 7:02 PM
hashar added a comment.Feb 17 2016, 9:18 AM
In T87928#2027139, @JeanFred wrote:

Arf, sorry this caused a mess :-/

One can't bake an omelette without breaking eggs -:D No worries.

Now I am wondering how coupled the change will be with operations/mediawiki-config.git.

Reedy removed projects: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), Patch-For-Review.Jul 11 2016, 8:18 PM
Restricted Application added a subscriber: Poyekhali. · View Herald TranscriptJul 11 2016, 8:18 PM
zhuyifei1999 removed a project: Commons.Jul 25 2017, 10:20 AM
MarcoAurelio mentioned this in T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Nov 18 2017, 6:15 PM
Reedy subscribed.Nov 18 2017, 6:28 PM
In T87928#2025030, @Legoktm wrote:

Sorry, I should have been more suspicious about no config options in extension.json :/

We'll need some kind of back compat wrapper for that Config class in the PHP shim, and transition it over to a global variable, kind of like what MaxSem did.

Do we remember what MaxSem did where?

gerritbot added a comment.Nov 18 2017, 6:50 PM

Change 392216 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/GWToolset@master] Add extension.json

https://gerrit.wikimedia.org/r/392216

gerritbot added a project: Patch-For-Review.Nov 18 2017, 6:50 PM
MarcoAurelio subscribed.Nov 18 2017, 6:55 PM

What a mess. 74 errors in jenkins with only extension.json added :-/

gerritbot added a comment.Nov 18 2017, 7:08 PM

Change 392217 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/GWToolset@master] Re-instate "Convert GWToolset to extension registration"

https://gerrit.wikimedia.org/r/392217

gerritbot added a comment.Nov 18 2017, 7:11 PM

Change 392216 abandoned by MarcoAurelio:
Add extension.json

Reason:
Per https://gerrit.wikimedia.org/r/#/c/392217/

https://gerrit.wikimedia.org/r/392216

gerritbot added a comment.Nov 18 2017, 7:26 PM

Change 392218 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] GWToolset migratory config

https://gerrit.wikimedia.org/r/392218

gerritbot added a comment.Nov 18 2017, 7:26 PM

Change 392219 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Convert GWToolset to extension.json etc

https://gerrit.wikimedia.org/r/392219

gerritbot added a comment.Nov 23 2017, 12:45 PM

Change 392218 merged by jenkins-bot:
[operations/mediawiki-config@master] GWToolset migratory config

https://gerrit.wikimedia.org/r/392218

Reedy added a comment.Nov 23 2017, 12:47 PM

If I get the extension patch merged... Is there anyone that knows how to test it on beta?

Stashbot added a comment.Nov 23 2017, 12:47 PM

Mentioned in SAL (#wikimedia-operations) [2017-11-23T12:47:31Z] <reedy@tin> Synchronized wmf-config/CommonSettings.php: GWToolset migratory config T87928 (duration: 00m 46s)

gerritbot added a comment.Jul 27 2018, 1:02 AM

Change 392217 merged by jenkins-bot:
[mediawiki/extensions/GWToolset@master] Re-instate "Convert GWToolset to extension registration"

https://gerrit.wikimedia.org/r/392217

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 27 2018, 2:00 AM
hashar closed this task as Resolved.Jul 27 2018, 8:05 AM
gerritbot added a comment.Aug 8 2018, 11:37 PM

Change 392219 merged by jenkins-bot:
[operations/mediawiki-config@master] Convert GWToolset to extension.json etc

https://gerrit.wikimedia.org/r/392219

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits