The GWToolset extension needs to be converted to use the new extension registration system. More details are available on T87875.
Description
Details
Status | Subtype | Assigned | Task | |
---|---|---|---|---|
· · · | ||||
Resolved | None | T87875 Convert all Wikimedia-deployed extensions and skins to use extension registration | ||
Resolved | JeanFred | T87928 Convert GWToolset to use extension registration | ||
Resolved | bd808 | T126830 GWToolset causes fatal error on beta cluster | ||
· · · |
Event Timeline
(Disclaimer: I have close to no clue to what I’m doing here :-D)
I submitted a patch at https://gerrit.wikimedia.org/r/#/c/268897 (not sure why GerritBot did not pick it up), based on the conversion script and looking up other converted extensions (mainly Gadgets).
@Legoktm, does the patch make sense?
Change 268897 had a related patch set uploaded (by Jean-Frédéric):
Convert GWToolset to extension registration
Probably causes fatal error on beta cluster T126830: GWToolset causes fatal error on beta cluster
Change 270468 had a related patch set uploaded (by BryanDavis):
Revert "Convert GWToolset to extension registration"
Change 270468 merged by jenkins-bot:
Revert "Convert GWToolset to extension registration"
Changes have been temporarily reverted to fix T126830: GWToolset causes fatal error on beta cluster
Mentioned in SAL [2016-02-13T06:32:22Z] <bd808> jobrunner on deployment-jobrunner01 enabled after reverting changes from T87928 that caused T126830
Sorry, I should have been more suspicious about no config options in extension.json :/
We'll need some kind of back compat wrapper for that Config class in the PHP shim, and transition it over to a global variable, kind of like what MaxSem did.
One can't bake an omelette without breaking eggs -:D No worries.
Now I am wondering how coupled the change will be with operations/mediawiki-config.git.
Change 392216 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/GWToolset@master] Add extension.json
Change 392217 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/GWToolset@master] Re-instate "Convert GWToolset to extension registration"
Change 392216 abandoned by MarcoAurelio:
Add extension.json
Reason:
Per https://gerrit.wikimedia.org/r/#/c/392217/
Change 392218 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] GWToolset migratory config
Change 392219 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Convert GWToolset to extension.json etc
Change 392218 merged by jenkins-bot:
[operations/mediawiki-config@master] GWToolset migratory config
If I get the extension patch merged... Is there anyone that knows how to test it on beta?
Mentioned in SAL (#wikimedia-operations) [2017-11-23T12:47:31Z] <reedy@tin> Synchronized wmf-config/CommonSettings.php: GWToolset migratory config T87928 (duration: 00m 46s)
Change 392217 merged by jenkins-bot:
[mediawiki/extensions/GWToolset@master] Re-instate "Convert GWToolset to extension registration"
Change 392219 merged by jenkins-bot:
[operations/mediawiki-config@master] Convert GWToolset to extension.json etc