Regression, seen 12 February:
Edit any page at http://en.wikipedia.beta.wmflabs.org
From the hamburger menu in the upper right choose 'Advanced settings'
Click 'Enable display title' and fill in some text in the box
Click Apply changes, then Save page, then Review your changes
Display title text should appear in the diff view but does not appear at all.
<Krenair> it seems like a bit more than just "Display title no longer appears in diff view"
<Krenair> I tried setting a display title on beta and part of the page was duplicated in the diff
This is a bug in Parsoid, specifically in selser. When you add <meta property="mw:PageProp/displaytitle" content="fsdf"> at the top of the <body>, Parsoid without selser handles this just fine, and with selser it doesn't output the displaytitle and instead duplicates the entire page's content.
$ echo "Foo" | node tests/parse.js > orightml $ cp orightml modhtml $ vi modhtml # Add <meta property="mw:PageProp/displaytitle" content="fsdf"> to the start of the <body> $ node tests/parse.js --html2wt < modhtml [warning][enwiki/Main Page] displaytitle is missing source. Rendering as DISPLAYTITLE magicword {{DISPLAYTITLE:fsdf}} Foo $ node tests/parse.js --html2wt --selser --oldtext=Foo --oldhtmlfile=orightml < modhtml Foo Foo
Change 190595 had a related patch set uploaded (by Subramanya Sastry):
T89383: Check for validity of DSR before fetching wikitext for it
Change 190595 merged by jenkins-bot:
T89383: Check for validity of DSR before fetching wikitext for it