Page MenuHomePhabricator
Create Task
Maniphest T91158

[Regression] VisualEditor no long able to rescue itself from badtoken error state on save
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

The the browser starts sending requests to the visualeditoredit API and goes on repeating them forever. An example request (in cURL format) is P342. The response is always a badtoken error. The token does not change between requests.

The interface is unresponsive (none of the buttons work); Esc closes the save window but does not stop the request loop.

Could not reproduce, after reloading the page and redoing the edit it was saved successfully.

A lot of time passed between opening the page and starting to edit in VE, but not a lot of time between starting to edit and saving.

Details

SubjectRepoBranchLines +/-
ve.init.mw.Target: Don't go into infinite recursion on API errorsmediawiki/extensions/VisualEditorwmf/1.25wmf20+9 -3
ve.init.mw.Target: Don't go into infinite recursion on API errorsmediawiki/extensions/VisualEditorwmf/1.25wmf19+9 -3
ve.init.mw.Target: Don't go into infinite recursion on API errorsmediawiki/extensions/VisualEditormaster+9 -3
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Feb 28 2015, 6:46 AM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added a project: VisualEditor.
Tgr subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2015, 6:46 AM
Jdforrester-WMF renamed this task from VisualEditor gets into endless visualeditoredit API loop when saving the page to VisualEditor got into endless visualeditoredit API loop when saving the page.Mar 2 2015, 12:57 AM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.
Jdforrester-WMF set Security to None.
Catrope subscribed.Mar 2 2015, 7:45 AM

Could this be a regression from when we moved to mw.Api recently?

Catrope added a subscriber: Krenair.Mar 2 2015, 7:45 AM
matmarex added subscribers: matmarex, Krinkle, • Manybubbles.Mar 4 2015, 11:03 PM

Timo and Nik complained about running into this issue too.

• Manybubbles added a comment.Mar 4 2015, 11:04 PM

I believe I hit this today. I've since closed the tab so my browser is no use, sorry!

matmarex added a comment.Mar 4 2015, 11:18 PM

VisualEditor definitely does quite a bit of manual token handling instead of using postWithToken (although I don't see obvious mistakes at a glance). Not sure if the internal action=visualeditor API is incompatible with that, or if the code just predates postWithToken.

• RobLa-WMF subscribed.Mar 4 2015, 11:23 PM

I'm pretty sure I hit this bug when I made this edit on mediawiki.org on 2015-02-26. Roan and Moriel helped me recover the edit by doing the following:

  1. Run the javascript console
  2. Type copy(ve.init.target.docToSave.documentElement.outerHTML) (Congratulations! You have the parsoid HTML in the clipboard. Save it to a safe text buffer if you're paranoid)
  3. Visit the parsoid HTML to wikitext converter (change the URL for the wiki you're on)
  4. Paste the parsoid HTML and submit
  5. Copy/paste this wikitext in the source editor for the article.

This bug seems pretty high priority. I realize there isn't too much that can be done until there's a reliable repro, but it might be worth more actively working on whatever instrumentation/testing necessary to see this in action.

Krenair added a project: VisualEditor-MediaWiki.Mar 4 2015, 11:25 PM
Aklapper raised the priority of this task from Medium to High.Mar 5 2015, 10:25 AM
Aklapper added a project: VisualEditor 2014/15 Q3 blockers.
matmarex claimed this task.Mar 6 2015, 12:09 AM

Easy to reproduce, at least. Just make the edit token that VE stores invalid (ve.init.target.editToken = 'foo') and try saving the page.

Jdforrester-WMF renamed this task from VisualEditor got into endless visualeditoredit API loop when saving the page to [Regression] VisualEditor no long able to rescue itself from badtoken error state on save.Mar 6 2015, 12:14 AM
Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.
Jdforrester-WMF edited a custom field.
matmarex added a comment.EditedMar 6 2015, 12:24 AM

At a quick glance, we have several different code paths towards saving (thanks to speculative save feature), and none of them implements badtoken handling right (although some try). I'm going to redo it all with postWithToken, it looks easier than trying to understand the twisted logic.

(added: Actually, I'm not.)

gerritbot subscribed.Mar 6 2015, 1:49 AM

Change 194783 had a related patch set uploaded (by Bartosz Dziewoński):
ve.init.mw.Target: Don't go into infinite recursion on API errors

https://gerrit.wikimedia.org/r/194783

gerritbot added a project: Patch-For-Review.Mar 6 2015, 1:49 AM
gerritbot added a comment.Mar 6 2015, 11:20 AM

Change 194783 merged by jenkins-bot:
ve.init.mw.Target: Don't go into infinite recursion on API errors

https://gerrit.wikimedia.org/r/194783

matmarex mentioned this in rEVED1656d3495ee0: ve.init.mw.Target: Don't go into infinite recursion on API errors.Mar 6 2015, 11:20 AM
gerritbot added a comment.Mar 6 2015, 3:46 PM

Change 194869 had a related patch set uploaded (by Jforrester):
ve.init.mw.Target: Don't go into infinite recursion on API errors

https://gerrit.wikimedia.org/r/194869

gerritbot added a comment.Mar 6 2015, 3:46 PM

Change 194870 had a related patch set uploaded (by Jforrester):
ve.init.mw.Target: Don't go into infinite recursion on API errors

https://gerrit.wikimedia.org/r/194870

Jdforrester-WMF added projects: WMF-deploy-2015-02-25_(1.25wmf19), WMF-deploy-2015-03-04_(1.25wmf20), WMF-deploy-2015-03-11_(1.25wmf21).Mar 6 2015, 3:46 PM
gerritbot added a comment.Mar 6 2015, 4:26 PM

Change 194869 merged by jenkins-bot:
ve.init.mw.Target: Don't go into infinite recursion on API errors

https://gerrit.wikimedia.org/r/194869

gerritbot added a comment.Mar 6 2015, 4:26 PM

Change 194870 merged by jenkins-bot:
ve.init.mw.Target: Don't go into infinite recursion on API errors

https://gerrit.wikimedia.org/r/194870

Jdforrester-WMF mentioned this in rEVED9f6034a4b19a: ve.init.mw.Target: Don't go into infinite recursion on API errors.Mar 6 2015, 4:26 PM
Jdforrester-WMF mentioned this in rEVED7a32a0b531e2: ve.init.mw.Target: Don't go into infinite recursion on API errors.
Jdforrester-WMF closed this task as Resolved.Mar 6 2015, 4:31 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.
Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.
Jdforrester-WMF removed a project: Patch-For-Review.Mar 10 2015, 4:23 PM
matmarex mentioned this in T91949: Visual Editor save dialog hangs, causing data loss.Mar 24 2015, 5:15 PM
Jdforrester-WMF merged a task: T91949: Visual Editor save dialog hangs, causing data loss.Mar 24 2015, 5:18 PM
Jdforrester-WMF added subscribers: Jdforrester-WMF, LuisVilla.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL