Page MenuHomePhabricator
Create Task
Maniphest T91466

Undefined index "5::duration" in ApiQueryLogEvents for block entries
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted in production:

270 Notice: Undefined index: 5::duration in /srv/mediawiki/php-1.25wmf19/includes/api/ApiQueryLogEvents.php on line 327
270 Notice: Undefined index: 5::duration in /srv/mediawiki/php-1.25wmf19/includes/api/ApiQueryLogEvents.php on line 325
270 Notice: Undefined index: 5::duration in /srv/mediawiki/php-1.25wmf19/includes/api/ApiQueryLogEvents.php on line 321

Introduced by https://gerrit.wikimedia.org/r/#/c/192266/
rMWce4af8b87374: Fix parameter order for block logs

Details

ProjectBranchLines +/-Subject
mediawiki/coreREL1_25+471 -197API: Move parameter formatting into LogFormatter
mediawiki/coremaster+452 -178API: Move parameter formatting into LogFormatter
mediawiki/corewmf/1.25wmf21+4 -2Pass if log entry is legacy to ApiQueryLogEvents::addLogParams()
mediawiki/corewmf/1.25wmf20+4 -2Pass if log entry is legacy to ApiQueryLogEvents::addLogParams()
mediawiki/coremaster+4 -2Pass if log entry is legacy to ApiQueryLogEvents::addLogParams()
Customize query in gerrit

Related Objects

Event Timeline

demon created this task.Mar 3 2015, 11:17 PM
demon raised the priority of this task from to Needs Triage.
demon updated the task description. (Show Details)
demon added projects: Wikimedia-production-error, MediaWiki-Action-API.
demon added a subscriber: demon.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2015, 11:17 PM
greg triaged this task as High priority.Mar 3 2015, 11:49 PM
greg set Security to None.
greg added subscribers: Anomie, greg.

@Anomie: Do you have the time to take a look at this one?

Anomie added a comment.Mar 4 2015, 12:43 AM

https://gerrit.wikimedia.org/r/#/c/183315/ should take care of it by
killing that whole stupid function.

Krinkle updated the task description. (Show Details)Mar 4 2015, 12:47 AM
gerritbot added a subscriber: gerritbot.Mar 4 2015, 1:56 AM

Change 183315 had a related patch set uploaded (by Greg Grossmeier):
API: Move parameter formatting into LogFormatter

https://gerrit.wikimedia.org/r/183315

gerritbot added a project: Patch-For-Review.Mar 4 2015, 1:56 AM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Mar 4 2015, 2:11 PM
Umherirrender added a subscriber: Umherirrender.Mar 4 2015, 5:06 PM

Is there a dbname or a request where this is shown? All non-legacy log entry should have these array keys.

demon raised the priority of this task from High to Unbreak Now!.Mar 12 2015, 5:48 PM

No we don't. Feel free to add some additional logging here and we can pull it into production.

Raising priority as this is currently drowning out all other production logs.

Krenair added a project: CheckUser.Mar 12 2015, 6:45 PM
Krenair added a subscriber: Krenair.

I think this happens when you try to get a block log entry created by the CheckUser extension (which uses legacy logging still) via the recent changes API. ApiQueryRecentChanges does not pass $logEntry->isLegacy(), so it defaults to false, tries to get param 5::duration instead of 0, causing an error.

Visiting http://en.wikipedia.org/w/api.php?action=query&list=recentchanges&rcprop=loginfo&rctype=log&rcstart=20150312084618 for example, causes the number on fatalmonitor's entry for this bug to go up.

gerritbot added a comment.Mar 12 2015, 6:57 PM

Change 196299 had a related patch set uploaded (by Chad):
Pass if log entry is legacy to ApiQueryLogEvents::addLogParams()

https://gerrit.wikimedia.org/r/196299

Umherirrender added a comment.Mar 12 2015, 7:12 PM

Moved the CheckUser part to T92546

Umherirrender removed a project: CheckUser.Mar 12 2015, 7:12 PM
gerritbot added a comment.Mar 12 2015, 7:15 PM

Change 196299 merged by jenkins-bot:
Pass if log entry is legacy to ApiQueryLogEvents::addLogParams()

https://gerrit.wikimedia.org/r/196299

demon mentioned this in rMWcc2eb92668cd: Pass if log entry is legacy to ApiQueryLogEvents::addLogParams().Mar 12 2015, 7:16 PM
Umherirrender closed this task as Resolved.Mar 12 2015, 7:17 PM
Umherirrender claimed this task.
Umherirrender reassigned this task from Umherirrender to demon.
Umherirrender added a project: WMF-Server-Backports.
gerritbot added a comment.Mar 12 2015, 7:36 PM

Change 196313 had a related patch set uploaded (by Alex Monk):
Pass if log entry is legacy to ApiQueryLogEvents::addLogParams()

https://gerrit.wikimedia.org/r/196313

gerritbot added a comment.Mar 12 2015, 7:37 PM

Change 196317 had a related patch set uploaded (by Alex Monk):
Pass if log entry is legacy to ApiQueryLogEvents::addLogParams()

https://gerrit.wikimedia.org/r/196317

gerritbot added a comment.Mar 13 2015, 12:19 AM

Change 196317 merged by jenkins-bot:
Pass if log entry is legacy to ApiQueryLogEvents::addLogParams()

https://gerrit.wikimedia.org/r/196317

Krenair mentioned this in rMWf34376a53726: Pass if log entry is legacy to ApiQueryLogEvents::addLogParams().Mar 13 2015, 12:19 AM
gerritbot added a comment.Mar 13 2015, 12:30 AM

Change 196313 merged by jenkins-bot:
Pass if log entry is legacy to ApiQueryLogEvents::addLogParams()

https://gerrit.wikimedia.org/r/196313

Krenair mentioned this in rMW5e719ac0ee77: Pass if log entry is legacy to ApiQueryLogEvents::addLogParams().Mar 13 2015, 12:31 AM
Umherirrender mentioned this in T92637: Phabricator sorts actions in wrong order.Mar 13 2015, 5:11 PM
gerritbot added a comment.Apr 17 2015, 5:11 AM

Change 183315 merged by jenkins-bot:
API: Move parameter formatting into LogFormatter

https://gerrit.wikimedia.org/r/183315

Legoktm mentioned this in rMW61233fc84724: API: Move parameter formatting into LogFormatter.Apr 17 2015, 5:11 AM
gerritbot added a comment.Apr 29 2015, 5:02 PM

Change 207494 had a related patch set uploaded (by Anomie):
API: Move parameter formatting into LogFormatter

https://gerrit.wikimedia.org/r/207494

gerritbot added a comment.Apr 29 2015, 7:04 PM

Change 207494 merged by jenkins-bot:
API: Move parameter formatting into LogFormatter

https://gerrit.wikimedia.org/r/207494

Anomie mentioned this in rMW057be7139f40: API: Move parameter formatting into LogFormatter.Apr 29 2015, 7:05 PM
demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jun 12 2015, 6:35 PM
Ricordisamoa added a subscriber: Ricordisamoa.Aug 2 2015, 4:22 AM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL