Align the puppet-lint config with https://wikitech.wikimedia.org/wiki/Puppet_coding#Coding_Style and make a jenkins job vote -1 on violation.
The following checks are currently disabled in the config despite the coding style requiring them:
# WONTFIX - We want at least 100. # Lot of long lines (ssh keys for example). --no-80chars-check # T127797 - needs at least one comment line for each class --no-documentation-check
| rOPUP Wikimedia Puppet | |||
| rOPUP3577c5f9f759 datasets: indentation fixes | |||
| rOPUPfd092106e26f chromium: indentation fix | |||
| rOPUP9743ea442364 apt: indentation fixes | |||
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Dzahn | T93645 align puppet-lint config with coding style | |||
| Duplicate | None | T93642 fix failures of jenkins job operations-puppet-puppetlint-strict | |||
| Resolved | Andrew | T125042 fix all "top-scope variable being used without an explicit namespace" across the puppet repo | |||
| Resolved | jbond | T127797 document all puppet classes / defined types!? | |||
| Resolved | Joe | T119042 Import vs autoload: the puppet parser is a bad joke that stopped being funny years ago. | |||
| Resolved | Legoktm | T144774 Add a Jenkins check that forbids creation of /modules/role/manifests/*.pp | |||
| Resolved | Dzahn | T133222 put lint:ignore documention on wikitech | |||
| Resolved | jcrespo | T150850 Decouple roles from mariadb.pp into their own file | |||
| Resolved | Marostegui | T150851 Moving backup and otrs role into their own .pp | |||
| Resolved | jcrespo | T152081 Moving eventlogging mariadb role into its own .pp | |||
| Resolved | Ottomata | T152621 Refactor eventlogging.pp role into multiple files (and maybe get rid of inheritance) |
It would be nice if we had a puppet-lint check for the full names and trailing commas that @Juniorsys just fixed.
@scfc +1 It should be a bug/feature request with upstream puppet-lint. Care to make one? Also, we should check if it's not just about the puppet-lint version. Might be detected in newer versions than the one we have installed in prod / on our local machines.
Change 334276 had a related patch set uploaded (by Juniorsys):
Linting fixes (Multiple modules)
Change 334278 had a related patch set uploaded (by Juniorsys):
deployment: Linting fixes
Change 334279 had a related patch set uploaded (by Juniorsys):
dnsrecursor: Linting fixes
Change 334283 had a related patch set uploaded (by Juniorsys):
eventlogging/eventstreams: Linting fixes
Change 334285 had a related patch set uploaded (by Juniorsys):
gerrit/git/graphite: Linting fixes
Change 334287 had a related patch set uploaded (by Juniorsys):
jupterhub/keyholder: Linting fixes
Change 334288 had a related patch set uploaded (by Juniorsys):
jenkins: Linting fixes
Change 334290 had a related patch set uploaded (by Juniorsys):
labs modules linting changes
Change 334293 had a related patch set uploaded (by Juniorsys):
librenms/locales/logstash/lshell linting changes
Change 334294 had a related patch set uploaded (by Juniorsys):
lvm/lvs: Linting changes
Change 334295 had a related patch set uploaded (by Juniorsys):
Linting changes (multiple)
Change 334297 had a related patch set uploaded (by Juniorsys):
monitoring: linting changes
Change 334299 had a related patch set uploaded (by Juniorsys):
Linting changes (multiple)
Change 334300 had a related patch set uploaded (by Juniorsys):
ores/otrs/package_builder: Linting changes
Change 334301 had a related patch set uploaded (by Juniorsys):
openstack: Linting changes
Change 334302 had a related patch set uploaded (by Juniorsys):
phabricator: Linting changes
Change 334303 had a related patch set uploaded (by Juniorsys):
profile linting changes
Change 334306 had a related patch set uploaded (by Juniorsys):
prometheus: Linting changes
Change 334307 had a related patch set uploaded (by Juniorsys):
puppet/puppet_compiler: Linting changes
Change 334308 had a related patch set uploaded (by Juniorsys):
planet/pmacct/programdashboard/pybal lint changes
Change 334309 had a related patch set uploaded (by Juniorsys):
quarry: Linting changes
Change 334310 had a related patch set uploaded (by Juniorsys):
role: Linting changes (backup,bastionhost others)
Change 334311 had a related patch set uploaded (by Juniorsys):
redis: Linting changes
Change 334313 had a related patch set uploaded (by Juniorsys):
Linting changes (multiple)
Change 334317 had a related patch set uploaded (by Juniorsys):
Linting fixes (multiple modules)
Change 334319 had a related patch set uploaded (by Juniorsys):
graphoid/gridengine/grub/haproxy/hhvm lint fixes
Change 334320 had a related patch set uploaded (by Juniorsys):
ifttt/imagemagick/initramfs/interface lint fixes
Change 334310 abandoned by Juniorsys:
role: Linting changes (backup,bastionhost others)
Change 334320 abandoned by Juniorsys:
ifttt/imagemagick/initramfs/interface lint fixes
Change 336668 had a related patch set uploaded (by Dzahn):
bastionhost,bugzilla: lint fixes
Change 336672 had a related patch set uploaded (by Dzahn):
multiple roles: lint-fix role::backup::host includes
Change 336715 had a related patch set uploaded (by Dzahn):
multiple roles: lint-fix base::firewall includes
Change 336720 had a related patch set uploaded (by Dzahn):
multiple roles: lint-fix standard/base::firewall includes
Change 336720 merged by Dzahn:
multiple roles: lint-fix standard/base::firewall includes
Change 336728 had a related patch set uploaded (by Dzahn):
mirrors: lint-ignore 'passwords::mirrors not in autoload module layout'
Change 336728 merged by Dzahn:
mirrors: lint-ignore 'passwords::mirrors not in autoload module layout'
Change 336731 had a related patch set uploaded (by Dzahn):
mariadb: ingore lint warnings about autoloader layout
Change 336735 had a related patch set uploaded (by Dzahn):
puppet-lint: remove exception for wrong autoloader layout
Change 336735 merged by Dzahn:
puppet-lint: remove exception for wrong autoloader layout
--no-autoloader_layout-check is gone which is quite an achievement!
The last ones are:
With the exception of those two checks, all others have been fixed and are enforced by CI. There are two sub tasks which do not trigger puppet-lint errors:
So maybe they should no more be blockers and we can just close this parent task T93645?
@hashar Thank you for this. Last night i was thinking about this and i was planning to write almost the same summary that you wrote above :) And i came to the same conclusion, thinking that maybe we can close this now. This is by its nature a very open-ended task, but if any time was good to call it resolved then it seems now because, yes, we do not have any more exceptions in .puppet-lint.rc besides the ones we will not fix ever or at least not ever make mandatory. I think even if we resolved the "document all classes" ticket we would not want to let jenkins vote -2 just for that. So yes, let's call it resolved. It's been a long way to here and as you say , quite an achievement. YAY! :)
What can still be done here optionally is remove "lint::ignore" lines and fix the issues that they are ignoring.
manifests/site.pp: # lint:ignore:case_without_default
manifests/site.pp: # lint:ignore:case_without_default
manifests/site.pp: # lint:ignore:case_without_default
manifests/realm.pp:# lint:ignore:only_variable_string
modules/statistics/manifests/user.pp: # lint:ignore:arrow_alignment
modules/locales/manifests/all.pp: # lint:ignore:case_without_default
modules/eventlogging/manifests/service/service.pp: # lint:ignore:variable_scope
modules/eventlogging/manifests/service/service.pp: # lint:ignore:variable_scope
modules/ores/manifests/web.pp: # lint:ignore:arrow_alignment
modules/install_server/manifests/tftp_server.pp: # lint:ignore:puppet_url_without_modules
modules/diamond/manifests/collector/extendedexim.pp: # lint:ignore:quoted_booleans
modules/diamond/manifests/collector/localcrontab.pp: # lint:ignore:quoted_booleans
modules/diamond/manifests/init.pp: # lint:ignore:quoted_booleans
modules/puppetmaster/tests/puppetmaster.pp:# lint:ignore:autoloader_layout
modules/standard/manifests/diamond.pp: # lint:ignore:quoted_booleans
modules/backup/manifests/weeklyschedule.pp: # lint:ignore:arrow_alignment
modules/backup/manifests/schedule.pp: # lint:ignore:arrow_alignment
modules/geoip/manifests/data/puppet.pp: # lint:ignore:puppet_url_without_modules
modules/monitoring/manifests/host.pp: # lint:ignore:variable_scope
modules/monitoring/manifests/service.pp: # lint:ignore:variable_scope
modules/apertium/manifests/init.pp: # lint:ignore:arrow_alignment
modules/logstash/manifests/output/statsd.pp: # lint:ignore:variable_scope
modules/toollabs/manifests/check.pp:# lint:ignore:autoloader_layout
modules/sslcert/manifests/certificate.pp: # lint:ignore:puppet_url_without_modules
modules/base/manifests/standard_packages.pp: # lint:ignore:quoted_booleans
modules/base/manifests/environment.pp: # lint:ignore:arrow_alignment
modules/releases/manifests/reprepro.pp: # lint:ignore:puppet_url_without_modules
modules/releases/manifests/reprepro/upload.pp: # lint:ignore:puppet_url_without_modules
modules/cassandra/manifests/init.pp: # lint:ignore:only_variable_string
modules/cassandra/manifests/init.pp: # lint:ignore:only_variable_string
modules/striker/manifests/uwsgi.pp: # lint:ignore:single_quote_string_with_variables
modules/otrs/manifests/init.pp: # lint:ignore:arrow_alignment
modules/role/manifests/prometheus/tools.pp: # lint:ignore:single_quote_string_with_variables
modules/role/manifests/lists/server.pp: # lint:ignore:quoted_booleans
modules/role/manifests/postgres/slave.pp: # lint:ignore:variable_scope
modules/role/manifests/cache/kafka/statsv.pp: # lint:ignore:variable_scope
modules/role/manifests/cache/kafka/webrequest.pp: # lint:ignore:variable_scope
modules/role/manifests/cache/kafka/eventlogging.pp: # lint:ignore:variable_scope
modules/role/manifests/cache/instances.pp: # lint:ignore:arrow_alignment
modules/role/manifests/logstash/puppetreports.pp: # lint:ignore:puppet_url_without_modules
modules/role/manifests/logstash/eventlogging.pp: # lint:ignore:puppet_url_without_modules
modules/role/manifests/logstash/apifeatureusage.pp: # lint:ignore:puppet_url_without_modules
modules/role/manifests/logstash/collector.pp: # lint:ignore:puppet_url_without_modules
modules/role/manifests/logging/mediawiki/udp2log.pp: # lint:ignore:puppet_url_without_modules
modules/role/manifests/osm/slave.pp: # lint:ignore:variable_scope
modules/role/manifests/otrs/webserver.pp: # lint:ignore:puppet_url_without_modules
modules/role/manifests/labs/openstack/nova/compute.pp: # lint:ignore:quoted_booleans
modules/role/manifests/labs/dns.pp: # lint:ignore:quoted_booleans
modules/role/manifests/labs/dns.pp: # lint:ignore:quoted_booleans
modules/role/manifests/graphite/base.pp: # lint:ignore:arrow_alignment
modules/role/manifests/graphite/base.pp: # lint:ignore:arrow_alignment
modules/role/manifests/access_new_install.pp: # lint:ignore:puppet_url_without_modules
modules/role/manifests/phabricator/main.pp: # lint:ignore:arrow_alignment
modules/role/manifests/ganglia/web.pp: # lint:ignore:variable_scope
modules/role/manifests/mariadb.pp:# lint:ignore:autoloader_layout
modules/role/manifests/mariadb.pp: # lint:ignore:puppet_url_without_modules
modules/torrus/tests/cdn.pp:# lint:ignore:autoloader_layout
modules/labstore/manifests/drbd/resource.pp:# lint:ignore:autoloader_layout
modules/mysql/manifests/php.pp:# lint:ignore:class_inherits_from_params_class
modules/mysql/manifests/java.pp:# lint:ignore:class_inherits_from_params_class
modules/mysql/manifests/server/package.pp: # lint:ignore:variable_scope
modules/mysql/manifests/server.pp:# lint:ignore:class_inherits_from_params_class
modules/mysql/manifests/config.pp:# lint:ignore:class_inherits_from_params_class
modules/mysql/manifests/ruby.pp:# lint:ignore:class_inherits_from_params_class
modules/mysql/manifests/python.pp:# lint:ignore:class_inherits_from_params_class
modules/mysql/manifests/init.pp:# lint:ignore:class_inherits_from_params_class
modules/mirrors/spec/fixtures/manifests/site.pp:# lint:ignore:autoloader_layout
modules/wikimetrics/manifests/web.pp: # lint:ignore:single_quote_string_with_variables
modules/mediawiki/manifests/hhvm.pp: # lint:ignore:arrow_alignment
modules/bacula/tests/director.pp:# lint:ignore:arrow_alignment
modules/apache/manifests/mod.pp:# lint:ignore:autoloader_layout
modules/apache/manifests/mod.pp:# lint:ignore:right_to_left_relationship lint:ignore:autoloader_layout
modules/apache/manifests/mod.pp:class apache::mod::status { # lint:ignore:autoloader_layout
modules/ganglia/manifests/views/hadoop.pp: # lint:ignore:variable_scope
modules/deployment/manifests/salt_master.pp: # lint:ignore:arrow_alignment
modules/deployment/manifests/salt_master.pp: # lint:ignore:arrow_alignment
modules/contint/manifests/packages/apt.pp: # lint:ignore:single_quote_string_with_variables
modules/contint/manifests/hhvm.pp: # lint:ignore:ensure_first_param
modules/contint/manifests/hhvm.pp: # lint:ignore:arrow_alignment
modules/openstack/manifests/designate/service.pp: # lint:ignore:ensure_first_param
modules/swift/manifests/ring.pp: # lint:ignore:puppet_url_without_modules
modules/profile/manifests/calico/builder.pp: # lint:ignore:puppet_url_without_modules
Binary file modules/profile/manifests/.base.pp.swp matches
modules/profile/manifests/base.pp: # lint:ignore:quoted_booleans
modules/labs_vmbuilder/manifests/init.pp: # lint:ignore:variable_scope
modules/puppet/manifests/self/master.pp: # lint:ignore:variable_scopeChange 334303 merged by Dzahn:
[operations/puppet] Linting changes for docker/etcd/kubernetes profiles
Change 322907 had a related patch set uploaded (by Hashar; owner: Dzahn):
[operations/puppet] puppet-lint: ignore 'lines over 140 chars' warnings
Change 322907 merged by Dzahn:
[operations/puppet] puppet-lint: ignore 'lines over 140 chars' warnings
Change 324915 abandoned by Jcrespo:
[operations/puppet@production] [WIP] Starting to cleanup mariadb templating structure
Reason:
No longer applicable