Page MenuHomePhabricator
Create Task
Maniphest T93988

Mobile site freezes up when anything bound to resize event (add debouncing)
Closed, ResolvedPublic
Actions

Description

We emit a resize event on every native browser event.
This is dumb. Apparently I did this ... I'm sorry :P
In Firefox if you run

mw.mobileFrontend.on( 'resize', function(){console.log(1); }

and then resize your window the browser will freeze

Details

SubjectRepoBranchLines +/-
Debounce resize and scroll eventsmediawiki/extensions/MobileFrontendwmf/1.25wmf23+4 -2
Debounce resize eventsmediawiki/extensions/MobileFrontendmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Mar 26 2015, 12:46 AM
kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added projects: Gather, Web-Team-Backlog.
kaldari subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2015, 12:46 AM
MaxSem triaged this task as Unbreak Now! priority.Mar 26 2015, 12:46 AM
MaxSem set Security to None.
Jdlrobson claimed this task.Mar 26 2015, 12:54 AM
Jdlrobson subscribed.

You can replicate this without Gather http://localhost:8888/w/index.php?title=Headings&article_action=signup-edit&mobileaction=stable so this issue is in MobileFrontend. Taking a look.

Jdlrobson edited projects, added Gather Sprint Diplodocus; removed Gather.Mar 26 2015, 12:55 AM
Jdlrobson renamed this task from Mobile site freezes up when resizing window on Gather-enabled pages to Mobile site freezes up when anything bound to resize event (add debouncing).Mar 26 2015, 1:10 AM
Jdlrobson updated the task description. (Show Details)

Got it. As suspected nothing to do with Gather.

gerritbot subscribed.Mar 26 2015, 1:11 AM

Change 199811 had a related patch set uploaded (by Jdlrobson):
Debounce resize events

https://gerrit.wikimedia.org/r/199811

gerritbot added a project: Patch-For-Review.Mar 26 2015, 1:11 AM
Jdlrobson moved this task from In Analysis to Code review needed on the Gather Sprint Diplodocus board.Mar 26 2015, 1:21 AM
• Jhernandez moved this task from Code review needed to Ready for signoff on the Gather Sprint Diplodocus board.Mar 26 2015, 10:50 AM
gerritbot added a comment.Mar 26 2015, 10:51 AM

Change 199811 merged by jenkins-bot:
Debounce resize events

https://gerrit.wikimedia.org/r/199811

Diffusion mentioned this in rMEXT1936143a8649: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 26 2015, 10:52 AM
Jdlrobson mentioned this in rEMFR20fbcf1302c8: Debounce resize events.Mar 26 2015, 10:52 AM
kaldari closed this task as Resolved.Mar 26 2015, 8:26 PM
Jdlrobson moved this task from Ready for signoff to Done on the Gather Sprint Diplodocus board.Mar 30 2015, 4:53 PM
Jdlrobson mentioned this in T94923: Article opened on Safari browser via iPhone froze app.Apr 3 2015, 8:27 PM
gerritbot added a comment.Apr 3 2015, 8:27 PM

Change 201840 had a related patch set uploaded (by Jdlrobson):
Debounce resize events

https://gerrit.wikimedia.org/r/201840

• Jhernandez subscribed.Apr 6 2015, 10:39 AM
Nnemo subscribed.Apr 6 2015, 11:16 AM
gerritbot added a comment.Apr 6 2015, 3:27 PM

Change 201840 merged by jenkins-bot:
Debounce resize and scroll events

https://gerrit.wikimedia.org/r/201840

Jdlrobson mentioned this in rEMFR4e8adcc4fa4a: Debounce resize and scroll events.Apr 6 2015, 3:27 PM
Jdlrobson mentioned this in T95561: On iOS 8.3 iPhone 5c in Private mode Safari, sometimes dragging/flicking doesn't scroll in modals.Apr 15 2015, 11:30 PM
Jdlrobson mentioned this in T89608: Crashing with new mobile Mozilla Firefox.
Jdlrobson merged a task: T89608: Crashing with new mobile Mozilla Firefox.Apr 16 2015, 4:09 PM
Jdlrobson added subscribers: Florian, Krenair, Thnidu.
• Phabricator_maintenance moved this task from Incoming to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:29 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMar 7 2018, 4:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL