svn.wikimedia.org links in pywikibot
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	Apr 6 2015, 2:17 AM

Description

There were two instance of 'svn.wikimedia.org'

One is for fetching the version, using a deprecated/fallback algorithm

pywikibot/version.py:                t[1] = t[1].replace('svn.wikimedia.org/svnroot/pywikipedia/',

The other https://git.wikimedia.org/blob/pywikibot%2Fcore.git/c3e31d4ebabfd0893b7d2d1e99bfc07b9290250c/pywikibot%2Fpage.py#L4394 refers to

# Normalize unicode string to a NFC (composed) format to allow
# proper string comparisons. According to
# https://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_6/phase3/includes/normal/UtfNormal.php?view=markup
# the MediaWiki code normalizes everything to NFC, not NFKC
# (which might result in information loss).
t = unicodedata.normalize('NFC', t)

This was introduced into core in c636fd0d , but it was originally added by @Yurik in compat in April 2006 30510907 & ed5e7395

The file it references (now at a more stable https://github.com/wikimedia/mediawiki/blob/REL1_6/includes/normal/UtfNormal.php) is now a shell https://github.com/wikimedia/mediawiki/blob/master/includes/libs/normal/UtfNormal.php

Using NFC became a large problem in 2010-2011, which is documented at T102461

Details

	Subject	Repo	Branch	Lines +/-
	[FEAT] version: Use svn info command	pywikibot/core	master	+70 -30
	Removing svn.wikimedia links in pywikibot	pywikibot/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• demon	T24596 Migrate subversion to git
Resolved	Dzahn	T88731 svn.wikimedia.org security certificate expired
Resolved	• demon	T86655 Decommission svn.wikimedia.org server (import SVN into Phabricator)
Resolved	Xqt	T95140 svn.wikimedia.org links in pywikibot
Resolved	jayvdb	T95077 pywikibot fails with SVN file formats before 12

Event Timeline

jayvdb created this task.Apr 6 2015, 2:17 AM

jayvdb raised the priority of this task from to Needs Triage.

jayvdb updated the task description. (Show Details)

jayvdb added projects: Pywikibot, Pywikibot-compat.

jayvdb subscribed.

Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptApr 6 2015, 2:17 AM

jayvdb added a subtask: T95077: pywikibot fails with SVN file formats before 12.Apr 6 2015, 5:42 AM

jayvdb added a parent task: T86655: Decommission svn.wikimedia.org server (import SVN into Phabricator).Apr 6 2015, 5:48 AM

Ricordisamoa subscribed.Apr 6 2015, 9:00 AM

jayvdb added a project: good first task.Apr 7 2015, 11:56 PM

jayvdb closed subtask T95077: pywikibot fails with SVN file formats before 12 as Resolved.Apr 20 2015, 1:35 PM

mgrabovsky subscribed.May 23 2015, 7:13 PM

mgrabovsky unsubscribed.

mgrabovsky subscribed.

jayvdb updated the task description. (Show Details)Jun 18 2015, 8:49 AM

jayvdb set Security to None.

jayvdb added a subscriber: Yurik.

mgrabovsky unsubscribed.Jun 18 2015, 9:54 AM

Change 218884 had a related patch set uploaded (by John Vandenberg):
Python issue #10254

https://gerrit.wikimedia.org/r/218884

gerritbot added a project: Patch-For-Review.Jul 21 2015, 1:14 AM

@jayvdb Since https://gerrit.wikimedia.org/r/#/c/218884/ has been merged, can we close this task or there is further work to do? Best regards.

Still one more to remove

$ git grep svn.wikimedia.org
pywikibot/version.py:                t[1] = t[1].replace('svn.wikimedia.org/svnroot/pywikipedia/',

Change 234807 had a related patch set uploaded (by MarcoAurelio):
Removing svn.wikimedia links in pywikibot

https://gerrit.wikimedia.org/r/234807

Patch is halted since it seems we can't SVN from Phabricator. Anyone knows a solution?

Change 201907 had a related patch set uploaded (by John Vandenberg):
[FEAT] version: Use svn info command

https://gerrit.wikimedia.org/r/201907

@MarcoAurelio , sorry I didnt reply to you. I assume that the SVN server people have been using is github; it is the only one I know about, as it is documented at https://www.mediawiki.org/wiki/Manual:Pywikibot/Installation/SVN .

The function with this old URL is probably currently broken, and has probably been broken since when Pywikibot was moved from SVN to git, which I think was around middle of 2013. IMO it can be deleted, but @XZise has a patch which will fix it, and @Xqt may have other ideas about this as he is the champion of SVN support.