U5. ConvertLqtPage only importing first topic and putting flow-workflow JSON in header
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	• Mattflaschen-WMF
	Apr 8 2015, 2:10 AM

Description

With the settings I plan to use in production, I'm having an issue with the conversion:

Before:

Command:

P489 Conversion script output

1	vagrant@mediawiki-vagrant:~$ mwscript extensions/Flow/maintenance/convertLqtPage.php --wiki=wiki --redirect --convertnotifications --verbose Wiki_talk:LQT_redirect_test_2015-04-07_retest
2	PHP Deprecated: Comments starting with '#' are deprecated in /etc/php5/cli/conf.d/20-xhprof.ini on line 2 in Unknown on line 0
3	[2015-04-08 01:59:16] Starting LQT import from Wiki_talk:LQT_redirect_test_2015-04-07_retest to Wiki_talk:LQT_redirect_test_2015-04-07_retest
4	[2015-04-08 01:59:16] Importing to Wiki talk:LQT redirect test 2015-04-07 retest
5	[2015-04-08 01:59:17] Importing header
6	[2015-04-08 01:59:19] Imported 2 revisions for header
7	[2015-04-08 01:59:19] Importing new topic
8	[2015-04-08 01:59:19] Finished importing topic title with 1 revisions
9	[2015-04-08 01:59:19] Importing post
10	[2015-04-08 01:59:20] Finished importing post with 1 revisions
11	[2015-04-08 01:59:23] Importing new topic
12	[2015-04-08 01:59:24] Finished importing topic title with 1 revisions
13	[2015-04-08 01:59:24] Importing post
14	[2015-04-08 01:59:24] Finished importing post with 1 revisions
15	[2015-04-08 01:59:24] Importing post
16	[2015-04-08 01:59:25] Finished importing post with 1 revisions
17	[2015-04-08 01:59:25] Importing post
18	[2015-04-08 01:59:26] Finished importing post with 1 revisions
19	[2015-04-08 01:59:32] Importing new topic
20	[2015-04-08 01:59:32] Finished importing topic title with 1 revisions
21	[2015-04-08 01:59:32] Importing post
22	[2015-04-08 01:59:33] Finished importing post with 1 revisions
23	[2015-04-08 01:59:33] Importing post
24	[2015-04-08 01:59:34] Finished importing post with 1 revisions
25	[2015-04-08 01:59:39] Imported 4 items, failed 0
26	Warning: Must specify directory location for XHProf runs. Trying /tmp as default. You can either pass the directory location as an argument to the constructor for XHProfRuns_Default() or set xhprof.output_dir ini param.

The output looks fine except for the XHProf output, which I don't think is the cause of the issue.

After:

Details

	Subject	Repo	Branch	Lines +/-
	LQT maintenance refactoring	mediawiki/extensions/Flow	wmf/1.26wmf2	+214 -149
	LQT maintenance refactoring	mediawiki/extensions/Flow	master	+214 -149

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• DannyH	T171977 Annual Plan 2017-2018, Audiences 5: Increase current editor retention and engagement
Resolved	• DannyH	T171982 Annual Plan 2017-2018, Audiences 5, Goal 3: Provide better workflow and communication experiences
Open	None	T167928 Improve structured discussion features for the communities that use them, based on user feedback and prioritising technical debt
Open	None	T89426 Allow to uninstall all LiquidThreads code except the parts necessary for the remaining content, to be moved into (?)WikimediaMessages
Resolved	Catrope	T106302 Convert LQT->Flow on se.wikimedia.org
Resolved	• Mattflaschen-WMF	T92303 Convert LQT pages on MediaWiki.org to Flow (tracking)
Resolved	• Mattflaschen-WMF	T95380 U5. ConvertLqtPage only importing first topic and putting flow-workflow JSON in header

Event Timeline

• Mattflaschen-WMF created this task.Apr 8 2015, 2:10 AM

• Mattflaschen-WMF raised the priority of this task from to High.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added projects: Collaboration-Team-Triage, Collaboration-Team-Sprint-T-2015-04-08, StructuredDiscussions.

• Mattflaschen-WMF added subscribers: Addshore, Shirish, greg and 7 others.

This happens without the redirect parameter too:

P490 (An Untitled Masterwork)

1	vagrant@mediawiki-vagrant:~$ mwscript extensions/Flow/maintenance/convertLqtPage.php --wiki=wiki --convertnotifications --verbose Wiki_talk:LQT_test_without_redirect_2015-04-07
2	PHP Deprecated: Comments starting with '#' are deprecated in /etc/php5/cli/conf.d/20-xhprof.ini on line 2 in Unknown on line 0
3	[2015-04-08 02:18:11] Starting LQT import from Wiki_talk:LQT_test_without_redirect_2015-04-07 to Wiki_talk:LQT_test_without_redirect_2015-04-07
4	[2015-04-08 02:18:11] Importing to Wiki talk:LQT test without redirect 2015-04-07
5	[2015-04-08 02:18:12] Importing header
6	[2015-04-08 02:18:14] Imported 2 revisions for header
7	[2015-04-08 02:18:14] Importing new topic
8	[2015-04-08 02:18:14] Finished importing topic title with 1 revisions
9	[2015-04-08 02:18:14] Importing post
10	[2015-04-08 02:18:15] Finished importing post with 1 revisions
11	[2015-04-08 02:18:15] Importing post
12	[2015-04-08 02:18:15] Finished importing post with 1 revisions
13	[2015-04-08 02:18:18] Importing new topic
14	[2015-04-08 02:18:18] Finished importing topic title with 1 revisions
15	[2015-04-08 02:18:18] Importing post
16	[2015-04-08 02:18:19] Finished importing post with 1 revisions
17	[2015-04-08 02:18:21] Imported 3 items, failed 0
18	Warning: Must specify directory location for XHProf runs. Trying /tmp as default. You can either pass the directory location as an argument to the constructor for XHProfRuns_Default() or set xhprof.output_dir ini param.

LQT_Local_Test_After_Conversion_Without_Redirect.png (583×1 px, 51 KB)

You can see there were two topics again.

In the output, there is again only one.

• DannyH set Security to None.Apr 8 2015, 5:52 PM

• DannyH edited a custom field.

• DannyH moved this task from Untriaged to Sprint U (temporary) on the Collaboration-Team-Triage board.Apr 8 2015, 9:58 PM

• DannyH added a project: Collaboration-Team-Sprint-U-2015-04-22.Apr 8 2015, 10:07 PM

• DannyH renamed this task from convertLqtPage only importing first topic and putting flow-workflow JSON in header to U5. ConvertLqtPage only importing first topic and putting flow-workflow JSON in header.Apr 8 2015, 10:25 PM

• DannyH moved this task from Sprint U - ends April 22 to In Development on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 8 2015, 11:23 PM

EBernhardson assigned this task to • Mattflaschen-WMF.Apr 9 2015, 12:57 AM

Change 202979 had a related patch set uploaded (by Mattflaschen):
WIP: LQT maintenance refactoring

https://gerrit.wikimedia.org/r/202979

gerritbot added a project: Patch-For-Review.Apr 10 2015, 6:14 AM

EBernhardson moved this task from In Development to Code Review Started on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 10 2015, 5:36 PM

• Mattflaschen-WMF moved this task from Sprint U (temporary) to Untriaged on the Collaboration-Team-Triage board.Apr 14 2015, 2:39 AM

This is basically due to a misunderstanding of how the script works, partly due to it really being two scripts in one.

We never intended to do a production conversion where source and target page were the same (there is always an archiving step, or previously when testing a local conversion, different source and target page names), but the script allowed that (but failed).

https://gerrit.wikimedia.org/r/#/c/202979/ makes this much more fool-proof.

Change 202979 merged by jenkins-bot:
LQT maintenance refactoring

https://gerrit.wikimedia.org/r/202979

Diffusion mentioned this in rMEXT023455c1b0d0: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 20 2015, 8:05 PM

• Mattflaschen-WMF mentioned this in rEFLW0dc8729b7415: LQT maintenance refactoring.Apr 20 2015, 8:05 PM

Change 205369 had a related patch set uploaded (by EBernhardson):
LQT maintenance refactoring

https://gerrit.wikimedia.org/r/205369

Change 205369 merged by jenkins-bot:
LQT maintenance refactoring

https://gerrit.wikimedia.org/r/205369

EBernhardson mentioned this in rEFLWd4765d76ee82: LQT maintenance refactoring.Apr 20 2015, 8:21 PM

EBernhardson moved this task from Code Review Started to Product Review on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 20 2015, 8:26 PM

• DannyH added a project: Collaboration-Team-Sprint-A-2015-05-06.Apr 22 2015, 7:11 PM

• DannyH moved this task from Sprint A - ends May 6 to Product Review on the Collaboration-Team-Sprint-A-2015-05-06 board.

• Mattflaschen-WMF moved this task from Product Review to Done on the Collaboration-Team-Sprint-A-2015-05-06 board.Apr 23 2015, 5:36 PM

• DannyH closed this task as Resolved.Apr 23 2015, 5:36 PM

• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Apr 23 2015, 8:50 PM

	F109882: LQT_Local_Test_After_Conversion_Without_Redirect.png
	Apr 8 2015, 2:22 AM

	F109877: LQT_Local_Test_After_Conversion.png
	Apr 8 2015, 2:10 AM

	F109875: LQT_Local_Test_Before_Conversion.png
	Apr 8 2015, 2:10 AM

U5. ConvertLqtPage only importing first topic and putting flow-workflow JSON in headerClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

U5. ConvertLqtPage only importing first topic and putting flow-workflow JSON in header
Closed, ResolvedPublic3 Estimated Story Points
Actions

Related Objects
Search...