Maniphest T97050

Empty delimiter in SkinMinerva
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	• demon
	Apr 23 2015, 5:10 PM

Tags

Referenced Files

None

Subscribers

View All 9 Subscribers

Description

Spotted in production:

45 Empty delimiter in /srv/mediawiki/php-1.26wmf2/extensions/MobileFrontend/includes/skins/SkinMinerva.php on line 1169

Details

	Subject	Repo	Branch	Lines +/-
	Don't pass empty message text to strpos	mediawiki/extensions/MobileFrontend	wmf/1.26wmf2	+7 -1
	Don't pass empty message text to strpos	mediawiki/extensions/MobileFrontend	wmf/1.26wmf3	+7 -1
	Don't pass empty message text to strpos	mediawiki/extensions/MobileFrontend	master	+7 -1

Customize query in gerrit

Related Objects

Mentioned In: rEMFRf27403a3016f: Don't pass empty message text to strpos
rEMFR1ab0377c2c06: Don't pass empty message text to strpos
rEMFR6b5a381dd4ac: Don't pass empty message text to strpos
rMEXT0f2788b2d843: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…

Event Timeline

• demon created this task.Apr 23 2015, 5:10 PM

• demon raised the priority of this task from to Needs Triage.

• demon updated the task description. (Show Details)

• demon added projects: MobileFrontend, Wikimedia-production-error.

• demon subscribed.

Restricted Application added a project: Web-Team-Backlog. · View Herald TranscriptApr 23 2015, 5:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Caused by I43cf5dc37f98cae30982945901a7cb6dbe618cab

Change 206148 had a related patch set uploaded (by Florianschmidtwelzow):
Don't pass empty message text to strpos

https://gerrit.wikimedia.org/r/206148

gerritbot added a project: Patch-For-Review.Apr 23 2015, 5:22 PM

Change 206148 merged by jenkins-bot:
Don't pass empty message text to strpos

https://gerrit.wikimedia.org/r/206148

Diffusion mentioned this in rMEXT0f2788b2d843: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Apr 23 2015, 6:26 PM

Florian mentioned this in rEMFR6b5a381dd4ac: Don't pass empty message text to strpos.Apr 23 2015, 6:27 PM

Jdlrobson closed this task as Resolved.Apr 23 2015, 8:13 PM

Jdlrobson merged a task: T96945: Empty delimiter warning being generated by SkinMinerva.php.

Jdlrobson added a subscriber: kaldari.

Jdlrobson subscribed.

@MaxSem, @kaldari, @phuedx Can we backport this to 1.26wmf2&wmf3? :)

Change 206193 had a related patch set uploaded (by Florianschmidtwelzow):
Don't pass empty message text to strpos

https://gerrit.wikimedia.org/r/206193

Change 206194 had a related patch set uploaded (by Florianschmidtwelzow):
Don't pass empty message text to strpos

https://gerrit.wikimedia.org/r/206194

Change 206193 merged by jenkins-bot:
Don't pass empty message text to strpos

https://gerrit.wikimedia.org/r/206193

Florian mentioned this in rEMFR1ab0377c2c06: Don't pass empty message text to strpos.Apr 23 2015, 11:07 PM

Change 206194 merged by jenkins-bot:
Don't pass empty message text to strpos

https://gerrit.wikimedia.org/r/206194

Florian mentioned this in rEMFRf27403a3016f: Don't pass empty message text to strpos.Apr 23 2015, 11:23 PM

Deployed to 1.26wmf2&wmf3 by @rmoen (thanks!) :)

Florian removed a project: Patch-For-Review.Apr 24 2015, 6:08 AM

Florian set Security to None.

• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jun 12 2015, 6:34 PM

• demon triaged this task as Medium priority.Jul 9 2015, 4:40 PM

• Phabricator_maintenance moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:36 AM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM