Page MenuHomePhabricator
Create Task
Maniphest T97469

FormatMetadata::fetchExtendedMetadata() returns invalid metadata keys
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Tons of errors being logged like this:

2015-04-28 20:31:11 mw1233 commonswiki exception INFO: [820de11b] /w/api.php?titles=File%3AFlag_of_the_Dominican_Republic.svg&iiprop=timestamp%7Cuser%7Ccomment%7Curl%7Csize%7Csha1%7Cmetadata%7Cmime%7Cmediatype%7Cextmetadata&prop=imageinfo&iimetadataversion=2&iiextmetadatamultilang=1&format=json&action=query&redirects=true&uselang=ko   UnexpectedValueException from line 957 of /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php: Unknown type 'lang'
#0 /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php(860): ApiResult::applyTransformations()
#1 /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php(860): ApiResult::applyTransformations()
#2 /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php(860): ApiResult::applyTransformations()
#3 /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php(860): ApiResult::applyTransformations()
#4 /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php(860): ApiResult::applyTransformations()
#5 /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php(860): ApiResult::applyTransformations()
#6 /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php(860): ApiResult::applyTransformations()
#7 /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php(860): ApiResult::applyTransformations()
#8 /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php(244): ApiResult::applyTransformations()
#9 /srv/mediawiki/php-1.26wmf3/includes/api/ApiFormatJson.php(97): ApiResult->getResultData()
#10 /srv/mediawiki/php-1.26wmf3/includes/api/ApiMain.php(1250): ApiFormatJson->execute()
#11 /srv/mediawiki/php-1.26wmf3/includes/api/ApiMain.php(1108): ApiMain->printResult()
#12 /srv/mediawiki/php-1.26wmf3/includes/api/ApiMain.php(436): ApiMain->executeAction()
#13 /srv/mediawiki/php-1.26wmf3/includes/api/ApiMain.php(409): ApiMain->executeActionWithErrorHandling()
#14 /srv/mediawiki/php-1.26wmf3/api.php(90): ApiMain->execute()
#15 /srv/mediawiki/w/api.php(3): include()
#16 {main} {"private":false}

Details

SubjectRepoBranchLines +/-
Hook 'ValidateExtendedMetadataCache' for T97469operations/mediawiki-configmaster+5 -0
Protect API metadata keys from FormatMetadata::fetchExtendedMetadata()mediawiki/coreREL1_25+12 -9
Protect API metadata keys from FormatMetadata::fetchExtendedMetadata()mediawiki/coremaster+12 -9
Protect API metadata keys from FormatMetadata::fetchExtendedMetadata()mediawiki/corewmf/1.26wmf3+12 -9
Customize query in gerrit

Related Objects

Event Timeline

Anomie created this task.Apr 28 2015, 8:31 PM
Anomie claimed this task.
Anomie raised the priority of this task from to Unbreak Now!.
Anomie updated the task description. (Show Details)
Anomie added projects: Reading-Infrastructure-Team-Old (Don't use), MediaWiki-File-management.
Anomie moved this task to Needs Review/Feedback on the Reading-Infrastructure-Team-Old (Don't use) board.
Anomie subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptApr 28 2015, 8:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Apr 28 2015, 8:34 PM

Change 207272 had a related patch set uploaded (by Anomie):
Protect API metadata keys from FormatMetadata::fetchExtendedMetadata()

https://gerrit.wikimedia.org/r/207272

gerritbot added a project: Patch-For-Review.Apr 28 2015, 8:34 PM
Anomie added a project: Wikimedia-production-error.Apr 28 2015, 8:34 PM
Anomie set Security to None.
Anomie added a project: MW-1.25-release.Apr 28 2015, 8:37 PM
Anomie mentioned this in T96570: Backport API format changes and follow-ups to REL1_25 branch.
Ireas subscribed.Apr 28 2015, 8:46 PM
gerritbot added a comment.Apr 28 2015, 8:48 PM

Change 207274 had a related patch set uploaded (by Anomie):
Protect API metadata keys from FormatMetadata::fetchExtendedMetadata()

https://gerrit.wikimedia.org/r/207274

gerritbot added a comment.Apr 28 2015, 8:55 PM

Change 207272 merged by jenkins-bot:
Protect API metadata keys from FormatMetadata::fetchExtendedMetadata()

https://gerrit.wikimedia.org/r/207272

Anomie mentioned this in rMWcd56c087a4fd: Protect API metadata keys from FormatMetadata::fetchExtendedMetadata().Apr 28 2015, 8:55 PM
gerritbot added a comment.Apr 28 2015, 8:55 PM

Change 207275 had a related patch set uploaded (by Legoktm):
Protect API metadata keys from FormatMetadata::fetchExtendedMetadata()

https://gerrit.wikimedia.org/r/207275

gerritbot added a comment.Apr 28 2015, 8:57 PM

Change 207274 merged by jenkins-bot:
Protect API metadata keys from FormatMetadata::fetchExtendedMetadata()

https://gerrit.wikimedia.org/r/207274

Anomie mentioned this in rMWea140cd01553: Protect API metadata keys from FormatMetadata::fetchExtendedMetadata().Apr 28 2015, 8:57 PM
Anomie added a comment.Apr 28 2015, 9:11 PM

Code is fixed now, but there are probably still broken memc entries (prefix "commonswiki:getExtendedMetadata:") with expiry up to 30 days.

gerritbot added a comment.Apr 28 2015, 9:20 PM

Change 207279 had a related patch set uploaded (by Anomie):
Hook 'ValidateExtendedMetadataCache' for T97469

https://gerrit.wikimedia.org/r/207279

gerritbot added a comment.Apr 28 2015, 9:30 PM

Change 207275 merged by jenkins-bot:
Protect API metadata keys from FormatMetadata::fetchExtendedMetadata()

https://gerrit.wikimedia.org/r/207275

gerritbot added a comment.Apr 28 2015, 9:30 PM

Change 207279 merged by jenkins-bot:
Hook 'ValidateExtendedMetadataCache' for T97469

https://gerrit.wikimedia.org/r/207279

Legoktm mentioned this in rMWc27ec2abbef2: Protect API metadata keys from FormatMetadata::fetchExtendedMetadata().Apr 28 2015, 9:31 PM
Anomie mentioned this in rOMWCdd92e7b0b8ab: Hook 'ValidateExtendedMetadataCache' for T97469.Apr 28 2015, 9:31 PM
Anomie closed this task as Resolved.Apr 28 2015, 9:33 PM

All fixed now.

Anomie moved this task from Needs Review/Feedback to Done on the Reading-Infrastructure-Team-Old (Don't use) board.Apr 29 2015, 6:57 PM
Anomie mentioned this in T97591: UnexpectedValueException from line 957 of /srv/mediawiki/php-1.26wmf3/includes/api/ApiResult.php: Unknown type 'lang'.Apr 30 2015, 12:45 PM
gerritbot added a comment.Apr 30 2015, 1:25 PM

Change 207769 had a related patch set uploaded (by Anomie):
Bump timestamp in 'ValidateExtendedMetadataCache' hook for T97469

https://gerrit.wikimedia.org/r/207769

gerritbot added a comment.Apr 30 2015, 3:02 PM

Change 207769 merged by jenkins-bot:
Bump timestamp in 'ValidateExtendedMetadataCache' hook for T97469

https://gerrit.wikimedia.org/r/207769

Anomie mentioned this in rOMWC5055b4721261: Bump timestamp in 'ValidateExtendedMetadataCache' hook for T97469.Apr 30 2015, 3:03 PM
Anomie mentioned this in rOMWCf33fe993b442: Remove obsolete 'ValidateExtendedMetadataCache' hook.Jun 4 2015, 3:36 PM
• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jun 12 2015, 6:34 PM
• Fjalapeno edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Reading-Infrastructure-Team-Old (Don't use).Jun 7 2017, 2:58 PM
Restricted Application added a project: Commons. · View Herald TranscriptJun 7 2017, 2:58 PM
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald Transcript
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL