Page MenuHomePhabricator

Flow warning message "Topic titles are restricted to 260 bytes" refers to character count
Open, MediumPublic

Description

The warning msg "Topic titles are restricted to 260 bytes" seems to be misleading - it refers, in fact, to character count which is the same for Basic Latin.

Screen_Shot_2015-04-28_at_5.25.32_PM.png (228×967 px, 48 KB)

For other languages (http://stackoverflow.com/questions/14485589/utf-8-how-many-bytes-are-used-by-languages-to-represent-a-visible-character)

up to U+07FF it takes 2 bytes: Greek, Arabic, Cyrillic, Hebrew, etc
up to U+FFFF it takes 3 bytes: Chinese, Japanese, Korean, Devanagari, etc
Beyond that it takes 4 bytes

Checked with Russian and Hebrew - the '260 bytes' warning will refer to characters.

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova subscribed.
DannyH triaged this task as Medium priority.Apr 29 2015, 6:03 PM
DannyH subscribed.

Good catch -- we'll fix this.

DannyH renamed this task from Warning message "Topic titles are restricted to 260 bytes" refers to character count to Flow warning message "Topic titles are restricted to 260 bytes" refers to character count.Apr 29 2015, 6:04 PM
DannyH moved this task from Untriaged to Team discussion on the Collaboration-Team-Triage board.
DannyH set Security to None.

Hmm, I don't see why topic titles are limited to 260 bytes/characters? There doesn't seem to be a reason for this on the backend AFAICT, because flow_workflow.workflow_name doesn't appear to contain topic titles (or anything ever, for that matter) and the only place I can see the topic title going is flow_revision.rev_content which is a mediumblob. Is there a requirement that topic titles be valid page titles, maybe?

No, topic titles are not page titles (the page titles are UUID's, e.g. Topic:Sg9x5a5xhkit3g00).

@EBernhardson, @matthiasmullie, @DannyH, do you know the reason for this?

flow_workflow.workflow_name needs to be dropped, its is a vestige of a canceled idea. As for the topic titles its always been intended that they become the page names in the Topic namespace, we just havn't been able to fit that work into a sprint since production enabled $wgContentHandlerUseDB making it possible. I don't think that precludes topic titles being longer, they would just get truncated.

Based on the bug (T59453) that prompted the limit, it looks like 260 was arbitrarily chosen as something beyond which the interface starts to look very funny and wrong.

flow_workflow.workflow_name needs to be dropped, its is a vestige of a canceled idea. As for the topic titles its always been intended that they become the page names in the Topic namespace, we just havn't been able to fit that work into a sprint since production enabled $wgContentHandlerUseDB making it possible. I don't think that precludes topic titles being longer, they would just get truncated.

Based on the bug (T59453) that prompted the limit, it looks like 260 was arbitrarily chosen as something beyond which the interface starts to look very funny and wrong.

OK, that makes sense. Note however that IIRC the title length limit is 255, so 260 is already too high if that's where we're headed.

flow_workflow.workflow_name needs to be dropped, its is a vestige of a canceled idea.

Filed as T97607: Drop workflow_name.

Restricted Application added a subscriber: revi. · View Herald Transcript