Currently there exists ByPropertyIdArray in DataModel which does the indexing and is quite complicated as well as almost not maintainable. It also has several other issues, so getting rid of this class is one of the goals of this task.
Furthermore, it will be easier in the ui and api to have an index for each property id and then indices within each per-property group.
Note: Properties should be sorted by their rank automatically, which makes the whole thing a bit more complicated.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [DNM] Use ByPropertyIdMap in ChangeOpClaim | mediawiki/extensions/Wikibase | master | +62 -94 |
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Resolved | thiemowmde | T99243 [Story] consistent order of statements in an item | ||
| Invalid | Bene | T98375 [Task] ChangeOpClaim should handle indices per property id | ||
| · · · |
I have created a proposal on Github for the underlying datastructure needed for this change. See https://github.com/wmde/WikibaseDataModel/pull/479 and https://github.com/wmde/WikibaseDataModel/pull/480
This requires a change in the api module: the index parameter of wbsetclaim does no longer move the property group when it does not fit. Furthermore this parameter is now relative to the beginning of the property group. A new parameter called groupindex must be added as well to allow moving whole groups.
This requires only small refactoring in the UI/Javascript code because moving of statements is currently disabled and not implemented. With this changes it should be easier to add this feature again in the UI.
Change 209451 had a related patch set uploaded (by Bene):
[DNM] Use ByPropertyIdMap in ChangeOpClaim
Change 209451 abandoned by Bene:
[DNM] Use ByPropertyIdMap in ChangeOpClaim
Reason:
Will not be done this way