Page MenuHomePhabricator
Create Task
Maniphest T133853

[Task] Replace remaining StatementListHolder (setStatements) usages
Closed, ResolvedPublic
Actions

Description

Two usages are left:

Patches for review:

Details

SubjectRepoBranchLines +/-
Move ChangeOpStatement away from requiring a StatementListHoldermediawiki/extensions/Wikibasemaster+22 -23
Make EntityChangeFactory optionally use StatementListProvidermediawiki/extensions/Wikibasemaster+7 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 ResolvedthiemowmdeT133853 [Task] Replace remaining StatementListHolder (setStatements) usages
 ResolvedthiemowmdeT134884 [Task] Make ChangeOpStatement fail when the index feature is used on entities without setStatements
 ResolvedthiemowmdeT134882 [Task] Track usage of the index feature in SetClaim API
 ResolvedthiemowmdeT134883 [Task] Find out if the Wikibase UI uses the index feature of the SetClaims API
 ResolvedthiemowmdeT134887 [Task] Remove unused "set claim at index" feature

Event Timeline

thiemowmde created this task.Apr 28 2016, 9:02 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptApr 28 2016, 9:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Apr 28 2016, 9:07 AM

Change 285911 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Move ChangeOpStatement away from requiring a StatementListHolder

https://gerrit.wikimedia.org/r/285911

gerritbot added a project: Patch-For-Review.Apr 28 2016, 9:07 AM
gerritbot added a comment.Apr 28 2016, 9:14 AM

Change 285912 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make EntityChangeFactory optionally use StatementListProvider

https://gerrit.wikimedia.org/r/285912

• adrianheine moved this task from Proposed to Review on the Wikidata-Sprint-2016-04-26 board.Apr 28 2016, 10:02 AM
gerritbot added a comment.Apr 28 2016, 11:56 AM

Change 285912 merged by jenkins-bot:
Make EntityChangeFactory optionally use StatementListProvider

https://gerrit.wikimedia.org/r/285912

thiemowmde renamed this task from [Task] StatementListHolder to [Task] Replace remaining StatementListHolder (setStatements) usages.Apr 28 2016, 2:46 PM
thiemowmde updated the task description. (Show Details)
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.May 3 2016, 10:03 AM
gerritbot added a comment.May 9 2016, 10:40 AM

Change 285911 merged by jenkins-bot:
Move ChangeOpStatement away from requiring a StatementListHolder

https://gerrit.wikimedia.org/r/285911

• Jonas updated the task description. (Show Details)May 9 2016, 10:42 AM
• Jonas updated the task description. (Show Details)
• Jonas updated the task description. (Show Details)
• adrianheine moved this task from Review to Backlog on the Wikidata-Sprint-2016-04-26 board.May 9 2016, 10:42 AM
• Jonas closed this task as Resolved.May 9 2016, 10:43 AM
• Jonas moved this task from Backlog to Done on the Wikidata-Sprint-2016-04-26 board.
• adrianheine reopened this task as Open.May 9 2016, 10:44 AM
• adrianheine moved this task from Done to Backlog on the Wikidata-Sprint-2016-04-26 board.
• adrianheine removed a project: Patch-For-Review.

Far from done.

Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-05-10.May 10 2016, 11:53 AM
Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-05-10 board.May 10 2016, 11:54 AM
thiemowmde added a comment.EditedMay 10 2016, 1:38 PM

Possible ways forward, as discussed today:

  1. T134882: Track how often the index feature is used. The critical line of code is in ChangeOpStatement. The only caller is the SetClaim API module. Track two numbers: Total calls of SetClaim and how often a non-null index is provided.
  2. T134883: We need to check if our own UI uses the index feature.
  3. T134884: We can make ChangeOpStatement throw an exception when a user tries to specify an index on an entity type that does not implement StatementListHolder. Personally I like this very much and would love to work on a patch that does this.
  4. We could make MedieInfo implement StatementListHolder. But we want to avoid that. It will make the situation worse.
  5. We could release Wikibase-DataModel with https://github.com/wmde/WikibaseDataModel/pull/664, which added the possibility to move a statement to a specific position. Then implement a replacement for ByPropertyIdArray (or move it from Wikibase-DataModel-Services to MediaWiki-extensions-WikibaseRepository). This replacement will not require StatementListHolder any more.

So personally, I suggest to pick 1, 2 and 3 for the sprint.

thiemowmde created subtask T134882: [Task] Track usage of the index feature in SetClaim API.May 10 2016, 1:57 PM
thiemowmde created subtask T134883: [Task] Find out if the Wikibase UI uses the index feature of the SetClaims API.May 10 2016, 2:00 PM
thiemowmde created subtask T134884: [Task] Make ChangeOpStatement fail when the index feature is used on entities without setStatements.
thiemowmde closed subtask T134883: [Task] Find out if the Wikibase UI uses the index feature of the SetClaims API as Resolved.May 10 2016, 2:21 PM
thiemowmde created subtask T134887: [Task] Remove unused "set claim at index" feature.May 10 2016, 2:30 PM
thiemowmde added a project: Tracking-Neverending.May 11 2016, 12:55 PM
• adrianheine closed subtask T134887: [Task] Remove unused "set claim at index" feature as Resolved.May 17 2016, 6:16 PM
thiemowmde closed subtask T134884: [Task] Make ChangeOpStatement fail when the index feature is used on entities without setStatements as Resolved.May 24 2016, 9:54 AM
thiemowmde closed this task as Resolved.May 24 2016, 1:00 PM
thiemowmde moved this task from Backlog to Done on the Wikidata-Sprint-2016-04-26 board.
thiemowmde moved this task from Done to Backlog on the Wikidata-Sprint-2016-04-26 board.
thiemowmde moved this task from Backlog to Done on the Wikidata-Sprint-2016-05-10 board.
Danny_B moved this task from Tag to Should be Goal instead on the Tracking-Neverending board.Jul 11 2016, 6:34 PM
thiemowmde closed subtask T134882: [Task] Track usage of the index feature in SetClaim API as Resolved.Jul 20 2016, 11:52 AM
• Phabricator_maintenance added a project: Goal.Aug 13 2016, 8:41 PM
• Phabricator_maintenance removed a project: Tracking-Neverending.Aug 13 2016, 9:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits