Page MenuHomePhabricator
Create Task
Maniphest T134884

[Task] Make ChangeOpStatement fail when the index feature is used on entities without setStatements
Closed, ResolvedPublic
Actions

Description

We can make ChangeOpStatement throw an exception when a user tries to specify an index on an entity type that does not implement StatementListHolder.

Details

SubjectRepoBranchLines +/-
Make ChangeOpStatement work with StatementListProvider w/o index parammediawiki/extensions/Wikibasemaster+181 -65
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 ResolvedthiemowmdeT133853 [Task] Replace remaining StatementListHolder (setStatements) usages
 ResolvedthiemowmdeT134884 [Task] Make ChangeOpStatement fail when the index feature is used on entities without setStatements
 ResolvedthiemowmdeT134882 [Task] Track usage of the index feature in SetClaim API
 ResolvedthiemowmdeT134883 [Task] Find out if the Wikibase UI uses the index feature of the SetClaims API

Event Timeline

thiemowmde created this task.May 10 2016, 2:02 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 10 2016, 2:02 PM
thiemowmde added subtasks: T134883: [Task] Find out if the Wikibase UI uses the index feature of the SetClaims API, T134882: [Task] Track usage of the index feature in SetClaim API.May 10 2016, 2:02 PM
thiemowmde mentioned this in T133853: [Task] Replace remaining StatementListHolder (setStatements) usages.
thiemowmde moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-05-10 board.May 10 2016, 2:04 PM
thiemowmde closed subtask T134883: [Task] Find out if the Wikibase UI uses the index feature of the SetClaims API as Resolved.May 10 2016, 2:21 PM
gerritbot subscribed.May 11 2016, 12:41 PM

Change 288183 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make ChangeOpStatement work with StatementListProvider w/o index param

https://gerrit.wikimedia.org/r/288183

gerritbot added a project: Patch-For-Review.May 11 2016, 12:41 PM
thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2016-05-10 board.May 11 2016, 12:54 PM
• Jonas moved this task from Review to Doing on the Wikidata-Sprint-2016-05-10 board.May 18 2016, 11:49 AM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.May 19 2016, 12:30 PM
gerritbot added a comment.May 23 2016, 9:58 PM

Change 288183 merged by jenkins-bot:
Make ChangeOpStatement work with StatementListProvider w/o index param

https://gerrit.wikimedia.org/r/288183

thiemowmde closed this task as Resolved.May 24 2016, 9:54 AM
thiemowmde moved this task from Doing to Done on the Wikidata-Sprint-2016-05-10 board.
thiemowmde closed subtask T134882: [Task] Track usage of the index feature in SetClaim API as Resolved.Jul 20 2016, 11:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL