[Task] Remove unused "set claim at index" feature
Closed, ResolvedPublic
Actions

Description

Code like …

StatementChangeOpFactory.php
ClaimsChanger.js

… does have optional index parameters, but they are never used, at least not in the Wikibase code base.

The parameter should not be removed from RepoApi.js because this may be used from user scripts and gadgets.

Details

	Subject	Repo	Branch	Lines +/-
	Remove unused index feature from ClaimsChanger.js	mediawiki/extensions/Wikibase	master	+13 -26
	Remove unused StatementChangeOpFactory::newAddStatementOp	mediawiki/extensions/Wikibase	master	+1 -27

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Duplicate		None	T66288 basic support for structured data on mediawiki files
Invalid		Lydia_Pintscher	T76012 make use of new entity type for multimedia / structured data of media files
Open		None	T109579 [Epic] Give more sister projects access to Wikidata
Open		None	T187900 There is no way to reference a specific quote on Wikiquote
Stalled		None	T71753 [Story] Wikibase / Wikidata support on Wikiquote
Open		None	T67626 [Epic] Support for queries on-wiki (automated list generation)
Resolved		Addshore	T76019 [Story] Support new types of Entities in Wikibase Client
Resolved		thiemowmde	T135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
Resolved		Addshore	T75496 [Epic] Support new types of Entities in Wikibase Repository
Resolved		thiemowmde	T133853 [Task] Replace remaining StatementListHolder (setStatements) usages
Resolved		thiemowmde	T134887 [Task] Remove unused "set claim at index" feature

Event Timeline

thiemowmde created this task.May 10 2016, 2:30 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 10 2016, 2:30 PM

Change 287960 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused index feature from StatementChangeOpFactory

https://gerrit.wikimedia.org/r/287960

gerritbot added a project: Patch-For-Review.May 10 2016, 2:30 PM

Change 287961 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused index feature from ClaimsChanger.js

https://gerrit.wikimedia.org/r/287961

thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-05-10 board.May 10 2016, 2:33 PM

Change 287960 merged by jenkins-bot:
Remove unused StatementChangeOpFactory::newAddStatementOp

https://gerrit.wikimedia.org/r/287960

thiemowmde mentioned this in P3118 setClaim mwgrep.May 17 2016, 2:06 PM

Change 287961 merged by jenkins-bot:
Remove unused index feature from ClaimsChanger.js

https://gerrit.wikimedia.org/r/287961

adrianheine closed this task as Resolved.May 17 2016, 6:16 PM

adrianheine moved this task from Review to Done on the Wikidata-Sprint-2016-05-10 board.

[Task] Remove unused "set claim at index" featureClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

[Task] Remove unused "set claim at index" feature
Closed, ResolvedPublic
Actions

Related Objects
Search...