Page MenuHomePhabricator

[Task] Remove unused "set claim at index" feature
Closed, ResolvedPublic

Description

Code like …

  • StatementChangeOpFactory.php
  • ClaimsChanger.js

… does have optional index parameters, but they are never used, at least not in the Wikibase code base.

The parameter should not be removed from RepoApi.js because this may be used from user scripts and gadgets.

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenFeatureNone
DuplicateNone
ResolvedNone
ResolvedNone
ResolvedNone
DuplicateNone
InvalidLydia_Pintscher
OpenNone
OpenNone
StalledNone
OpenNone
ResolvedAddshore
Resolvedthiemowmde
ResolvedAddshore
Resolvedthiemowmde
Resolvedthiemowmde

Event Timeline

Change 287960 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused index feature from StatementChangeOpFactory

https://gerrit.wikimedia.org/r/287960

Change 287961 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused index feature from ClaimsChanger.js

https://gerrit.wikimedia.org/r/287961

Change 287960 merged by jenkins-bot:
Remove unused StatementChangeOpFactory::newAddStatementOp

https://gerrit.wikimedia.org/r/287960

Change 287961 merged by jenkins-bot:
Remove unused index feature from ClaimsChanger.js

https://gerrit.wikimedia.org/r/287961