Page MenuHomePhabricator
Create Task
Maniphest T134887

[Task] Remove unused "set claim at index" feature
Closed, ResolvedPublic
Actions

Description

Code like …

  • StatementChangeOpFactory.php
  • ClaimsChanger.js

… does have optional index parameters, but they are never used, at least not in the Wikibase code base.

The parameter should not be removed from RepoApi.js because this may be used from user scripts and gadgets.

Details

SubjectRepoBranchLines +/-
Remove unused index feature from ClaimsChanger.jsmediawiki/extensions/Wikibasemaster+13 -26
Remove unused StatementChangeOpFactory::newAddStatementOpmediawiki/extensions/Wikibasemaster+1 -27
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 ResolvedthiemowmdeT133853 [Task] Replace remaining StatementListHolder (setStatements) usages
 ResolvedthiemowmdeT134887 [Task] Remove unused "set claim at index" feature

Event Timeline

thiemowmde created this task.May 10 2016, 2:30 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 10 2016, 2:30 PM
gerritbot subscribed.May 10 2016, 2:30 PM

Change 287960 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused index feature from StatementChangeOpFactory

https://gerrit.wikimedia.org/r/287960

gerritbot added a project: Patch-For-Review.May 10 2016, 2:30 PM
gerritbot added a comment.May 10 2016, 2:33 PM

Change 287961 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused index feature from ClaimsChanger.js

https://gerrit.wikimedia.org/r/287961

thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-05-10 board.May 10 2016, 2:33 PM
gerritbot added a comment.May 17 2016, 8:17 AM

Change 287960 merged by jenkins-bot:
Remove unused StatementChangeOpFactory::newAddStatementOp

https://gerrit.wikimedia.org/r/287960

thiemowmde mentioned this in P3118 setClaim mwgrep.May 17 2016, 2:06 PM
gerritbot added a comment.May 17 2016, 5:19 PM

Change 287961 merged by jenkins-bot:
Remove unused index feature from ClaimsChanger.js

https://gerrit.wikimedia.org/r/287961

• adrianheine closed this task as Resolved.May 17 2016, 6:16 PM
• adrianheine moved this task from Review to Done on the Wikidata-Sprint-2016-05-10 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits