Maniphest T98903

Correctly handle mSubmitModifierClass in OOUIHTMLForm
Closed, ResolvedPublic
Actions

Assigned To

Jdforrester-WMF

Authored By

	matmarex
	May 12 2015, 7:28 PM

Tags

Referenced Files

None

Subscribers

Description

Correctly handle mSubmitModifierClass in OOUIHTMLForm. The mSubmitModifierClass field contains a MediaWiki UI class name, which does not work with OOUI. We need to parse it (or change the setters for it) and set the progressive/constructive/destructive flag instead.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+7 -11	OOUIHTMLForm: Correctly handle submit modifier flags

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		matmarex	T100279 Make OOUI display format in MediaWiki's HTMLForm production-ready
		Resolved		Jdforrester-WMF	T98903 Correctly handle mSubmitModifierClass in OOUIHTMLForm
		Resolved		MarkTraceur	T85291 Implement OOUI "display format" in MediaWiki's HTMLForm
		Resolved		matmarex	T97871 PHP TextInputWidget has no 'required' config
		Resolved		matmarex	T91132 Forcefully preventing default event actions on FormLayout, ButtonWidget and ButtonInputWidget is problematic
		Resolved		matmarex	T85285 Disentangle VForms from HTMLForm code in core

Event Timeline

matmarex created this task.May 12 2015, 7:28 PM

matmarex raised the priority of this task from to Needs Triage.

matmarex updated the task description. (Show Details)

matmarex added projects: MediaWiki-HTMLForm, UI-Standardization.

matmarex added a subscriber: matmarex.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2015, 7:28 PM

matmarex added a subtask: T85291: Implement OOUI "display format" in MediaWiki's HTMLForm.May 12 2015, 7:28 PM

Jdforrester-WMF closed subtask T85291: Implement OOUI "display format" in MediaWiki's HTMLForm as Resolved.May 24 2015, 12:24 PM

Prtksxna removed a project: UI-Standardization.May 24 2015, 12:50 PM

Prtksxna set Security to None.

Jdforrester-WMF added a parent task: T100279: Make OOUI display format in MediaWiki's HTMLForm production-ready.May 25 2015, 11:54 AM

Jdforrester-WMF triaged this task as Medium priority.Jun 4 2015, 12:10 AM

Change 218149 had a related patch set uploaded (by Bartosz Dziewoński):
OOUIHTMLForm: Correctly handle mSubmitModifierClass

https://gerrit.wikimedia.org/r/218149

gerritbot added a project: Patch-For-Review.Jun 14 2015, 6:29 PM

Tgr mentioned this in T103046: Progressive buttons broken in OOUIHTMLForm.Jun 19 2015, 2:26 AM

Change 218149 merged by jenkins-bot:
OOUIHTMLForm: Correctly handle submit modifier flags

https://gerrit.wikimedia.org/r/218149

matmarex mentioned this in rMW552568c63d93: OOUIHTMLForm: Correctly handle submit modifier flags.Jun 27 2015, 6:43 PM

Jdforrester-WMF closed this task as Resolved.Jun 27 2015, 6:53 PM

Jdforrester-WMF claimed this task.

• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-06-30_(1.26wmf12).Jun 27 2015, 7:00 PM