Page MenuHomePhabricator
Feed Advanced Search

Jun 15 2021

cscott committed rMLDOd1d5f921a398: Further implementation of Range/StaticRange/AbstractRange.
Further implementation of Range/StaticRange/AbstractRange
Jun 15 2021, 5:57 AM
cscott committed rMLDO86542fd50b44: Fix regression in DodoTest.php.
Fix regression in DodoTest.php
Jun 15 2021, 5:57 AM
cscott committed rMLID87245ae71d36: Release 0.6.0.
Release 0.6.0
Jun 15 2021, 3:18 AM
cscott committed rMLID6ab35b0a95d7: Bump CHANGELOG after release.
Bump CHANGELOG after release
Jun 15 2021, 3:18 AM
cscott committed rMLID9411e3d9dab1: Change PHP type of dictionaries from interface to abstract class.
Change PHP type of dictionaries from interface to abstract class
Jun 15 2021, 3:16 AM
cscott committed rMLIDacb85299609f: Rename TraitBuilder to HelperBuilder.
Rename TraitBuilder to HelperBuilder
Jun 15 2021, 3:16 AM

Jun 14 2021

cscott committed rMLIDeda0162b790b: Add {Global,DocumentAndElement,Window}EventHandlers (authored by Tim.abdullin).
Add {Global,DocumentAndElement,Window}EventHandlers
Jun 14 2021, 8:54 PM
cscott committed rMLID1808ab31570d: Change PHP type of enumerations from int to string.
Change PHP type of enumerations from int to string
Jun 14 2021, 8:54 PM

Jun 11 2021

cscott added a comment to T269262: Integrate the DOM library with RemexHtml.

Still to-do:

  • implement getters and setters for innerHTML and outerHTML using Remex.
  • implement DOM Parsing & serialization interfaces from IDLeDOM 0.5.0
  • implement PHP-specific Document::{load,loadXML,saveHTML,saveXML} methods (also defined in IDLeDOM 0.5.0)
Jun 11 2021, 9:15 PM · Parsoid (Dodo)
cscott closed T269707: Integrate the DOM library with Zest, a subtask of T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library), as Resolved.
Jun 11 2021, 9:12 PM · Parsoid (Dodo)
cscott closed T269707: Integrate the DOM library with Zest as Resolved.

Implemented in 2621a6a930c813f863ff304142be85c725f7b617 and related patches, although there may be bugs & performance work remaining (which will be opened as separate tasks).

Jun 11 2021, 9:12 PM · Parsoid (Dodo)
cscott closed T269270: Code generation of HTML*Element DOM classes, a subtask of T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library), as Resolved.
Jun 11 2021, 9:10 PM · Parsoid (Dodo)
cscott closed T269270: Code generation of HTML*Element DOM classes as Resolved.

Implemented in c3b9eb120e8a18b7f0da25e7235bc4ef87bb726a (and a number of preceding patches to IDLeDOM etc).

Jun 11 2021, 9:10 PM · Parsoid (Dodo)

Jun 8 2021

cscott added a comment to T284570: Parsoid does not always compute the proper image thumb URL.

In theory we should have invalidated our cache when the image was updated. So that's probably still a Parsoid-core integration bug we need to track down and fix, probably. Or else it will magically Just Work when we move from RestBASE to ParserCache.

Jun 8 2021, 3:54 PM · affects-Kiwix-and-openZIM, Parsoid-Rendering
cscott added a comment to T284570: Parsoid does not always compute the proper image thumb URL.

Further, it looks like this works on the command line:

$ php bin/parse.php --domain en.wikipedia.org --pageName Wikipedia:Wikipedia_for_Schools/Welcome/Mathematics --normalize=parsoid < /dev/null | fgrep versicolor
<div class="thumb"><span typeof="mw:Image"><a href="./File:Fisher_iris_versicolor_sepalwidth.png"><img resource="./File:Fisher_iris_versicolor_sepalwidth.png" src="//upload.wikimedia.org/wikipedia/commons/thumb/1/1d/Fisher_iris_versicolor_sepalwidth.png/270px-Fisher_iris_versicolor_sepalwidth.png" data-file-width="957" data-file-height="638" data-file-type="bitmap" height="120" width="180" srcset="//upload.wikimedia.org/wikipedia/commons/thumb/1/1d/Fisher_iris_versicolor_sepalwidth.png/405px-Fisher_iris_versicolor_sepalwidth.png 1.5x, //upload.wikimedia.org/wikipedia/commons/thumb/1/1d/Fisher_iris_versicolor_sepalwidth.png/540px-Fisher_iris_versicolor_sepalwidth.png 2x"/></a></span></div>

So this might be a misconfiguration (somehow) in how the rest_v1 endpoint is set up?

Jun 8 2021, 3:41 PM · affects-Kiwix-and-openZIM, Parsoid-Rendering
cscott added a comment to T284402: Don't show toolbar in LanguageVariantInspector text targets.

Discussed in meeting today. This makes sense. *Ideally* there would be a way to pop up the toolbar (a small "expand" icon or something like that?) for those cases where there is rich text present, but as @dchan points out, best practice is really *not* to include rich text here. My recollection is that the common case that shows up in rules ends up being either simple boldface or italics markup (which really belongs outside the -{ ... }- markup but sometimes ends up inside) or else <span> tags -- in the latter case the intended usage is something like a gloss "xyz in traditional (pdq in simplified characters)" where the <span> is used to format the gloss. But most cases this will be done with a template anyway.

Jun 8 2021, 3:36 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor
cscott updated subscribers of T284570: Parsoid does not always compute the proper image thumb URL.

This is the instantcommons fallback, since the image is not present on enwiki it should be grabbed from commons. I was pretty certain that instantcommons works in Parsoid, I wonder what's going on. @Arlolra any ideas?

Jun 8 2021, 3:13 PM · affects-Kiwix-and-openZIM, Parsoid-Rendering
cscott added a comment to T199403: `composer test` in MediaWiki core doesn't work like it does in other repositories.

So, if I understand correctly, current status is that CI is running composer test-some <paths> now, but we haven't patched core's composer.json so that composer test Just Works like we expect. But it should be safe to do that now because CI doesn't use composer test any more?

Jun 8 2021, 1:51 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MW-1.35-notes, MW-1.31-release-notes, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Composer, MediaWiki-Core-Tests
cscott added a comment to T266305: Automatically clean up the parallel-lint command in composer.json files.

core doesn't have the . in the command... see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/441412 and T199403: `composer test` in MediaWiki core doesn't work like it does in other repositories, etc...

Jun 8 2021, 1:45 PM · LibUp

May 24 2021

cscott added a comment to T248343: Uncached VisualEditor w/ Parsoid/PHP (no JS, no RESTBase) for MW 1.35 LTS.

Unusually, I think we committed this zero-conf code only on the release branch, not in master, right? So we don't have to revert it in master to avoid breaking things the next time we muck around in MWParsoid/Config.

May 24 2021, 10:59 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, MW-1.35-release, Editing-team (Tracking), VisualEditor, Parsoid
cscott added a comment to T280270: parsoid REL1_36 branch and tag.

Parsoid v0.13.0 has been tagged, since I have not heard wailing and gnashing of teeth.

May 24 2021, 10:31 PM · Parsoid (Third-party), MW-1.36-release

May 20 2021

cscott committed rMLDO1980758bcc3f: Bump IDLeDOM to 0.5.1.
Bump IDLeDOM to 0.5.1
May 20 2021, 5:22 PM
cscott committed rMLID2199850bb52c: Release 0.5.1.
Release 0.5.1
May 20 2021, 4:43 PM
cscott committed rMLIDba78f965f8e2: Bump CHANGELOG after release.
Bump CHANGELOG after release
May 20 2021, 4:43 PM
cscott committed rMLIDe4043abe661d: Support pair iterators; improve type hints for iterables.
Support pair iterators; improve type hints for iterables
May 20 2021, 4:42 PM
cscott committed rMLID6becf33f61d8: Add WebIDL for the WHATWG URL spec.
Add WebIDL for the WHATWG URL spec
May 20 2021, 4:42 PM
cscott committed rMLID9ced6e19c0a2: Suppress type hints on DOMException::getMessage() and ::getCode().
Suppress type hints on DOMException::getMessage() and ::getCode()
May 20 2021, 4:41 PM

May 19 2021

cscott committed rMLDObd5dd5de9a01: Delint DocumentType.
Delint DocumentType
May 19 2021, 10:40 PM
cscott committed rMLDO5fff6d52ac03: De-lint DocumentFragment; implement get/setTextContent().
De-lint DocumentFragment; implement get/setTextContent()
May 19 2021, 10:40 PM
cscott committed rMLDO4c6148fce1df: Delint Element.
Delint Element
May 19 2021, 10:40 PM
cscott committed rMLDO7aa282c7940a: Clean up phan and phpcs warnings on Node.php.
Clean up phan and phpcs warnings on Node.php
May 19 2021, 10:40 PM
cscott committed rMLDO1ade387b6506: Fix phan and phpcs issues with cloneNode and isEqualNode.
Fix phan and phpcs issues with cloneNode and isEqualNode
May 19 2021, 10:40 PM
cscott committed rMLDOeca958aa16db: Additional Document fixes to remove phan and phpcs warnings.
Additional Document fixes to remove phan and phpcs warnings
May 19 2021, 10:40 PM
cscott committed rMLDOe847345d80e1: Delint DOMException.
Delint DOMException
May 19 2021, 10:40 PM
cscott committed rMLDO53551b434118: Delint CharacterData.
Delint CharacterData
May 19 2021, 10:40 PM
cscott committed rMLDOe20a44215bc2: Delint DOMImplementation.
Delint DOMImplementation
May 19 2021, 10:40 PM
cscott committed rMLDOf22f86464c69: Delint ChildNode.
Delint ChildNode
May 19 2021, 10:40 PM
cscott committed rMLDO0897da9e56dd: Rename Document::__rereference_doctype_and_documentElement().
Rename Document::__rereference_doctype_and_documentElement()
May 19 2021, 10:39 PM
cscott committed rMLID198495a39447: Bump CHANGELOG after release.
Bump CHANGELOG after release
May 19 2021, 7:37 PM
cscott committed rMLID19161e6c28b1: Release 0.5.0.
Release 0.5.0
May 19 2021, 7:37 PM
cscott committed rMLID788e384fc71b: Add Document::{load,loadXML,saveHTML,saveXML} for PHP compatibility.
Add Document::{load,loadXML,saveHTML,saveXML} for PHP compatibility
May 19 2021, 7:36 PM
cscott committed rMLDOe378754c9787: Test harness asserts improvements; FilteredElementList port (authored by Tim.abdullin).
Test harness asserts improvements; FilteredElementList port
May 19 2021, 7:34 PM
cscott committed rMLDO658ef026b529: Tests: fixed count() on string values; rewrite tests on robo build by default (authored by Tim.abdullin).
Tests: fixed count() on string values; rewrite tests on robo build by default
May 19 2021, 7:34 PM
cscott committed rMLDOb28e315d7241: Ensure HTMLCollection is live even if there is not a documentElement (yet).
Ensure HTMLCollection is live even if there is not a documentElement (yet)
May 19 2021, 7:34 PM
cscott committed rMLDObfc1e38f4cfc: Rename non-standard Node::_isRooted() method to standard Node::getIsConnected().
Rename non-standard Node::_isRooted() method to standard Node::getIsConnected()
May 19 2021, 6:53 PM
cscott committed rMLDO578df136f231: Switch from _ownerDocument to _nodeDocument; correct some confusion.
Switch from _ownerDocument to _nodeDocument; correct some confusion
May 19 2021, 6:53 PM
cscott committed rMLDO2b4dea15fab5: Add 'composer phpcbf' command.
Add 'composer phpcbf' command
May 19 2021, 6:53 PM
cscott committed rMLDOed7ff8673756: Rename Node::__set_owner to Node::_resetNodeDocument and update docs.
Rename Node::__set_owner to Node::_resetNodeDocument and update docs
May 19 2021, 6:53 PM
cscott committed rMLDOe3a8fcae329e: Don't allocate attributes on an Element unless there actually are attributes.
Don't allocate attributes on an Element unless there actually are attributes
May 19 2021, 3:04 PM
cscott committed rMLDOdfe251723788: Remove _nodeName field from Element to save space.
Remove _nodeName field from Element to save space
May 19 2021, 3:04 PM
cscott committed rMLDO3d5d3a9ce185: Ensure that parsing creates HTML Documents, not XML documents.
Ensure that parsing creates HTML Documents, not XML documents
May 19 2021, 3:03 PM
cscott committed rMLDO048f8bad3ac0: Implement Node::_modify() and Node::_lastModTime().
Implement Node::_modify() and Node::_lastModTime()
May 19 2021, 3:03 PM
cscott committed rMLDOc3b9eb120e8a: Implement Document::createElement for HTML element types.
Implement Document::createElement for HTML element types
May 19 2021, 3:03 PM
cscott committed rMLDO93157a49f97b: Optimize (and rename) Util::toAsciiLowercase/toAsciiUppercase.
Optimize (and rename) Util::toAsciiLowercase/toAsciiUppercase
May 19 2021, 3:03 PM
cscott committed rMLIDaa4fea0e91e4: Add HTML extensions to Document interface.
Add HTML extensions to Document interface
May 19 2021, 2:37 PM
cscott committed rMLIDc993d0db56a4: Add extensions from the DOM Parsing & Serialization specification.
Add extensions from the DOM Parsing & Serialization specification
May 19 2021, 2:37 PM
cscott committed rMLID4b18ae93d0ec: Refactor PHP extensions into a separate WebIDL file.
Refactor PHP extensions into a separate WebIDL file
May 19 2021, 2:37 PM
cscott committed rMLID31af7048caa5: Fix bug with union type declarations which involve a self-reference.
Fix bug with union type declarations which involve a self-reference
May 19 2021, 2:37 PM
cscott committed rMLIDb65bc21644e5: Enable StaticClosure and SwitchDeclaration code sniffs.
Enable StaticClosure and SwitchDeclaration code sniffs
May 19 2021, 5:10 AM

May 18 2021

cscott closed T271724: Document WebIDL binding for PHP, a subtask of T269259: Set up test infrastructure for testing the library against standard spec test suites, as Resolved.
May 18 2021, 2:26 PM · Patch-For-Review, Parsoid (Dodo)
cscott closed T271724: Document WebIDL binding for PHP, a subtask of T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library), as Resolved.
May 18 2021, 2:26 PM · Parsoid (Dodo)
cscott closed T271724: Document WebIDL binding for PHP as Resolved.

Done, in the wikimedia/idle-dom package, which defines the interfaces necessary for a DOM implementation:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/libs/IDLeDOM/+/refs/heads/main/WebIDL.md

May 18 2021, 2:26 PM · Parsoid (Dodo)

May 14 2021

cscott committed rMLDO3acb33581504: Rename Element::attributes to Element::_attributes.
Rename Element::attributes to Element::_attributes
May 14 2021, 3:07 AM
cscott committed rMLDO5048e8fb2c55: Implement Document::getElementById and factor out ContainerNode/Leaf.
Implement Document::getElementById and factor out ContainerNode/Leaf
May 14 2021, 3:06 AM
cscott committed rMLDOa31ec30090b9: Add return types for some methods of Document.
Add return types for some methods of Document
May 14 2021, 3:06 AM
cscott committed rMLDO33e7cc072ff2: Implement Document::getBody() and Document::getHead().
Implement Document::getBody() and Document::getHead()
May 14 2021, 3:06 AM
cscott committed rMLDO9252639611ac: Refactor Attribute mutation handlers.
Refactor Attribute mutation handlers
May 14 2021, 3:06 AM
cscott committed rMLDO7f4f3d921b25: Implement NodeIterator.
Implement NodeIterator
May 14 2021, 3:06 AM

May 13 2021

cscott committed rMLDO31bf4e5fa703: Rename Node::__remove_children.
Rename Node::__remove_children
May 13 2021, 10:44 PM
cscott committed rMLDO70637f0d7b24: Rename mutation handler methods.
Rename mutation handler methods
May 13 2021, 7:35 PM
cscott committed rMLDOcced73771a49: Rename __node_document to _nodeDocument.
Rename __node_document to _nodeDocument
May 13 2021, 7:35 PM
cscott committed rMLDO491cf7e78313: Rename __is_rooted to _isRooted.
Rename __is_rooted to _isRooted
May 13 2021, 7:35 PM
cscott committed rMLDO2fec2cb46120: Update to IDLeDOM 0.4.1; add DOMException and "simple exception" classes.
Update to IDLeDOM 0.4.1; add DOMException and "simple exception" classes
May 13 2021, 7:35 PM
cscott committed rMLDO95fa0d7488cc: Rename __sibling_index.
Rename __sibling_index
May 13 2021, 7:35 PM
cscott committed rMLDOe532f0024a92: Rename __document_index and __document_index_next to camelCase.
Rename __document_index and __document_index_next to camelCase
May 13 2021, 7:35 PM

May 12 2021

cscott committed rMLDO16319e5787f4: Refactor DOMTokenList to use IDLeDOM base class.
Refactor DOMTokenList to use IDLeDOM base class
May 12 2021, 3:32 PM
cscott committed rMLID42ece39cd45e: Release 0.4.1.
Release 0.4.1
May 12 2021, 3:32 PM
cscott committed rMLIDe83be3ab1af0: Bump CHANGELOG after release.
Bump CHANGELOG after release
May 12 2021, 3:32 PM
cscott committed rMLIDc885356255ca: Improve generated type hint for reflected attribute getter/setter.
Improve generated type hint for reflected attribute getter/setter
May 12 2021, 3:10 PM
cscott committed rMLID003f5fcd53d6: Add interfaces for WebIDL 'simple exceptions'.
Add interfaces for WebIDL 'simple exceptions'
May 12 2021, 3:10 PM
cscott committed rMLID6c95ba4e4b83: Reflect 'id', 'className', and 'slot' attributes of Element.
Reflect 'id', 'className', and 'slot' attributes of Element
May 12 2021, 3:10 PM
cscott committed rMLID893228d35768: Add Element::setIdAttribute{,NS,Node} for PHP compatibility.
Add Element::setIdAttribute{,NS,Node} for PHP compatibility
May 12 2021, 3:10 PM
cscott committed rMLDO2ec66a165d62: Bug fixes to Attr handling of null prefix/namespaces.
Bug fixes to Attr handling of null prefix/namespaces
May 12 2021, 6:15 AM
cscott committed rMLDO610bbf49af24: Update to latest IDLeDOM 0.4.0.
Update to latest IDLeDOM 0.4.0
May 12 2021, 5:24 AM
cscott committed rMLID35f9358d60eb: Add DOMException interface and document exception mapping.
Add DOMException interface and document exception mapping
May 12 2021, 5:14 AM
cscott committed rMLID8052464cdfa4: Fix broken links in WebIDL.md.
Fix broken links in WebIDL.md
May 12 2021, 5:14 AM
cscott committed rMLDObc04e17cb8b8: Move classes not defined by HTML or DOM standards to Dodo\Internal.
Move classes not defined by HTML or DOM standards to Dodo\Internal
May 12 2021, 3:09 AM
cscott committed rMLDO895d90cb2906: DOMImplementation::hasFeature() has been redefined by the WHATWG spec.
DOMImplementation::hasFeature() has been redefined by the WHATWG spec
May 12 2021, 3:09 AM
cscott committed rMLDO1d43c1daf9e1: Make DocumentType implementation properties private.
Make DocumentType implementation properties private
May 12 2021, 3:09 AM
cscott committed rMLDOfb7d8a8b2bcb: Fix Util::ascii_to_{lower,upper}case.
Fix Util::ascii_to_{lower,upper}case
May 12 2021, 3:09 AM
cscott committed rMLDO3a84cdba738f: Break the chicken-and-egg problem with DOMImplementation and Document.
Break the chicken-and-egg problem with DOMImplementation and Document
May 12 2021, 3:09 AM
cscott committed rMLDOef4cc8f94c5b: Clean up document type and encoding accessors; add XMLDocument.
Clean up document type and encoding accessors; add XMLDocument
May 12 2021, 3:09 AM
cscott committed rMLID12e1225d15db: Release 0.4.0.
Release 0.4.0
May 12 2021, 2:31 AM
cscott committed rMLID187c61b43e7a: Bump CHANGELOG after release.
Bump CHANGELOG after release
May 12 2021, 2:31 AM
cscott committed rMLIDa41559928d68: Update README.md and WebIDL.md.
Update README.md and WebIDL.md
May 12 2021, 2:12 AM

May 11 2021

cscott committed rMLIDb74832688a24: Add a Document::encoding setter for compatibility with PHP's DOMDocument.
Add a Document::encoding setter for compatibility with PHP's DOMDocument
May 11 2021, 9:36 PM
cscott committed rMLID670a1fad14a8: Fix extra brackets in CHANGELOG.
Fix extra brackets in CHANGELOG
May 11 2021, 9:36 PM
cscott committed rMLID5ac2c35cb8a1: Generate interfaces from IDL included in HTML specification.
Generate interfaces from IDL included in HTML specification
May 11 2021, 9:35 PM
cscott committed rMLID92141b07ccc6: Support unnamed getter/setter/deleter operations.
Support unnamed getter/setter/deleter operations
May 11 2021, 9:35 PM
cscott committed rMLID369de9691306: Support unnamed stringifier operations.
Support unnamed stringifier operations
May 11 2021, 9:35 PM