Mobile talk page editor fails if the talk page is a redirect
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

This task is about MediaWiki's MinervaNeue skin.
For more info about talk pages in MediaWiki: https://www.mediawiki.org/wiki/Help:Talk_pages
For more info about redirects in MediaWiki: https://www.mediawiki.org/wiki/Help:Redirects

When I visit https://en.m.wikipedia.org/wiki/Module:ITN_candidate/image#/talk/2 and try to add a message I get the following error:

{"servedby":"mw1227","error":{"code":"nosuchsection","info":"There is no section 2.","*":"See https://en.wikipedia.org/w/api.php for API usage"}}

Using:

action:edit
format:json
title:Module talk:In the news/image
section:2
appendtext:

Developer notes

The talk overlay is not getting the canonical name of the talk page. It assumes it will be prefixed with Module talk which is not the case.
Instead of doing this we should probably ship the talk page name as a config variable using Title::getTalkPage (I'm surprised there wasn't one) or make use of new mw.Title(mw.config.values.wgTitle, mw.config.values.wgNamespaceNumber)

Testing criteria

Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Redirected_talk_page&welcome=yes#/talk/1
Type a reply and hit save. This should not trigger an error.
Verify the reply is added to the talk page

Details

	Subject	Repo	Branch	Lines +/-
	Fix mobile talk page editor failure when the talk page is a redirect	mediawiki/extensions/MobileFrontend	master	+4 -2

Customize query in gerrit

Event Timeline

Jdlrobson created this task.May 26 2015, 8:47 AM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task to Incoming on the Web-Team-Backlog board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2015, 8:47 AM

phuedx moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.May 29 2015, 5:26 PM

Jdlrobson edited projects, added MobileFrontend; removed Web-Team-Backlog.Aug 4 2015, 6:58 PM

Jdlrobson set Security to None.

Restricted Application added a project: Web-Team-Backlog. · View Herald TranscriptAug 4 2015, 6:58 PM

Jdlrobson removed a project: Web-Team-Backlog.Aug 4 2015, 6:58 PM

Jdlrobson triaged this task as Low priority.Sep 9 2015, 8:06 PM

MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 4:27 PM

• bmansurov moved this task from 2016-17 Q2 to Incoming on the Web-Team-Backlog board.Apr 27 2016, 4:34 PM

MBinder_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 4 2016, 7:43 PM

Jdlrobson added projects: good first task, patch-welcome.Apr 27 2017, 8:05 PM

Jdlrobson updated the task description. (Show Details)

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 27 2017, 8:05 PM

(This is a bug)

@Anomie @Tgr any idea why this bug may be being hit?

action:edit
format:json
title:Module talk:ITN candidate/image
section:2
appendtext:

Test ~~~~
token:******

{"error":{"code":"nosuchsection","info":"There is no section 2.","*":"See https://en.wikipedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce&gt; for notice of API deprecations and breaking changes."},"servedby":"mw1189"}

Seems like it may be a bug with the API?

Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.May 26 2017, 5:45 PM

No, it's not a bug with the API. The talk page in question is currently a redirect that has no section 2.

Anomie removed a project: MediaWiki-Action-API.May 26 2017, 5:47 PM

Ah so it's a redirect problem... thanks for enlightening me that wasn't too intuitive.
How the heck do we get the talk page title in JavaScript?! It's not available via the mw.Title api...

new mw.Title(mw.config.values.wgTitle, mw.config.values.wgNamespaceNumber )

Jdlrobson moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog board.May 26 2017, 6:41 PM

Anomie renamed this task from Can't add items to module talk pages to Mobile talk page editor fails if the talk page is a redirect.May 26 2017, 8:27 PM

Jdlrobson updated the task description. (Show Details)May 26 2017, 9:23 PM

Jdlrobson updated the task description. (Show Details)

In T100404#3295442, @Jdlrobson wrote:
Ah so it's a redirect problem... thanks for enlightening me that wasn't too intuitive.
How the heck do we get the talk page title in JavaScript?! It's not available via the mw.Title api...
new mw.Title(mw.config.values.wgTitle, mw.config.values.wgNamespaceNumber )

Talk namespace is just subject namespace plus one (when it exists - not all namespaces have a talk namespace).

Jdlrobson updated the task description. (Show Details)May 30 2017, 4:30 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson set the point value for this task to 3.May 30 2017, 4:33 PM

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Jun 7 2017, 5:04 PM

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jun 14 2017, 4:21 PM

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Jun 28 2017, 6:01 PM

ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jul 5 2017, 11:47 AM

Jdlrobson edited projects, added MinervaNeue; removed MobileFrontend.Jul 13 2017, 6:06 PM

Jdlrobson moved this task from Backlog to Bugs on the MinervaNeue board.

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Aug 21 2017, 3:28 PM

Jdlrobson added a project: User-Jdlrobson.Oct 30 2017, 10:52 PM

Jdlrobson moved this task from Inbox to Next up on the User-Jdlrobson board.Nov 9 2017, 11:28 PM

Jdlrobson added a project: Google-Code-in-2017.Dec 1 2017, 7:50 PM

Aklapper updated the task description. (Show Details)Dec 5 2017, 4:41 PM

Imported as https://codein.withgoogle.com/tasks/4553173630976000/

eflyjason subscribed.Dec 26 2017, 1:23 AM

Is the main problem in skins/MinervaNeue/resources/skins.minerva.talk/init.js or other file?

Change 400203 had a related patch set uploaded (by Eflyjason; owner: Eflyjason):
[mediawiki/extensions/MobileFrontend@master] Fix mobile talk page editor fail when the talk page is a redirect

https://gerrit.wikimedia.org/r/400203

gerritbot added a project: Patch-For-Review.Dec 26 2017, 2:42 AM

It seems that using [[ https://www.mediawiki.org/wiki/API:Edit | redirect: true ]] in Edit API in MobileFronted's TalkSectionOverlay solve the problem.

redirect: Automatically resolve redirects. 1.17+

eflyjason edited projects, added MobileFrontend; removed MinervaNeue.Dec 26 2017, 4:11 AM

eflyjason claimed this task.Dec 26 2017, 5:20 AM

Jdlrobson updated the task description. (Show Details)Jan 2 2018, 9:36 PM

Change 400203 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix mobile talk page editor failure when the talk page is a redirect

https://gerrit.wikimedia.org/r/400203

Since patch is merged, I've added to sprint. Sam, maybe you could take a second glance at this and sign off? I've added some criteria.

Jdlrobson moved this task from To Do to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jan 2 2018, 9:46 PM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 2 2018, 10:00 PM

Jdlrobson moved this task from Triaged but Future to 2017-18 Q2 on the Web-Team-Backlog board.Jan 3 2018, 6:15 PM

Jdlrobson moved this task from Next up to Done on the User-Jdlrobson board.Jan 3 2018, 10:47 PM

This LGTM. Thanks, @eflyjason!

phuedx closed this task as Resolved.Jan 4 2018, 6:43 PM

• Phabricator_maintenance moved this task from 2017-18 Q2 to 2017-18 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:43 AM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 16 2020, 5:42 PM

Mobile talk page editor fails if the talk page is a redirectClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Developer notes

Testing criteria

Details

Event Timeline

Mobile talk page editor fails if the talk page is a redirect
Closed, ResolvedPublic3 Estimated Story Points
Actions