flaky test: MWException: Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	May 28 2015, 10:37 PM

Description

Dunno which extension is at fault:
https://integration.wikimedia.org/ci/job/mediawiki-extensions-zend/18603/consoleFull

22:23:07 There was 1 error:
22:23:07 
22:23:07 1) SpecialMobileDiffTest::testNames with data set #0 ('123', true)
22:23:07 MWException: Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this.
22:23:07 
22:23:07 /mnt/jenkins-workspace/workspace/mediawiki-extensions-zend/src/includes/diff/DifferenceEngine.php:790
22:23:07 /mnt/jenkins-workspace/workspace/mediawiki-extensions-zend/src/includes/diff/DifferenceEngine.php:733
22:23:07 /mnt/jenkins-workspace/workspace/mediawiki-extensions-zend/src/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php:214
22:23:07 /mnt/jenkins-workspace/workspace/mediawiki-extensions-zend/src/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php:125
22:23:07 /mnt/jenkins-workspace/workspace/mediawiki-extensions-zend/src/extensions/MobileFrontend/tests/phpunit/specials/SpecialMobileDiffTest.php:22
22:23:07 /mnt/jenkins-workspace/workspace/mediawiki-extensions-zend/src/tests/phpunit/MediaWikiTestCase.php:131

Details

	Subject	Repo	Branch	Lines +/-
	Fix SpecialMobileDiffTest#testNames test	mediawiki/extensions/MobileFrontend	master	+2 -3
	Disable broken test "SpecialMobileDiffTest::testNames"	mediawiki/extensions/MobileFrontend	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: rEMFR081abb0052c1: Fix SpecialMobileDiffTest#testNames test
rMEXT308fd2e92c32: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFR5cb85b922204: Disable broken test "SpecialMobileDiffTest::testNames"
rMEXTffadcb19d394: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…

Event Timeline

Legoktm created this task.May 28 2015, 10:37 PM

Legoktm raised the priority of this task from to Needs Triage.

Legoktm updated the task description. (Show Details)

Legoktm added projects: MobileFrontend, StructuredDiscussions.

Legoktm subscribed.

Restricted Application added projects: Collaboration-Team-Triage, Web-Team-Backlog. · View Herald TranscriptMay 28 2015, 10:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Again on https://integration.wikimedia.org/ci/job/mediawiki-extensions-zend/18624/consoleFull

Legoktm triaged this task as High priority.May 29 2015, 1:03 AM

Florian subscribed.May 29 2015, 4:12 PM

phuedx moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.May 29 2015, 5:18 PM

phuedx added a project: Mobile-Web-Sprint-48-Voyage-of-the-Damned.May 29 2015, 5:50 PM

phuedx set Security to None.

This is getting really annoying, and causing random core and extension patches to fail. (https://integration.wikimedia.org/ci/job/mediawiki-extensions-zend/18723/consoleFull)

Apparently only happening on zend???

phuedx merged a task: T100967: SpecialMobileDiffTest::testNames randomly failing.Jun 1 2015, 9:59 AM

phuedx added a subscriber: Tgr.

Still happening. Again on
https://integration.wikimedia.org/ci/job/mediawiki-extensions-zend/18867/consoleFull
https://integration.wikimedia.org/ci/job/mediawiki-extensions-zend/18868/consoleFull

Change 215036 had a related patch set uploaded (by Krinkle):
Disable broken test "SpecialMobileDiffTest::testNames"

https://gerrit.wikimedia.org/r/215036

gerritbot added a project: Patch-For-Review.Jun 1 2015, 3:05 PM

phuedx claimed this task.Jun 1 2015, 3:13 PM

phuedx moved this task from Needs Analysis to Doing on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.

Change 215036 merged by jenkins-bot:
Disable broken test "SpecialMobileDiffTest::testNames"

https://gerrit.wikimedia.org/r/215036

Krinkle mentioned this in rMEXTffadcb19d394: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 1 2015, 3:14 PM

Krinkle mentioned this in rEMFR5cb85b922204: Disable broken test "SpecialMobileDiffTest::testNames".

Change 215386 had a related patch set uploaded (by Phuedx):
Fix SpecialMobileDiffTest#testNames test

https://gerrit.wikimedia.org/r/215386

phuedx moved this task from Doing to Code Review on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.Jun 2 2015, 6:56 PM

AFAICT the test was exercising the whole stack, including loading revisions by ID from the DB, in order to test one specific part of SpecialMobileDiffTest#executeWhenAvailable.

Change 215386 merged by jenkins-bot:
Fix SpecialMobileDiffTest#testNames test

https://gerrit.wikimedia.org/r/215386

phuedx mentioned this in rMEXT308fd2e92c32: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 2 2015, 7:43 PM

phuedx mentioned this in rEMFR081abb0052c1: Fix SpecialMobileDiffTest#testNames test.

Jdlrobson moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.Jun 2 2015, 8:03 PM

Krinkle unsubscribed.Jun 4 2015, 12:42 AM