Page MenuHomePhabricator
Create Task
Maniphest T100726

Temporarily disable 'Link preview' feature
Closed, ResolvedPublic
Actions

Description

Disable the 'Link preview' and then add it to a feature branch. We will resurrect this at a later date.

Details

SubjectRepoBranchLines +/-
Temporarily kill hovercards until we can work out the behaviourmediawiki/extensions/MobileFrontendmaster+1 -289
Rename quickLookup to Hovercardsmediawiki/extensions/MobileFrontendmaster+28 -19
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• bmansurovT100297 [EPIC] Turn off alpha
 ResolvedFlorianT100726 Temporarily disable 'Link preview' feature

Event Timeline

kaldari created this task.May 28 2015, 11:41 PM
kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a project: Web-Team-Backlog.
kaldari subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2015, 11:41 PM
kaldari added a parent task: T100297: [EPIC] Turn off alpha.May 28 2015, 11:41 PM
• bmansurov added a subtask: T100679: Create a tutorial (similar to edit tutorial, or gather tutorial) about how to use the quickLookup feature.May 28 2015, 11:43 PM
• bmansurov subscribed.

I wonder if we should rename quickLookup to linkPreview?

Liuxinyu970226 subscribed.May 28 2015, 11:54 PM
kaldari added a project: Mobile-Web-Sprint-48-Voyage-of-the-Damned.May 29 2015, 4:11 PM
kaldari set Security to None.
phuedx moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Jun 1 2015, 10:02 AM
phuedx moved this task from Needs Prioritization to 2014-15 Q4 on the Web-Team-Backlog board.Jun 1 2015, 10:12 AM
phuedx removed a project: Mobile-Web-Sprint-48-Voyage-of-the-Damned.Jun 2 2015, 9:38 AM
Jdlrobson subscribed.Jun 4 2015, 10:43 PM

Renaming to Hovercards would at least give product consistency..

Florian subscribed.Jun 13 2015, 6:03 PM
Florian claimed this task.Jul 29 2015, 4:27 PM
gerritbot subscribed.Jul 29 2015, 4:52 PM

Change 227748 had a related patch set uploaded (by Florianschmidtwelzow):
Move quickLookup to beta and rename to Hovercards

https://gerrit.wikimedia.org/r/227748

gerritbot added a project: Patch-For-Review.Jul 29 2015, 4:52 PM
• KHammerstein subscribed.Aug 6 2015, 8:17 PM

@bmansurov Can you attach a screenshot?

• JKatzWMF added subscribers: Dbrant, • JKatzWMF.Aug 6 2015, 8:21 PM

@bmansurov can we play with this somewhere before promoting to beta? Also, I think event logging akin to what they have done in apps (check with @Dbrant) is a crucial blocker to successful promotion to stable.

• bmansurov added a comment.Aug 6 2015, 9:27 PM

@KHammerstein: (Obama's page)

Screen Shot 2015-08-06 at 5.26.23 PM.png (1×602 px, 230 KB)

@JKatzWMF: Yes, you can test it on your phone by going to https://en.m.wikipedia.org/wiki/Barack_Obama?mobileaction=alpha and swiping over a link.

Florian added a comment.Aug 6 2015, 10:00 PM

@KHammerstein & @bmansurov The change above (https://gerrit.wikimedia.org/r/227748) fixes the white "X" (close) button to, that should be black :)

Jdlrobson added a comment.Aug 6 2015, 10:01 PM

Note swiping doesn't seem to work on ios for me or desktop browsers so you'll need an Android device...

• bmansurov added a comment.Aug 6 2015, 10:03 PM

Yes, I forgot to apply your patch, @Florian.

gerritbot added a comment.Aug 14 2015, 10:08 PM

Change 231699 had a related patch set uploaded (by Jdlrobson):
Temporarily kill hovercards until we can work out the behaviour

https://gerrit.wikimedia.org/r/231699

Jdlrobson moved this task from 2014-15 Q4 to 2017-18 Q3 on the Web-Team-Backlog board.Aug 14 2015, 10:41 PM
• Jhernandez triaged this task as Medium priority.Aug 17 2015, 12:43 PM
• Jhernandez edited projects, added MobileFrontend; removed Web-Team-Backlog.
• Jhernandez moved this task from Backlog to team:other on the MobileFrontend board.Aug 17 2015, 12:49 PM
gerritbot added a comment.Aug 21 2015, 9:50 PM

Change 227748 merged by jenkins-bot:
Rename quickLookup to Hovercards

https://gerrit.wikimedia.org/r/227748

Florian mentioned this in rMEXT2243bf026717: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Aug 21 2015, 9:50 PM
Jdlrobson mentioned this in rEMFRc3c5d4e86c70: Rename quickLookup to Hovercards.Aug 21 2015, 9:50 PM
• Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 23 2015, 1:01 AM
• Jhernandez subscribed.Aug 28 2015, 10:34 AM

How is this going? Moving to next sprint's code review to give it eyeballs!

• Jhernandez added a project: Reading-Web-Sprint-55-π.Aug 28 2015, 10:34 AM
• Jhernandez moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-55-π board.
Jdlrobson renamed this task from Promote 'Link preview' to beta to Temporarily disable 'Link preview' feature.Aug 28 2015, 9:14 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a comment.Aug 28 2015, 10:13 PM

https://gerrit.wikimedia.org/r/231699 needs review

kaldari unsubscribed.Aug 28 2015, 10:44 PM
• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-55-π board.Aug 29 2015, 12:16 AM
phuedx closed this task as Resolved.Sep 3 2015, 10:32 AM
phuedx mentioned this in T111329: [GOAL] Page previews on mobileweb.
phuedx subscribed.

This is a technical task.

I've created the Hovercards epic (T111329) to track reasoning around and design/eventual resurrection of the hovercards feature.

phuedx removed a subtask: T100679: Create a tutorial (similar to edit tutorial, or gather tutorial) about how to use the quickLookup feature.Sep 3 2015, 10:34 AM
Liuxinyu970226 unsubscribed.Sep 3 2015, 10:44 AM
phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-55-π board.Sep 3 2015, 2:04 PM
Jdlrobson added a comment.Sep 3 2015, 10:11 PM

Thanks phuedx !

gerritbot added a comment.Sep 10 2015, 11:49 PM

Change 231699 merged by jenkins-bot:
Temporarily kill hovercards until we can work out the behaviour

https://gerrit.wikimedia.org/r/231699

• Konfused-Kitten mentioned this in rMEXTdd07a95c306a: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 10 2015, 11:49 PM
• Konfused-Kitten mentioned this in rEMFR2e5229b5f590: Temporarily kill hovercards until we can work out the behaviour.
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 11 2015, 12:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits