Page MenuHomePhabricator

Loading noJS edit pages with JS enabled (e.g. in new tab) causes wikitext to be loaded into VE
Open, NormalPublic

Description

https://ru.wikipedia.org/w/index.php?title=%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F:%D0%A4%D0%BE%D1%80%D1%83%D0%BC/%D0%9D%D0%BE%D0%B2%D0%BE%D1%81%D1%82%D0%B8/Flow
When I right-click "Edit description" and choose "open in new tab"
text "By saving changes..." appears not fully


+visual editor opens with gray background


and in wikitext added nowiki nowiki tags

Event Timeline

Sunpriat updated the task description. (Show Details)
Sunpriat raised the priority of this task from to Needs Triage.
Sunpriat added a subscriber: Sunpriat.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sunpriat renamed this task from Flow: Warning does not fit if edit the header in a separate flow to Flow: Warning does not fit if edit the header in a separate tab.May 29 2015, 12:48 PM
Sunpriat set Security to None.
Sunpriat updated the task description. (Show Details)May 29 2015, 1:13 PM
Sunpriat updated the task description. (Show Details)
Catrope renamed this task from Flow: Warning does not fit if edit the header in a separate tab to Opening "Edit description" in separate tab breaks editor.May 29 2015, 6:37 PM
Catrope added a subscriber: Catrope.
Catrope renamed this task from Opening "Edit description" in separate tab breaks editor to Loading noJS edit pages with JS enabled (e.g. in new tab) causes wikitext to be loaded into VE.May 29 2015, 9:58 PM

Looks like this is broken for all noJS views. It's not just the description edit page, but also the post edit page.

It happens because we use a hack for VE support which populates the <textarea> with Parsoid HTML which is then extracted and put into VE. However, in the noJS view we put wikitext in the textbox, and the VE loading code then treats that as HTML.

DannyH added a subscriber: DannyH.Jun 2 2015, 4:44 PM

@Catrope, is it possible to change the behavior so that opening these links in a new tab gives you the normal JS experience?

I know we'd still have to fix no-JS bugs, but this particular situation could be avoidable.

@Catrope, is it possible to change the behavior so that opening these links in a new tab gives you the normal JS experience?

I know we'd still have to fix no-JS bugs, but this particular situation could be avoidable.

(Sorry for the late response.)

Did you mean:

  1. "when I open these links in a new tab, I should get the non-JS experience", or
  2. "when I open these links in a new tab, I should get a JS experience but it should be broken in this weird way", or
  3. "when I open these links in a new tab, what I get should look exactly like what I would see if I had left-clicked", or
  4. "when I try to open these links in a new tab, it should ignore me and perform the action in-place as if I left-clicked"?

#1 is feasible but I don't think it's a good experience. #2 is what this bug originally asked for (minimally invasive unbreaking change). #3 would be somewhat more consistent than what we have now (now it takes you to the topic, not the full board), but my gut says that linking to the full board is probably not a good idea, partly for technical reasons (but let's discuss with the rest of the team if #3 is what you meant). #4 is not possible (and the only techinques that come close are evil and annoying to users).

With recent fixes

  • right-click "Edit description" does not give options 'Open in New Tab', 'Open in New Window etc anymore
  • the first screenshot refers to the fixed issue T108609 ""By saving changes" description legal message partially covered by page footer when the description is being edited"
  • the second screenshot refers to the fixed T100824: Background for description editor should be consistent between wikitext and VE
  • the third screenshot(about adding <nowiki>) is a current behavior: if wikitext with templates/links is pasted to VE and a user then switches to wikitext markup - ,nowiki. tags are added.

Should we keep this issue as a separate bug?

A real user is less likely to hit this bug due to the first point @Etonkovidova mentioned (in JS mode, it's no longer a link).

However, it is still present if a JS user somehow visits action=edit-header: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Flow&action=edit-header .

Suggest keeping open; it is less likely to occur though.

Re "if wikitext with templates/links is pasted to VE and a user then switches to wikitext markup - ,nowiki. tags are added." that's fine, the only issue is if wikitext is wrongly loaded into the VE editor by the software itself (which is happening in this case).