Page MenuHomePhabricator
Create Task
Maniphest T102616

Upgrade HHVM on CI Trusty slaves from 3.3.1 to 3.6.1
Closed, ResolvedPublic
Actions

Description

Task track upgrade of HHVM on CI Trusty slaves. The last attempt caused mediawiki/core test to fail (T98876). A workaround as been found T98882#1362186 which is simply to set a php.ini variable.

Details

SubjectRepoBranchLines +/-
Disable testImportDoesntCompletelyFailmediawiki/extensions/FlowREL1_31+4 -0
Disable testImportDoesntCompletelyFailmediawiki/extensions/Flowmaster+3 -0
Point MediaWiki database host to 127.0.0.1integration/jenkinsmaster+1 -1
MediaWiki MySQL db should use TCP instead of socketintegration/jenkinsmaster+3 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Jun 16 2015, 1:00 PM
hashar claimed this task.
hashar raised the priority of this task from to Medium.
hashar updated the task description. (Show Details)
hashar added projects: HHVM, Continuous-Integration-Infrastructure.
hashar added a parent task: T101275: Build a new version of php-luasandbox and hhvm-luasandbox, and deploy to integration hosts.
hashar mentioned this in T101275: Build a new version of php-luasandbox and hhvm-luasandbox, and deploy to integration hosts.
hashar moved this task from Untriaged to In-progress on the Continuous-Integration-Infrastructure board.
hashar added subscribers: JanZerebecki, Addshore, gerritbot and 4 others.
polybuildr subscribed.Jun 16 2015, 1:01 PM
hashar added a comment.Jun 16 2015, 1:02 PM

State gathered using:

salt -v -t 30  --out=json -C 'G@oscodename:trusty and *slave*' pkg.version hhvm hhvm-dev hhvm-fss hhvm-luasandbox hhvm-tidy hhvm-wikidiff2
{
    "integration-slave-trusty-1012.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1014.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1017.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1011.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1021.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1016.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1013.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1015.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
hashar added a comment.Jun 16 2015, 1:06 PM
 salt -v -t 30  --out=json -C 'G@oscodename:trusty and *slave*' pkg.install pkgs='["hhvm","hhvm-dev","hhvm-fss","hhvm-luasandbox","hhvm-tidy","hhvm-wikidiff2"]'
Executing job with jid 20150616130514053212
{
    "integration-slave-trusty-1012.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1014.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1011.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1017.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1016.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1015.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1013.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1021.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
gerritbot added a comment.Jun 16 2015, 1:16 PM

Change 218624 had a related patch set uploaded (by Hashar):
MediaWiki MySQL db should use TCP instead of socket

https://gerrit.wikimedia.org/r/218624

gerritbot added a project: Patch-For-Review.Jun 16 2015, 1:16 PM

Change 218624 merged by jenkins-bot:
MediaWiki MySQL db should use TCP instead of socket

https://gerrit.wikimedia.org/r/218624

gerritbot added a comment.Jun 16 2015, 1:19 PM

Change 218625 had a related patch set uploaded (by Hashar):
Point MediaWiki database host to 127.0.0.1

https://gerrit.wikimedia.org/r/218625

gerritbot added a comment.Jun 16 2015, 1:20 PM

Change 218625 merged by jenkins-bot:
Point MediaWiki database host to 127.0.0.1

https://gerrit.wikimedia.org/r/218625

hashar added a comment.Jun 16 2015, 1:22 PM

So installing with $wgDBServer = localhost causes MediaWiki/PHP to connect over a socket but our HHVM 3.6.x does not support that connection method.

I injected port 3306 to $wgDBServer but that did not make the trick. Thus later switched to 127.0.0.1:3306 which trigger a TCP connection.

hashar added a comment.Jun 16 2015, 1:27 PM

I triggered Jenkins jobs mediawiki-phpunit-hhvm pass.

mediawiki-extensions-hhvm fails though:

Flow\Tests\Import\TalkpageImportOperationTest::testImportDoesntCompletelyFail
Flow\Exception\PermissionException: Formatting for wrong user: 127.0.0.1 instead of UTSysop
hashar mentioned this in T102622: Flow\Tests\Import\TalkpageImportOperationTest.testImportDoesntCompletelyFail fails under HHVM/MySQL when $wgDBserver = '127.0.0.1:3306'.Jun 16 2015, 1:40 PM
gerritbot added a comment.Jun 16 2015, 1:43 PM

Change 218631 had a related patch set uploaded (by Hashar):
Disable testImportDoesntCompletelyFail

https://gerrit.wikimedia.org/r/218631

gerritbot added a comment.Jun 16 2015, 1:52 PM

Change 218631 abandoned by Hashar:
Disable testImportDoesntCompletelyFail

Reason:
Bah the job seems to pass now.

https://gerrit.wikimedia.org/r/218631

hashar closed this task as Resolved.Jun 16 2015, 2:00 PM

The CI slaves have been upgraded.

hashar mentioned this in rCIJE1d6038aa6f4a: MediaWiki MySQL db should use TCP instead of socket.Jun 16 2015, 2:30 PM
hashar mentioned this in rCIJE28ba237e8320: Point MediaWiki database host to 127.0.0.1.
Ricordisamoa subscribed.Jun 17 2015, 4:41 AM
hashar mentioned this in T102720: CRM Jenkins build failing.Jun 17 2015, 8:59 AM
hashar moved this task from In-progress to Done on the Continuous-Integration-Infrastructure board.Jun 23 2015, 9:08 AM
gerritbot added a comment.Jul 25 2020, 12:11 PM

Change 616041 had a related patch set uploaded (by Reedy; owner: Hashar):
[mediawiki/extensions/Flow@REL1_31] Disable testImportDoesntCompletelyFail

https://gerrit.wikimedia.org/r/616041

gerritbot added a comment.Jul 25 2020, 12:43 PM

Change 616041 merged by Reedy:
[mediawiki/extensions/Flow@REL1_31] Disable testImportDoesntCompletelyFail

https://gerrit.wikimedia.org/r/616041

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits