Page MenuHomePhabricator

Upgrade HHVM on CI Trusty slaves from 3.3.1 to 3.6.1
Closed, ResolvedPublic

Description

Task track upgrade of HHVM on CI Trusty slaves. The last attempt caused mediawiki/core test to fail (T98876). A workaround as been found T98882#1362186 which is simply to set a php.ini variable.

Event Timeline

State gathered using:

salt -v -t 30  --out=json -C 'G@oscodename:trusty and *slave*' pkg.version hhvm hhvm-dev hhvm-fss hhvm-luasandbox hhvm-tidy hhvm-wikidiff2
{
    "integration-slave-trusty-1012.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1014.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1017.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1011.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1021.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1016.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1013.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
{
    "integration-slave-trusty-1015.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": "2.0-8", 
        "hhvm-wikidiff2": "1.3-3.1", 
        "hhvm-fss": "1.1-3.1", 
        "hhvm-tidy": "0.1-3", 
        "hhvm-dev": "3.3.1+dfsg1-1+wm3.1", 
        "hhvm": "3.3.1+dfsg1-1+wm3.1"
    }
}
 salt -v -t 30  --out=json -C 'G@oscodename:trusty and *slave*' pkg.install pkgs='["hhvm","hhvm-dev","hhvm-fss","hhvm-luasandbox","hhvm-tidy","hhvm-wikidiff2"]'
Executing job with jid 20150616130514053212
{
    "integration-slave-trusty-1012.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1014.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1011.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1017.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1016.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1015.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1013.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}
{
    "integration-slave-trusty-1021.integration.eqiad.wmflabs": {
        "hhvm-luasandbox": {
            "new": "2.0.11", 
            "old": "2.0-8"
        }, 
        "hhvm-wikidiff2": {
            "new": "1.3.4", 
            "old": "1.3-3.1"
        }, 
        "hhvm-fss": {
            "new": "1.1.7", 
            "old": "1.1-3.1"
        }, 
        "hhvm-tidy": {
            "new": "0.1-4", 
            "old": "0.1-3"
        }, 
        "hhvm-dev": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }, 
        "hhvm": {
            "new": "3.6.1+dfsg1-1+wm3", 
            "old": "3.3.1+dfsg1-1+wm3.1"
        }
    }
}

Change 218624 had a related patch set uploaded (by Hashar):
MediaWiki MySQL db should use TCP instead of socket

https://gerrit.wikimedia.org/r/218624

Change 218624 merged by jenkins-bot:
MediaWiki MySQL db should use TCP instead of socket

https://gerrit.wikimedia.org/r/218624

Change 218625 had a related patch set uploaded (by Hashar):
Point MediaWiki database host to 127.0.0.1

https://gerrit.wikimedia.org/r/218625

Change 218625 merged by jenkins-bot:
Point MediaWiki database host to 127.0.0.1

https://gerrit.wikimedia.org/r/218625

So installing with $wgDBServer = localhost causes MediaWiki/PHP to connect over a socket but our HHVM 3.6.x does not support that connection method.

I injected port 3306 to $wgDBServer but that did not make the trick. Thus later switched to 127.0.0.1:3306 which trigger a TCP connection.

I triggered Jenkins jobs mediawiki-phpunit-hhvm pass.

mediawiki-extensions-hhvm fails though:

Flow\Tests\Import\TalkpageImportOperationTest::testImportDoesntCompletelyFail
Flow\Exception\PermissionException: Formatting for wrong user: 127.0.0.1 instead of UTSysop

Change 218631 had a related patch set uploaded (by Hashar):
Disable testImportDoesntCompletelyFail

https://gerrit.wikimedia.org/r/218631

Change 218631 abandoned by Hashar:
Disable testImportDoesntCompletelyFail

Reason:
Bah the job seems to pass now.

https://gerrit.wikimedia.org/r/218631

hashar closed this task as Resolved.Jun 16 2015, 2:00 PM

The CI slaves have been upgraded.