$wgUseGzip doesn’t work in 1.24 - 1-26alpha
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Seb35
	Jun 20 2015, 4:54 PM

Description

In MediaWiki master (1.26alpha) $wgUseGzip doesn’t compress pages on disk when $wgUseFileCache is enabled.

I tracked the $wgUseGzip setting and it appears it is only used in the constructor of FileCacheBase, then saved in a property mUseGzip for child classes. But, since 0fddd42, parent constructor of HTMLFileCache is not called, and mUseGzip is always false (previously there were no defined constructor in HTMLFileCache, so parent constructor was implicitely used).

I tested by adding parent::__construct(); and it works (it gzips the cached files on disk). I prepare a gerrit change.

PS: this bug is not related to the 4 other bugs related to $wgUseGzip, specifically not related to T28243 (older than this change).

Details

Subject	Repo	Branch	Lines +/-
$wgUseGzip had no effect	mediawiki/core	REL1_24	+9 -0
$wgUseGzip had no effect	mediawiki/core	REL1_25	+8 -0
$wgUseGzip had no effect	mediawiki/core	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: rMWad0d70fd52f9: $wgUseGzip had no effect
Mentioned Here: rMW0fddd42ca4ec: Deprecate HTMLFileCache::newFromTitle() in favor of constructor
T28243: $wgUseGzip is not working

Event Timeline

Seb35 created this task.Jun 20 2015, 4:54 PM

Seb35 claimed this task.

Seb35 raised the priority of this task from to Low.

Seb35 updated the task description. (Show Details)

Seb35 added a project: MediaWiki-General.

Seb35 added a subscriber: MaxSem.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2015, 4:54 PM

Change 219584 had a related patch set uploaded (by Seb35):
$wgUseGzip had no effect

https://gerrit.wikimedia.org/r/219584

gerritbot added a project: Patch-For-Review.Jun 20 2015, 5:11 PM

Krinkle edited projects, added MediaWiki-libs-BagOStuff; removed MediaWiki-General.Jun 23 2015, 4:12 AM

Krinkle set Security to None.

Krinkle added a subscriber: aaron.

Change 219584 merged by jenkins-bot:
$wgUseGzip had no effect

https://gerrit.wikimedia.org/r/219584

Seb35 mentioned this in rMWad0d70fd52f9: $wgUseGzip had no effect.Jun 24 2015, 9:00 PM

https://gerrit.wikimedia.org/r/219584 (branch master): MW-1.26-release, WMF-deploy-2015-06-30_(1.26wmf12)

Worth back-porting?

Nobody complained before so probably this feature is not widely used, but I would say yes for backporting in 1.24 and 1.25 (the bug appeared in 1.24) since this feature is theoretically supported (given there is a config variable).

Ciencia_Al_Poder subscribed.Jun 26 2015, 7:26 PM

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM

In T103237#1405714, @Seb35 wrote:

Nobody complained before so probably this feature is not widely used, but I would say yes for backporting in 1.24 and 1.25 (the bug appeared in 1.24) since this feature is theoretically supported (given there is a config variable).

So does anybody plan to put two patch in Gerrit for backporting?
Or should this task just be closed as resolved in 1.26?

In T103237#1405714, @Seb35 wrote:

Nobody complained before so probably this feature is not widely used, but I would say yes for backporting in 1.24 and 1.25 (the bug appeared in 1.24) since this feature is theoretically supported (given there is a config variable).

So does anybody plan to put two patch in Gerrit for backporting?
Or should this task just be closed as resolved in 1.26?

Change 246396 had a related patch set uploaded (by Martineznovo):
$wgUseGzip had no effect

https://gerrit.wikimedia.org/r/246396

Change 246407 had a related patch set uploaded (by Martineznovo):
$wgUseGzip had no effect

https://gerrit.wikimedia.org/r/246407

done, it now only needs merging :)

Umherirrender closed this task as Resolved.Oct 16 2015, 6:22 PM

Umherirrender added projects: MW-1.24-release, MW-1.25-release.