NOTE: On hold pending epic work on updating article navigation
When viewing the article tabs in app, it should be possible to dismiss a given tab by swiping.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add swipe to dismiss article tab functionality | apps/android/wikipedia | master | +383 -103 |
Related Objects
Related Objects
Event Timeline
Comment Actions
A good candidate for RecyclerView? If I recall, it provides built-in support for swiping items.
Comment Actions
I don't think I've done it personally yet but I saw this related article on that topic in the Android Weekly newsletter recently. In general, I believe we should always use RecyclerViews as they provide more consistent presentation across API levels in my experience, but I've seen strong opinions to the contrary.
Comment Actions
Change 354837 had a related patch set uploaded (by Jjanku; owner: Jjanku):
[apps/android/wikipedia@master] Add swipe to dismiss article tab functionality
Comment Actions
Change 354837 abandoned by Dbrant:
Add swipe to dismiss article tab functionality
Reason:
Shelving for now, since we're still not sure how we'd like to proceed with this. If this patch could be made very small, then it could be accepted, but otherwise we'd probably rather rework the whole way that we display the tabs to the user, but that will require some more design and user research.