Page MenuHomePhabricator
Create Task
Maniphest T105211

ResourceLoader modules dynamically generated by "ResourceLoaderRegisterModules" hook handlers don't work in debug mode
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
Reformat dynamic ResourceLoader::register calls for readabilitymediawiki/extensions/Wikibasemaster+65 -90
Add missing docs to ResourceLoaderRegisterModules hooksmediawiki/extensions/Wikibasemaster+8 -0
Fix broken localBasePath's in ResourceLoader::register callsmediawiki/extensions/Wikibasemaster+9 -10
Use the ResourceLoaderRegisterModules hook + ExtensionRegistry for dynamic dependenciesmediawiki/extensions/Wikibasewmf/1.26wmf13+170 -75
Use the ResourceLoaderRegisterModules hook + ExtensionRegistry for dynamic dependenciesmediawiki/extensions/Wikibasemaster+168 -75
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sjoerddebruin created this task.Jul 8 2015, 6:33 PM
Sjoerddebruin raised the priority of this task from to Needs Triage.
Sjoerddebruin updated the task description. (Show Details)
Sjoerddebruin added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Regression.
Sjoerddebruin subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2015, 6:33 PM
hoo claimed this task.Jul 8 2015, 6:40 PM
hoo triaged this task as Unbreak Now! priority.
gerritbot subscribed.Jul 8 2015, 8:30 PM

Change 223660 had a related patch set uploaded (by Hoo man):
Use the ResourceLoaderRegisterModules hook ExtensionRegistry for dynamic dependencies

https://gerrit.wikimedia.org/r/223660

gerritbot added a project: Patch-For-Review.Jul 8 2015, 8:30 PM
gerritbot added a comment.Jul 8 2015, 8:58 PM

Change 223660 merged by jenkins-bot:
Use the ResourceLoaderRegisterModules hook ExtensionRegistry for dynamic dependencies

https://gerrit.wikimedia.org/r/223660

hoo mentioned this in rEWBA74a4be5129ca: Use the ResourceLoaderRegisterModules hook + ExtensionRegistry for dynamic….Jul 8 2015, 8:58 PM
Diffusion mentioned this in rMEXT1b79fcbbc97f: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 8 2015, 8:58 PM
gerritbot added a comment.Jul 8 2015, 9:10 PM

Change 223672 had a related patch set uploaded (by Hoo man):
Use the ResourceLoaderRegisterModules hook ExtensionRegistry for dynamic dependencies

https://gerrit.wikimedia.org/r/223672

gerritbot added a comment.Jul 8 2015, 9:16 PM

Change 223672 merged by jenkins-bot:
Use the ResourceLoaderRegisterModules hook ExtensionRegistry for dynamic dependencies

https://gerrit.wikimedia.org/r/223672

hoo mentioned this in rEWBAde80d2f861c1: Use the ResourceLoaderRegisterModules hook + ExtensionRegistry for dynamic….Jul 8 2015, 9:17 PM
hoo renamed this task from Language input box (for monolingual text properties) doesn't give suggestions anymore to ResourceLoader modules no longer depend on ULS after conversion to extension registration.Jul 8 2015, 9:43 PM
hoo closed this task as Resolved.
hoo updated the task description. (Show Details)
hoo removed a project: Patch-For-Review.
hoo set Security to None.
Nikerabbit subscribed.Jul 9 2015, 6:00 AM

I was not aware of this report. Around the same a fix was merged and deployed to production to restore the constant. The breakage was not intentional.

gerritbot added a comment.Jul 10 2015, 12:50 PM

Change 224060 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix broken localBasePath's in ResourceLoader::register calls

https://gerrit.wikimedia.org/r/224060

gerritbot added a project: Patch-For-Review.Jul 10 2015, 12:50 PM
gerritbot added a comment.Jul 10 2015, 12:54 PM

Change 224061 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add missing docs to ResourceLoaderRegisterModules hooks

https://gerrit.wikimedia.org/r/224061

gerritbot added a comment.Jul 10 2015, 1:10 PM

Change 224063 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Reformat dynamic ResourceLoader::register calls for readability

https://gerrit.wikimedia.org/r/224063

thiemowmde added a project: Wikidata-Sprint-2015-06-30.Jul 10 2015, 1:18 PM
thiemowmde subscribed.
Lydia_Pintscher edited a custom field.Jul 12 2015, 12:32 AM
Addshore moved this task from Backlog to Done on the Wikidata-Sprint-2015-06-30 board.Jul 13 2015, 9:52 AM
thiemowmde reopened this task as Open.Jul 13 2015, 11:25 AM

Reopening because of the issue introduced in https://gerrit.wikimedia.org/r/#/c/223660/ and solved in https://gerrit.wikimedia.org/r/#/c/224060/.

thiemowmde moved this task from Done to Review on the Wikidata-Sprint-2015-06-30 board.Jul 13 2015, 11:25 AM
hoo added a comment.Jul 13 2015, 11:53 AM

Can we please not repurpose tickets?

thiemowmde added a comment.EditedJul 13 2015, 12:14 PM

I'm sorry, but I do not understand. This task is not done. It does not work. I do not consider this repurposing if a bug is introduced while working on the same ticket. Otherwise we would have a never ending chain of tickets if we agreed on opening new tickets for every single mistake and are not allowed to have more than one patch in one ticket.

hoo renamed this task from ResourceLoader modules no longer depend on ULS after conversion to extension registration to ResourceLoader modules dynamically generated by "ResourceLoaderRegisterModules" hook handlers don't work in debug mode.Jul 13 2015, 4:18 PM
hoo lowered the priority of this task from Unbreak Now! to Medium.
hoo updated the task description. (Show Details)
thiemowmde raised the priority of this task from Medium to Unbreak Now!.Jul 13 2015, 5:23 PM

Wikibase is broken and the UI unusable because of https://gerrit.wikimedia.org/r/#/c/224060/ not being merged.

thiemowmde added a parent task: T105717: Unbreak broken dynamic ResourceLoader module loading.Jul 13 2015, 6:01 PM
gerritbot added a comment.Jul 13 2015, 6:21 PM

Change 224060 merged by jenkins-bot:
Fix broken localBasePath's in ResourceLoader::register calls

https://gerrit.wikimedia.org/r/224060

hoo mentioned this in rEWBA3cab8cfc2d12: Fix broken localBasePath's in ResourceLoader::register calls.Jul 13 2015, 6:21 PM
Diffusion mentioned this in rMEXT8b6df033fdab: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 13 2015, 6:22 PM
Tobi_WMDE_SW closed this task as Resolved.Jul 13 2015, 6:27 PM
Tobi_WMDE_SW subscribed.

closing again after fix was merged.

Tobi_WMDE_SW moved this task from Review to Done on the Wikidata-Sprint-2015-06-30 board.Jul 13 2015, 6:27 PM
gerritbot added a comment.Jul 13 2015, 7:05 PM

Change 224061 merged by jenkins-bot:
Add missing docs to ResourceLoaderRegisterModules hooks

https://gerrit.wikimedia.org/r/224061

thiemowmde mentioned this in rMEXT073cb25ea309: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 13 2015, 7:05 PM
hoo mentioned this in rEWBAce0305da6898: Add missing docs to ResourceLoaderRegisterModules hooks.Jul 13 2015, 7:05 PM
matej_suchanek removed a project: Patch-For-Review.Jul 14 2015, 5:39 AM
matej_suchanek removed a subscriber: gerritbot.
gerritbot added a comment.Jul 14 2015, 1:08 PM

Change 224063 merged by Addshore:
Reformat dynamic ResourceLoader::register calls for readability

https://gerrit.wikimedia.org/r/224063

thiemowmde mentioned this in rMEXTca654ea770f7: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 14 2015, 1:08 PM
Addshore mentioned this in rEWBAca93cc9740c8: Reformat dynamic ResourceLoader::register calls for readability.Jul 14 2015, 1:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL