Page MenuHomePhabricator

BarryTheBrowserTestBot (and relatives) spamming Phabricator Paste application with blank pastes
Closed, ResolvedPublic

Description

It looks like @BarryTheBrowserTestBot is spamming the Phabricator Paste application with blank pastes. Example pastes: P1617, P1616, P1615, etc.

Event Timeline

MZMcBride raised the priority of this task from to Unbreak Now!.
MZMcBride updated the task description. (Show Details)
MZMcBride added a project: Phabricator.
Restricted Application added subscribers: scfc, Aklapper. · View Herald TranscriptJul 31 2015, 5:23 AM

It would also be helpful if https://phabricator.wikimedia.org/p/BarryTheBrowserTestBot/ had some contact information.

Same with @Frankiebot, whoever runs that...P1439.

greg renamed this task from BarryTheBrowserTestBot spamming Phabricator Paste application with blank pastes to BarryTheBrowserTestBot (and relatives) spamming Phabricator Paste application with blank pastes.Jul 31 2015, 8:30 PM
greg added projects: Mobile, Readers-Web-Backlog.
greg set Security to None.
greg assigned this task to Jdlrobson.Jul 31 2015, 8:41 PM
greg added a subscriber: greg.

This isn't really an issue with Phabricator (unless others see non-BarryTheBrowserTestBot/derivatives doing it). Removing that project.

Also, assigning to @Jdlrobson, it's his/his team's code.

bmansurov added a comment.EditedJul 31 2015, 9:37 PM

It's been more than an hour since the last paste (https://phabricator.wikimedia.org/P1807). Safe to say that all bots have been temporarily killed. The next paste is still empty. https://phabricator.wikimedia.org/P1808

Jdlrobson closed this task as Resolved.Jul 31 2015, 10:11 PM

It was a rogue process that I killed an hour ago that shouldn't have been running using some old code.
For future you can raise issues here - https://github.com/jdlrobson/Barry-the-Browser-Test-Bot

Out of interest, any process/things we can learn for this going forward? Should there be a rate limit on the api? Protection against empty pastes? Some way of notifying the bot (any e-mails to him would go to mailbox)?

Given that we have multiple bots now, we should definitely link back to the patch so that we know which repo the bot is watching. Also, no empty pastes is a good idea.

Empty pastes should only occur if the script has been setup incorrectly. I'm adding further protection as we speak. Please raise an issue on https://github.com/jdlrobson/Barry-the-Browser-Test-Bot/issues for providing link backs - that seems like a good idea.

chasemp added a subscriber: chasemp.EditedJul 31 2015, 10:59 PM

Ideally the user doing this would be a bot in phabricator and would show up here https://phabricator.wikimedia.org/people/query/HIYqhD_44QzG/#R. I saw this outside of this task and disabled the user mainly because our policy has been to disable users that exhibit bot like behavior but are not known to be bots.

I re-enabled the user and asked for contact info to be added which I see @MZMcBride asked for as well. Thanks to @Jdlrobson

Can I delete pastes for the bot up to this point to clean them up? This bot has created 727 pastes to this point.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptOct 13 2016, 9:18 AM