Flow CAPTCHA integration broken
Closed, ResolvedPublic
Actions

Description

Locally, it gives:

Argument 1 passed to SimpleCaptcha::getForm() must be an instance of OutputPage, undefined variable given

In production, it gives a completely blank response, but it's probably the same thing.

To trigger, can use the following as an anonymous editor on MediaWiki.org:

[http://google.com Google]

[http://example.com]

http://foo.com

Details

	Subject	Repo	Branch	Lines +/-
	Follow up ConfirmEdit change of SimpleCaptcha::getForm()	mediawiki/extensions/Flow	wmf/1.26wmf17	+1 -1
	Follow up ConfirmEdit change of SimpleCaptcha::getForm()	mediawiki/extensions/Flow	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ori	T108197 Blockers for 1.26wmf18 (released on 2015-08-11)
		Resolved		Florian	T108145 Flow CAPTCHA integration broken

Event Timeline

• Mattflaschen-WMF created this task.Aug 6 2015, 3:05 AM

• Mattflaschen-WMF raised the priority of this task from to Needs Triage.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added projects: StructuredDiscussions, ConfirmEdit (CAPTCHA extension).

• Mattflaschen-WMF subscribed.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 6 2015, 3:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Mattflaschen-WMF triaged this task as Unbreak Now! priority.Aug 6 2015, 3:05 AM

• Mattflaschen-WMF added a project: Collaboration-Team-Archive-2015-2016.

FYI: This task is considered a blocker for the upcoming (August 11th) train deployment to WMF wikis. If this task is not fixed before then I will have to hold the train.

Florian claimed this task.Aug 6 2015, 4:26 PM

Change 229745 had a related patch set uploaded (by Florianschmidtwelzow):
Follow up ConfirmEdit change of SimpleCaptcha::getForm()

https://gerrit.wikimedia.org/r/229745

gerritbot added a project: Patch-For-Review.Aug 6 2015, 4:37 PM

greg added a parent task: T108197: Blockers for 1.26wmf18 (released on 2015-08-11).Aug 6 2015, 4:37 PM

Florian moved this task from Backlog to Awaiting Code Review on the ConfirmEdit (CAPTCHA extension) board.Aug 6 2015, 4:41 PM

SBisson moved this task from Untriaged to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Aug 6 2015, 5:09 PM

Restricted Application added a subscriber: Florian. · View Herald TranscriptAug 6 2015, 5:09 PM

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Aug 6 2015, 5:38 PM

Change 229745 merged by jenkins-bot:
Follow up ConfirmEdit change of SimpleCaptcha::getForm()

https://gerrit.wikimedia.org/r/229745

Florian mentioned this in rMEXT5cf90f9f5c45: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Aug 6 2015, 5:40 PM