Highlighting broken in complicated templates
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	Aug 8 2015, 8:29 AM

Description

Example code from https://de.wikipedia.org/wiki/Vorlage:NaviBlock:

<onlyinclude><includeonly><div class="BoxenVerschmelzen">
{{#switch:{{padleft:|1|{{{1|}}}}}|<|[={{{1}}}|#default={{#if:{{{1|}}}|{{{{{1}}}}}}}{{#if:{{{2|}}}|{{{{{2}}}}}|<div style="display:none;">[[Vorlage:NaviBlock/Wartung/nur ein Element| ]]</div>}}{{#if:{{{3|}}}|{{{{{3}}}}}}}{{#if:{{{4|}}}|{{{{{4}}}}}}}{{#if:{{{5|}}}|{{{{{5}}}}}}}{{#if:{{{6|}}}|{{{{{6}}}}}}}{{#if:{{{7|}}}|{{{{{7}}}}}}}{{#if:{{{8|}}}|{{{{{8}}}}}}}{{#if:{{{9|}}}|{{{{{9}}}}}}}{{#if:{{{10|}}}|{{{{{10}}}}}}}{{#if:{{{11|}}}|{{{{{11}}}}}}}{{#if:{{{12|}}}|{{{{{12}}}}}}}{{#if:{{{13|}}}|{{{{{13}}}}}}}{{#if:{{{14|}}}|{{{{{14}}}}}}}{{#if:{{{15|}}}|{{{{{15}}}}}}}{{#if:{{{16|}}}|{{{{{16}}}}}}}{{#if:{{{17|}}}|{{{{{17}}}}}}}{{#if:{{{18|}}}|{{{{{18}}}}}}}{{#if:{{{19|}}}|{{{{{19}}}}}}}{{#if:{{{20|}}}|{{{{{20}}}}}}}{{#if:{{{21|}}}|<div class="error">Zu viele Navigationsleisten</div>}}}}
</div></includeonly></onlyinclude>
{{Dokumentation}}

There are many unhighlighted }}, though they do match correctly.
In {{#if:{{{5|}}}|{{{{{5}}}}}}}
^^^^^^ ^^ this is the parser function
^^^^^^^^ ^^^^^^^ these are parameters
^^ ^^ this is a template transclusion

Highlighting a complicated, but correct template wrongly makes editing even harder than without highlighting.

Details

	Subject	Repo	Branch	Lines +/-
	Much more robust detection of template {{{variables}}}	mediawiki/extensions/CodeMirror	master	+4 -2
	fix highlighting parameters inside a template transclusion (v 3.2.1)	mediawiki/extensions/CodeMirror	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Pastakhov	T108450 Highlighting broken in complicated templates
		Open		Bhsd	T109822 Create wikitext tokenizer with rules identical to Parser of MW Core

Event Timeline

Schnark created this task.Aug 8 2015, 8:29 AM

Schnark raised the priority of this task from to Needs Triage.

Schnark updated the task description. (Show Details)

Schnark added a project: MediaWiki-extensions-CodeMirror.

Schnark subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2015, 8:29 AM

Pastakhov claimed this task.Aug 20 2015, 4:06 AM

Pastakhov triaged this task as Medium priority.

Pastakhov set Security to None.

Change 232678 had a related patch set uploaded (by Pastakhov):
fix highlighting parameters inside a template transclusion (v 3.2.1)

https://gerrit.wikimedia.org/r/232678

gerritbot added a project: Patch-For-Review.Aug 20 2015, 4:32 AM

test http://test.foxway.org/w/index.php?title=Sandbox:T108450&action=edit

Florian subscribed.Aug 20 2015, 10:53 PM

Change 232678 merged by jenkins-bot:
fix highlighting parameters inside a template transclusion (v 3.2.1)

https://gerrit.wikimedia.org/r/232678

Diffusion mentioned this in rMEXT6f06efd7ba5d: Updated mediawiki/extensions Project: mediawiki/extensions/CodeMirror….Aug 21 2015, 5:21 AM

Pastakhov mentioned this in rECMI991be295003f: fix highlighting parameters inside a template transclusion (v 3.2.1).Aug 21 2015, 5:21 AM

This is not a complete solution of the problem, but I don't know whether to spend my time on it,

In T95041#1558795, @kaldari wrote:

... since the Editing team will be working on its own solution to syntax highlighting at some point ...

Pastakhov mentioned this in T109822: Create wikitext tokenizer with rules identical to Parser of MW Core.Aug 21 2015, 10:38 AM

Pastakhov added a subtask: T109822: Create wikitext tokenizer with rules identical to Parser of MW Core.

I already linked it in T109822, but just to link it again: In https://de.wikipedia.org/wiki/Benutzer:Schnark/js/syntaxhighlight.js, I use the following solution, which isn't perfect, but works in all common and not-so-common cases. To split a sequence of { into templates and parameters, I divide them as follows:

2 = 2
3 = 3, except in {{{!}}, which is 1 + 2
4 = 2 + 2 (e.g. {{{{NAMESPACE}}:{{PAGENAME}}/Vorlage:Tabs|1}} in https://de.wikipedia.org/wiki/Portal:Computerspiele)
5 = 2 + 3 (e.g. example above), except in {{{{{#, which is 3 + 2 (e.g. {{{{{#switch: | bla | BLA=bla }}|}}} in https://de.wikipedia.org/wiki/Wikipedia:WikiProjekt_Vorlagen/Werkstatt/Archiv_2011/4 (nowiki'd there))
6 = 3 + 3 (e.g. {{{{{{1}}}}}} in https://de.wikipedia.org/wiki/Vorlage:Stammbaum)
7 or more is nothing you want to think about, but if you want to, look at https://en.wikipedia.org/wiki/Template:Hebrewmonth

Thanks for nice links ;-)

Pastakhov mentioned this in T171074: HTML comment next to a heading disables heading highlighting.Jul 20 2017, 4:53 AM

Niharika lowered the priority of this task from Medium to Low.Nov 7 2017, 11:57 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptNov 7 2017, 11:57 PM

Lucas_Werkmeister_WMDE subscribed.Jan 19 2018, 4:16 PM

• TBolliger moved this task from New & TBD Tickets to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.Feb 6 2018, 10:55 PM

• TBolliger added a parent task: T185030: Graduate Syntax Highlighting (CodeMirror) out of beta for non-RTL wikis on the 2010 wikitext editor.Mar 2 2018, 10:00 PM

• TBolliger moved this task from In Sprint 🏃‍♀️🏃‍♂️ to Needs Discussion on the Community-Tech board.Mar 2 2018, 10:03 PM

There may be room for improvements, but the problem outlined in this ticket is fixed on production.

Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Mar 7 2018, 12:31 AM

• TBolliger removed a parent task: T185030: Graduate Syntax Highlighting (CodeMirror) out of beta for non-RTL wikis on the 2010 wikitext editor.Mar 20 2018, 9:41 PM

Change 975767 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/CodeMirror@master] Much more robust detection of template {{{variables}}}

https://gerrit.wikimedia.org/r/975767

Change 975767 merged by jenkins-bot: