Page MenuHomePhabricator

HTML comment next to a heading disables heading highlighting
Open, LowPublic3 Estimate Story Points


If an HTML comment is on either side of a heading, the heading won't get highlighted and the size won't change.

Watch this GIF and you will understand:

Event Timeline

kaldari created this task.Jul 19 2017, 5:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2017, 5:44 PM

There are two problems:

  1. font size can be changed only for whole line and big comments looks ugly for me.
  2. processing comments required some optimizations of tokenizer, it should be able to change type of previous tokens without processing all next tokens again.

For the first point we should choose:

  • make a heading the same size as usual text
  • make comments the same size as a heading
  • make a heading with inline comments the same size as usual text

The second point requires the same solution as for complicated templates T108450 and touches T109822

DannyH added a subscriber: DannyH.Jul 25 2017, 9:41 PM

I talked this over with @kaldari and @Niharika -- I don't want to break a useful feature (size changes on the heading) just to fix an edge case.

When there's a heading with inline comments, we should make the whole line the size of a heading. That gives us occasional big comments, but if the comment is on the same line as the heading then it's probably important.

In the translation use case from the GIF, having a big <!--T:5--> next to the heading would probably help -- you'd be able to tell which translate tags are connected to headings, and which aren't. The translate feature is ugly and confusing; this would be just as ugly but maybe a little less confusing.

Kbrown added a subscriber: Kbrown.Aug 3 2017, 10:48 PM
DannyH triaged this task as Low priority.Sep 19 2017, 10:45 PM
DannyH set the point value for this task to 3.
DannyH moved this task from To Be Estimated/Discussed to Estimated on the Community-Tech board.