Page MenuHomePhabricator

[RFC] Create a new Wikibase-Change-Services component
Closed, DeclinedPublic1 Story Points

Description

I'm proposing a new #Wikibase-Change-Services component, similar to (but independent from) the recent Wikibase-DataModel-Services component (see T93741: [RFC] Create place to put common Wikibase services for that).

#Wikibase-Change-Services depends on:

It can, obviously, not depend on MediaWiki, Wikibase Client, Lib and/or Repo.

#Wikibase-Change-Services contains, for a start:

  • \Wikibase\Summary
  • \Wikibase\SummaryFormatter
  • \Wikibase\ClaimSummaryBuilder
  • I want to move some Change/Changers/ChangeOp stuff there.
  • (to be continued)

Event Timeline

thiemowmde claimed this task.
thiemowmde raised the priority of this task from to High.
thiemowmde updated the task description. (Show Details)
thiemowmde added a project: Wikidata.
thiemowmde added a subscriber: thiemowmde.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2015, 1:36 PM
Tobi_WMDE_SW renamed this task from Create a new Wikibase-Change-Services component to Proposal: Create a new Wikibase-Change-Services component.Aug 11 2015, 2:02 PM
Tobi_WMDE_SW set Security to None.
Tobi_WMDE_SW edited a custom field.
Bene added a subscriber: Bene.Aug 11 2015, 8:26 PM

This thing sounds like it will depend on all of the same things that DataModelServices currently does!

The I feel the ideal situation (though maybe not the one we are going for here) would be to included the generation of summaries in DMServices. Diffs would be taken between 2 versions of an entity and then a summary be created from that diff. Though as I said previously this is more than T101836 is asking for.

If the scope of this (sub)component is "all the changes stuff", then DataModelServices does not seem like a viable location due to dependencies. There will be presentation things in there and need for stuff such as i18n. Presumably it'd also need to know about specific data values, which is something DMS does not.

Bene added a comment.Aug 12 2015, 11:37 AM

If it needs i18n, would that component depend on MediaWiki? Would it be a standalone extension then? We haven't really figured out yet how to deal with possible subcomponents that need parts of MediaWiki.

It would be really nice to have all of the language stuff factored out of core and into a library.
I had a little chat with @Legoktm about it and apparently it would be very hard (even if I can see multiple uses of it for us here and in other parts of our code)

Indeed if this stuff needs to rely on mediawiki stuff then it should be somewhere else...

I have created a little component to wrap the MW i18n stuff for some extension where I wanted my code to not rely on global state and bind to MW. It's far from a full wrapper though, and I'm not convinced that creating a full one makes sense, which includes concerns about the difficulty of creation. Anyway, this might still be of interest:

https://github.com/JeroenDeDauw/i18n

Jonas renamed this task from Proposal: Create a new Wikibase-Change-Services component to [RFC] Create a new Wikibase-Change-Services component.Aug 13 2015, 10:57 AM
Lydia_Pintscher lowered the priority of this task from High to Normal.Aug 17 2015, 2:56 PM
Lydia_Pintscher added a subscriber: Lydia_Pintscher.
thiemowmde closed this task as Declined.Wed, Oct 2, 9:24 AM
thiemowmde removed thiemowmde as the assignee of this task.