Page MenuHomePhabricator

Stop running the UploadWizard API smoke tests in production
Closed, ResolvedPublic

Description

We have an hourly smoke test to ensure UploadWizard runs properly on commons.wikimedia.org https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/

It uses the 'Selenium_user' account and apparently has been blocked:

APIError: (u'blocked', u'You have been blocked from editing')

Event Timeline

hashar raised the priority of this task from to Unbreak Now!.
hashar updated the task description. (Show Details)
hashar subscribed.
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript

From the block log:

08:59, 14 October 2015 Multichill (talk | contribs) blocked Selenium user (talk | contribs) with an expiry time of indefinite (autoblock disabled) (Unauthorized bot uploading junk)

Maarten, we would need that block to be lifted :-D

@Steinsplitter kindly unblocked the bot. From the admin board:

I just unblocked the user per https://phabricator.wikimedia.org/T115465 . Can you please use {{tl|Test upload}} on the file (white in the information template) and we should probably rename the account to [[User:Selenium user (WMF QA bot)]] per suggestion on AN.
--[[User:Steinsplitter|Steinsplitter]] ([[User talk:Steinsplitter|<span class="signature-talk">{{int:Talkpagelinktext}}</span>]]) 13:24, 14 October 2015 (UTC)

hashar claimed this task.

Following the unblock, the job is passing again. I filled follow up task T115469: Adjust UploadWizard API test suite to match commons.wikimedia.org policy for bots to adjust the suite and match commons.wikimedia.org policy.

Ah, the mysterious operator is Hashar! Another case where the peep system worked. I'll follow up in the other bug.

@Multichill Yup the job has been created a while back to ensure UploadWizard is working properly. We had some awkward issues that caused much havoc for commons users. The job pretty much guarantee UploadWizard works as attended and is taken care of by Release-Engineering-Team + Multimedia (if that later team still exists).

From QA list https://lists.wikimedia.org/pipermail/qa/2015-October/002411.html

Zeljko confirmed on the Commons village pump that we were no more using the 'Selenium User': https://commons.wikimedia.org/w/index.php?title=Commons%3AVillage_pump&type=revision&diff=175068085&oldid=175058874

That stands true for browser tests, but we missed the UploadWizard suite which is a different kind of job.

So blocking the user was definitely the correct course of action and that has let us identify the source of the junk files.

Why isn't it running on the Beta Cluster?

Why isn't it running on the Beta Cluster?

There is one on the beta cluster: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/

But we need one to run against production to make sure it is definitely working on prod as well. It is more like a monitoring system.

Why isn't it running on the Beta Cluster?

There is one on the beta cluster: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/

But we need one to run against production to make sure it is definitely working on prod as well. It is more like a monitoring system.

I disagree. If we can't use Beta Cluster / Staging to tell us whether the code works, we need to improve staging. :-) Making changes to the production site to prove it works isn't something we allow for e.g. edits, and shouldn't be allowed for uploads.

Making changes to the production site to prove it works isn't something we allow for e.g. edits, and shouldn't be allowed for uploads.

Yes we do... https://en.wikipedia.org/wiki/Special:Contributions/Ops_Monitor_%28WMF%29

I disagree. If we can't use Beta Cluster / Staging to tell us whether the code works, we need to improve staging. :-) Making changes to the production site to prove it works isn't something we allow for e.g. edits, and shouldn't be allowed for uploads.

It is not only about validating the code and API entry point, but also validating that the stashing and object storage backend (Swift) honors the requests.

I have reblocked the account. The account is still editing for some days now. The account can be unblocked when the bugs are fixed.

Steinsplitter set Security to None.

Surely blocking the user again is a constructive way to prioritize the work that needs to be done on T115469 ? I give up, I have better things to do.

Since the user has been blocked once again despite my explanations of its use and after two years of good use, the probe will start sending notifications to multimedia-alerts@lists.wikimedia.org.

I am letting the Multimedia and Contributors-Team deal with this task and the sub task T115469 cause there are some social issues I refuse to be involved in.

I agree with James that we shouldn't be running tests in production.

Surely blocking the user again is a constructive way to prioritize the work that needs to be done on T115469 ? I give up, I have better things to do.

I unblocked the bot, so i am responsible (i am not that one who blocked the bot the first time). The bot can run again when stuff is fixed. I am very sorry... but blocking malfunctioning bots until they are fixed is standard practice.

Surely blocking the user again is a constructive way to prioritize the work that needs to be done on T115469 ? I give up, I have better things to do.

Since the user has been blocked once again despite my explanations of its use and after two years of good use, the probe will start sending notifications to multimedia-alerts@lists.wikimedia.org.

I am letting the Multimedia and Contributors-Team deal with this task and the sub task T115469 cause there are some social issues I refuse to be involved in.

No. I am the Multimedia Team and the Editing Department. I have already told you to switch this off, and that we do not agree with it running. You have refused, claiming that Operations need it to verify that Swift works in production. That makes it your problem, or theirs. Please fix it by stopping this task.

Jdforrester-WMF renamed this task from UploadWizard API smoke tests falling because Selenium_user has been blocked on commons.wikimedia.org to Stop running the UploadWizard API smoke tests in production.Oct 21 2015, 3:55 PM
Jdforrester-WMF assigned this task to hashar.

Per @Jdforrester-WMF in -releng: "We decided that we definitely wanted it deleted this morning at the team meeting."

Let's delete it :)

Change 247895 had a related patch set uploaded (by Greg Grossmeier):
Remove the UploadWizard API test from production

https://gerrit.wikimedia.org/r/247895

The job is gone now. Thank you @Jdforrester-WMF for the clarification.

I will decline the sub task T115469: Adjust UploadWizard API test suite to match commons.wikimedia.org policy for bots  which is no more needed.

Change 247895 merged by jenkins-bot:
Remove the UploadWizard API test from production

https://gerrit.wikimedia.org/r/247895