Page MenuHomePhabricator
Create Task
Maniphest T116485

Echo should not notify the user about his own linking activity
Closed, ResolvedPublic
Actions

Description

I created
https://www.wikidata.org/wiki/Q21189110
and then added it as a reference in
https://www.wikidata.org/wiki/Q1755242?diff=261936402

This caused an email notification for myself saying "Q21189110 was linked from Q1755242".
I only want to be notified when other users link to one of the pages I created.

This bug occurred for many of my recent edits on Wikidata.

Also reported at: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Notifications

Details

SubjectRepoBranchLines +/-
LinksUpdate: Keep track of the triggering Usermediawiki/corewmf/1.27.0-wmf.4+48 -3
Fix page-linked notificationsmediawiki/extensions/Echowmf/1.27.0-wmf.4+10 -2
Fix page-linked notificationsmediawiki/extensions/Echomaster+10 -2
LinksUpdate: Keep track of the triggering Usermediawiki/coremaster+48 -3
Customize query in gerrit

Related Objects

Event Timeline

He7d3r created this task.Oct 24 2015, 4:51 PM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added projects: Notifications, Wikidata.
He7d3r subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 24 2015, 4:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sjoerddebruin added a project: Regression.Oct 25 2015, 2:53 PM
Sjoerddebruin subscribed.
He7d3r added a comment.Oct 25 2015, 9:16 PM

Same problem for this edit on Wikipedia:
https://pt.wikipedia.org/w/index.php?diff=43741618
where I linked
https://pt.wikipedia.org/wiki/Anel_quase_comutativo
to
https://pt.wikipedia.org/wiki/%C3%81lgebra_de_Weyl

Legoktm triaged this task as High priority.Oct 26 2015, 4:21 PM
Legoktm updated the task description. (Show Details)
Legoktm set Security to None.
Legoktm claimed this task.Oct 26 2015, 5:37 PM
Legoktm edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
• Mattflaschen-WMF merged a task: T116769: regression: "Page link" notification appears for link added by the article creator .Oct 27 2015, 3:55 PM
• Mattflaschen-WMF added a subscriber: Kipod.
IKhitron subscribed.Oct 27 2015, 3:58 PM
Sjoerddebruin moved this task from incoming to monitoring on the Wikidata board.Oct 27 2015, 4:26 PM
Legoktm added a comment.Oct 27 2015, 9:02 PM

The LinksUpdateAfterInsert hook that echo depended upon is now being deferred so $wgUser is wrong.

Legoktm added a subscriber: aaron.Oct 27 2015, 9:04 PM

I'm guessing rMW1846e2dc15e9: Made LinksUpdate on edit use the job queue caused this.

gerritbot subscribed.Oct 27 2015, 9:50 PM

Change 249302 had a related patch set uploaded (by Legoktm):
LinksUpdate: Keep track of the triggering User

https://gerrit.wikimedia.org/r/249302

gerritbot added a project: Patch-For-Review.Oct 27 2015, 9:50 PM
gerritbot added a comment.Oct 27 2015, 11:17 PM

Change 249318 had a related patch set uploaded (by Legoktm):
Fix page-linked notifications

https://gerrit.wikimedia.org/r/249318

Catrope moved this task from Untriaged to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Oct 28 2015, 12:07 AM
gerritbot added a comment.Oct 28 2015, 1:31 AM

Change 249302 merged by jenkins-bot:
LinksUpdate: Keep track of the triggering User

https://gerrit.wikimedia.org/r/249302

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Oct 28 2015, 1:37 AM
gerritbot added a comment.Oct 28 2015, 1:37 AM

Change 249318 merged by jenkins-bot:
Fix page-linked notifications

https://gerrit.wikimedia.org/r/249318

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Oct 28 2015, 2:00 AM
gerritbot added a comment.Oct 28 2015, 5:24 AM

Change 249350 had a related patch set uploaded (by Legoktm):
LinksUpdate: Keep track of the triggering User

https://gerrit.wikimedia.org/r/249350

gerritbot added a comment.Oct 28 2015, 5:24 AM

Change 249351 had a related patch set uploaded (by Legoktm):
Fix page-linked notifications

https://gerrit.wikimedia.org/r/249351

Legoktm added a comment.Oct 28 2015, 5:35 AM

I've scheduled backports to wmf4 during tomorrow morning's SWAT. It depends on some code that isn't in wmf3, so it'll be fixed on Wikipedias during Thursday's train deploy.

gerritbot added a comment.Oct 28 2015, 3:25 PM

Change 249350 merged by jenkins-bot:
LinksUpdate: Keep track of the triggering User

https://gerrit.wikimedia.org/r/249350

gerritbot added a comment.Oct 28 2015, 3:26 PM

Change 249351 merged by jenkins-bot:
Fix page-linked notifications

https://gerrit.wikimedia.org/r/249351

Legoktm closed this task as Resolved.Oct 28 2015, 3:43 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 28 2015, 4:00 PM
Etonkovidova subscribed.Oct 28 2015, 10:15 PM

Checked in betalabs.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Oct 28 2015, 10:15 PM
Legoktm merged a task: T117010: Notifications on added links should exclude links made by the user herself .Oct 29 2015, 1:25 AM
Legoktm added subscribers: Legoktm, jeblad.
Tgr mentioned this in T203356: Sort out semantics of causeAgent and triggeringUser/triggeringRevisionId.Sep 2 2018, 2:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL