Page MenuHomePhabricator
Create Task
Maniphest T119588

Git hashes for SyntaxHighlight_GeSHi not recognised in Phabricator (due to Pygments fork repo import)
Closed, ResolvedPublic
Actions

Description

See https://phabricator.wikimedia.org/T78733#1177577

Relevant:

The first two are from mediawiki/extensions/SyntaxHighlight_GeSHi and render as plain text instead of a link.

They exist in Gerrit at:

Related Objects

Event Timeline

Krinkle created this task.Nov 25 2015, 1:05 AM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added a project: Phabricator.
Krinkle subscribed.
Restricted Application added subscribers: StudiesWorld, scfc, Aklapper. · View Herald TranscriptNov 25 2015, 1:05 AM
Krenair subscribed.Nov 25 2015, 2:20 AM
Krenair added a comment.Nov 25 2015, 2:23 AM

rESHG7a46e84d69a3: ResourceLoaderGeSHiModule: Cache file mtime of __FILE__
rESHG7a46e84d69a3: ResourceLoaderGeSHiModule: Cache file mtime of __FILE__

rESHG4ebdd607f5de: ResourceLoaderGeSHiModule: Use GESHI_VERSION instead of file mtime
rESHG4ebdd607f5de: ResourceLoaderGeSHiModule: Use GESHI_VERSION instead of file mtime

You just have to prepend the rESHG for some reason

greg subscribed.Nov 25 2015, 3:50 PM

Weird, why the difference in behavior?

Krinkle added a comment.Nov 27 2015, 3:11 PM
In T119588#1831581, @greg wrote:

Weird, why the difference in behavior?

Figured it out. The plain hash is ambiguous in Phabricator because there is a fork of the SyntaxHighlight_GeSHi repo as SyntaxHighlight_Pygments. It has since been archived, but it did get imported to Phabricator.

Gerrit doesn't have duplicate entries of the commits as Gerrit only is aware of changed reviewed/merged through its system. So it only has commits in the Pygments repo from after the repos diverged. The ones from before are exclusively indexed as belonging to the Geshi repo.

rESHG7a46e84d69a3: ResourceLoaderGeSHiModule: Cache file mtime of __FILE__
rESHG7a46e84d69a3: ResourceLoaderGeSHiModule: Cache file mtime of __FILE__

also {rESHP7a46e84d69a3c912ba9e3c19c0943dba13026ae3}

rESHG4ebdd607f5de: ResourceLoaderGeSHiModule: Use GESHI_VERSION instead of file mtime
rESHG4ebdd607f5de: ResourceLoaderGeSHiModule: Use GESHI_VERSION instead of file mtime

also {rESHP4ebdd607f5de4fbdf2cfba732452c4df239847c8}

Let's nuke that repo?

Aklapper renamed this task from Git hashes for mediawiki/extensions/SyntaxHighlight_GeSHi not recognised in Phabricator to Git hashes for SyntaxHighlight_GeSHi not recognised in Phabricator (due to Pygments fork repo import).Jan 20 2016, 12:53 PM
Aklapper triaged this task as Low priority.
Aklapper set Security to None.
Aklapper added a subscriber: • demon.
Restricted Application added a subscriber: Luke081515. · View Herald TranscriptJan 20 2016, 12:53 PM
Aklapper added a comment.Jan 20 2016, 12:53 PM
In T119588#1835165, @Krinkle wrote:

Let's nuke that repo?

+1 if that has no other side effects.

Paladox moved this task from To Triage to Misc on the Phabricator board.Sep 6 2016, 11:33 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptSep 6 2016, 11:33 AM
• mmodell subscribed.Feb 14 2019, 8:31 PM

So which repo should we nuke?

Krinkle added a comment.EditedFeb 14 2019, 8:34 PM

mediawiki/extensions/SyntaxHighlight_Pygments, which was created and only used for a very short time before we realised the mistake and then archived it again.

Due to this bad repo, and the correct one (_GeSHi) both existing in Phab, all commits that exist in both repo's history are ambiguous to Phab, and thus not linked. All commits between 2009 and 2017 are affected, despite the bad repo only having been used for a month, this is because we imported the Git history at the time (proper fork).

Aklapper added a project: Diffusion-Repository-Administrators.EditedJun 8 2023, 1:21 PM

This requires a member of Diffusion-Repository-Administrators to go to https://phabricator.wikimedia.org/diffusion/ESHP/manage/ and delete. I do not have permissions.

Aklapper closed this task as Resolved.Jun 8 2023, 4:47 PM
Aklapper claimed this task.
Aklapper added a project: Release-Engineering-Team (They Live 🕶️🧟).

Resolved by deleting that repository:

aklapper@phab1004:~$ sudo /srv/phab/phabricator/bin/remove destroy rESHP

This object will be destroyed forever:

    - rESHP (PhabricatorRepository) rESHP mediawiki/extensions/SyntaxHighlight_Pygments

    Are you absolutely certain you want to destroy this object? [y/N] y

Destroying objects...
Destroying PhabricatorRepository rESHP...
[2023-06-08 16:40:41] EXCEPTION: (Exception) Unknown edge constant "25"! at [<phabricator>/src/infrastructure/edges/type/PhabricatorEdgeType.php:214]
arcanist(), ava(), phabricator(), translations(), wmf-ext-misc()
  #0 <#2> PhabricatorEdgeType::getByConstant(string) called at [<phabricator>/src/infrastructure/edges/editor/PhabricatorEdgeEditor.php:179]
  #1 <#2> PhabricatorEdgeEditor::buildEdgeSpecs(string, string, string) called at [<phabricator>/src/infrastructure/edges/editor/PhabricatorEdgeEditor.php:78]
  #2 <#2> PhabricatorEdgeEditor::removeEdge(string, string, string) called at [<phabricator>/src/infrastructure/edges/engineextension/PhabricatorEdgesDestructionEngineExtension.php:32]
  #3 phlog(Exception) called at [<phabricator>/src/infrastructure/edges/engineextension/PhabricatorEdgesDestructionEngineExtension.php:39]
  #4 PhabricatorEdgesDestructionEngineExtension::destroyObject(PhabricatorDestructionEngine, PhabricatorRepository) called at [<phabricator>/src/applications/system/engine/PhabricatorDestructionEngine.php:88]
  #5 PhabricatorDestructionEngine::destroyObject(PhabricatorRepository) called at [<phabricator>/src/applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php:158]
  #6 PhabricatorSystemRemoveDestroyWorkflow::execute(PhutilArgumentParser) called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:492]
  #7 PhutilArgumentParser::parseWorkflowsFull(array) called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:377]
  #8 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/setup/manage_remove.php:21]
Permanently destroyed 1 object.
      - Database records for repository "rESHP" were destroyed, but this
        script does not remove working copies on disk. If you also want to
        destroy the repository working copy, manually remove
        "/srv/repos/ESHP/".

Exception shown 63 times thus edited for readability; underlying issue is https://we.phorge.it/T15125

RhinosF1 subscribed.Jun 8 2023, 4:50 PM
thcipriani moved this task from Backlog to Done on the Release-Engineering-Team (They Live 🕶️🧟) board.Jun 9 2023, 1:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL