From T120383#1871587:
I don't understand how this code hopes to work in the world where #makeRestbaseCheckRequest fails because the server's dead, or not configured, or Mathoid is down, or… — what exactly is meant to return "details" and "error" if there's no response?
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make math usable without RESTbase | mediawiki/extensions/Math | master | +53 -15 |
This means, amongst other things, that you can't view/edit Math nodes on our private wikis, as you get
[2732f3d0] 2015-12-11 00:07:05: Fatal exception of type "MWException"
… or similar.
No. That's a relatively minor issue compared to all the third parties whose wikis you will break with this change.
This goes back to
https://gerrit.wikimedia.org/r/#/c/255950/
where we made the extension explicitly restbase dependent.
If that's not the way we want to go, we can also make the extension require restbase or texvccheck, or disable checks.
I think most reasonable for users, is only one dependency to a service that does the math rendering.
I think restbase is most suitable since, it can be used for other things as well.
Note that the math extension did depend on something ever since.
Change 258426 had a related patch set (by Physikerwelt) published:
Make math usable without RESTbase
Here the IRC conversation with @GWicke https://gist.github.com/physikerwelt/76db1b066d06228be74f
Lowering the priority since it does not affect WMF-run public wikis and work is in progress on this.
<physikerwelt____> hoo: What exactly do you mean by usable?
<hoo_> Save values, display them (no matter how rudimentary)
We could fall back to source rendering mode.