Page MenuHomePhabricator

Cursor gets "stuck" when down-arrowing from the start of a link which spans a page beginning/end
Open, HighPublic8 Story Points

Description

Steps to reproduce:

  1. Open a page that contains a lot of links, like https://en.wikipedia.org/wiki/Sterile_insect_technique?veaction=edit (It might help to zoom in a bit).
  2. Press the down arrow until you encounter a link at the beginning of a line.
  3. Huh, you're stuck.

Workaround: Press another arrow key to get free.

Event Timeline

Whatamidoing-WMF updated the task description. (Show Details)
Whatamidoing-WMF raised the priority of this task from to Needs Triage.
Whatamidoing-WMF added a project: VisualEditor.
Whatamidoing-WMF added a subscriber: Whatamidoing-WMF.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 10 2016, 6:14 PM
Elitre added a subscriber: Elitre.Feb 10 2016, 6:15 PM
Jdforrester-WMF renamed this task from Cursor gets "stuck" when down-arrowing through some links to Cursor gets "stuck" when down-arrowing from the start of a link which spans a page beginning/end.Feb 16 2016, 8:21 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.

Change 281456 had a related patch set uploaded (by DLynch):
Give the active link annotation inline-block

https://gerrit.wikimedia.org/r/281456

dchan added a subscriber: dchan.Jun 8 2016, 2:45 PM

On examination, we think this is due to https://bugs.chromium.org/p/chromium/issues/detail?id=618318 , which also affects Safari (but not Firefox).

Change 281456 abandoned by DLynch:
Give the active link annotation inline-block

Reason:
This fixes some cases, but makes others worse. Investigation with David Chan confirmed that this is arguably a WebKit browser bug (with Firefox having a similar-but-different one), and browser tickets have been created.

If we assume browsers won't fix it, we could perhaps approach this in the linear key handler, checking whether the selection hasn't changed when we think it should. (This is, of course, fragile. "Should the selection have changed?" is a complicated question, and we abdicate it to the browsers for a reason.)

https://gerrit.wikimedia.org/r/281456

I just encountered this bug whilst editing https://wikimania.wikimedia.org/wiki/Travel_guide#By_plane (in the long list of links to cities)

I made a test case page at https://www.mediawiki.org/w/index.php?title=User:Quiddity/sandbox&oldid=3083245&veaction=edit where you can reliably reproduce it by:

  • place your cursor anywhere in the word "test"
  • tap left-arrow until cursor is at the start of the paragraph
  • tap down-arrow 2 times.
  • only the first tap will work

Then I found this bug whilst starting to file a task. :-)
Notes in case useful.
Also upstream seems to be stalled and could maybe use a hint or nudge?