Page MenuHomePhabricator
Create Task
Maniphest T127664

Copying and pasting wikitext with refs results in the addition of a <references /> block
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Step to reproduce:
Copy this text from the German Wikipedia, and paste it into VisualEditor:

England gelang zwar sechs Minuten später durch einen von [[Allan Clarke (Fußballspieler)|Allan Clarke]] verwandelten Elfmeter der Ausgleich, mehr ließen die Polen, insbesondere ihr Torhüter [[Jan Tomaszewski]] - der kurz zuvor von [[Brian Clough]] als Clown tituliert wurde - nicht zu.<ref>[http://eu-football.info/_match.php?id=12071 eu-football.info: „Football MATCH: 17. Oktober 1973 England v Poland“]</ref> „It's all over“ wurde dies vom Kommentator des Spiels kommentiert.<ref>[https://www.youtube.com/watch?v=Vi9vZCo215w England 1-1 Poland (1973) WCQ ]</ref>

Expected result: The two sentences and their refs appear on the page.

Actual result: The two sentences and their refs and a new ref block appear on the page. See https://en.wikipedia.org/w/index.php?diff=706161685&oldid=706161369 or probably https://hy.wikipedia.org/w/index.php?diff=3925792&oldid=3925763

Screen Shot 2016-02-21 at 12.55.20 PM.png (296×1 px, 113 KB)

Details

SubjectRepoBranchLines +/-
Filter out auto-generated reference listsmediawiki/extensions/VisualEditormaster+22 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Whatamidoing-WMF created this task.Feb 21 2016, 9:00 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 21 2016, 9:00 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
• Whatamidoing-WMF mentioned this in T127665: Copying and pasting text and new refs from wikitext results in some old refs being inserted instead.Feb 21 2016, 9:09 PM
• Whatamidoing-WMF mentioned this in T127666: <references /> block should only show refs above it, not all refs on the page.Feb 21 2016, 9:15 PM
Jdforrester-WMF triaged this task as Low priority.Feb 22 2016, 10:09 PM
Jdforrester-WMF added a subtask: T113331: Provide an API flag to suppress auto-generated <references />.
Jdforrester-WMF added a project: VisualEditor-MediaWiki-References.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
ssastry closed subtask T113331: Provide an API flag to suppress auto-generated <references /> as Resolved.Mar 25 2016, 7:47 PM
Esanders closed this task as Resolved.Mar 26 2016, 10:35 PM
Esanders claimed this task.
Esanders subscribed.

This was fixed (slightly hackily) with https://gerrit.wikimedia.org/r/#/c/275193/

gerritbot subscribed.Mar 26 2016, 10:36 PM

Change 279730 had a related patch set uploaded (by Esanders):
Filter out auto-generated reference lists

https://gerrit.wikimedia.org/r/279730

gerritbot added a project: Patch-For-Review.Mar 26 2016, 10:36 PM
Esanders added a comment.Mar 26 2016, 10:38 PM

The above patch fixes this is a cleaner way, using the new attribute provided by Parsoid.

Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.Mar 29 2016, 5:08 PM
gerritbot added a comment.Mar 29 2016, 7:37 PM

Change 279730 merged by jenkins-bot:
Filter out auto-generated reference lists

https://gerrit.wikimedia.org/r/279730

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)); removed Patch-For-Review.Mar 31 2016, 7:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits