Page MenuHomePhabricator

Featured, etc. badges are not shown in the ULS panel in Compact Language Links
Closed, ResolvedPublic

Description

Featured, etc. badges are not shown in the ULS panel in Compact Language Links

Related: T70071.

Event Timeline

Amire80 created this task.Mar 30 2016, 8:44 AM
Restricted Application added a project: UniversalLanguageSelector. · View Herald TranscriptMar 30 2016, 8:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 triaged this task as Normal priority.Mar 30 2016, 8:45 AM
Amire80 moved this task from Backlog to Other on the ULS-CompactLinks board.

Change 292180 had a related patch set uploaded (by Nikerabbit):
WIP: show badges in ULS language list

https://gerrit.wikimedia.org/r/292180

This is what I currently have. It is not ideal as the badges are pushing the language names to the left. However, overflow: hidden makes list bullets not render and I have not found a work around to truncating long language names while having the bullets render.


In the last photo, ignore the search bar. The wrong alignment is caused by debug mode in combination with uselang.

Without overlow and allowing breaking long lines:

Bullet is at correct position now, but broken line looks like a new language item

@Pginer-WMF Comments?

Without overlow and allowing breaking long lines:


Bullet is at correct position now, but broken line looks like a new language item
@Pginer-WMF Comments?

Is it not possible to crop items at max width and use ellipsis as we currently do?

With the current design most of the languages fit in one line, and enough context was shown for the few that did not.

Is it not possible to crop items at max width and use ellipsis as we currently do?

Bullets and maxwidth+ellipse at overflow styles are not compatible. Bulletes will disappear when overflow happens

Is it not possible to crop items at max width and use ellipsis as we currently do?

Bullets and maxwidth+ellipse at overflow styles are not compatible. Bulletes will disappear when overflow happens

Would it be possible to wrap elements so that the bullet list do not hide overflow but items inside it do? I tried to capture the idea in this codepen.

I tried it unsuccessfully. The width limitation is on the ul element, and that is dynamic. I have illustrated the issue in this codepen. It kind of works if I add width: 100% to a but there is extra whitespace and text is no longer aligned with the bullets.

Change 292180 merged by Santhosh:
Show badges in ULS language list

https://gerrit.wikimedia.org/r/292180

Nikerabbit moved this task from In Review to QA on the Language-Q4-2016-Sprint 4 board.
Nemo_bis removed a subscriber: Nemo_bis.Jun 9 2016, 4:56 PM
Arrbee moved this task from QA to Done on the Language-Q4-2016-Sprint 4 board.Jun 14 2016, 7:00 AM