| • bmansurov | |
| Apr 18 2016, 10:22 PM |
| F3893885: Screen Shot 2016-04-19 at 6.27.58 PM.png | |
| Apr 19 2016, 5:30 PM |
This came up while I was testing 275724. Create a page with the following contents:
Test{{#tag:ref|This is a note.<ref>This is a nested ref.</ref>|group=note}}
<ref>Another references</ref>Enable lazy loading references and click on a reference. Once both notes and references sections load, click on [1] in the notes section. I was expecting to see the reference drawer, but was merely shown the highlighted reference down the page. :(
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Lazy loaded references should not have side effects | mediawiki/extensions/MobileFrontend | master | +23 -30 |
Spoke to @bmansurov to clarify this issue:
The issue is that clicking a reference populates the references and notes sections for the page. This shouldn't happen -
The method getReference should not have side effects on the current page.
Expected: A call to getReference doesn't re-render the content of the references page
Actual: It does.
Test{{#tag:ref|This is a note.<ref>This is a nested ref.</ref>|group=note}}
<ref>Another references</ref>
== Refs ==
<references></references>
== Notes ==
<references group="note"/>Change 284241 had a related patch set uploaded (by Jdlrobson):
Lazy loaded references should not have side effects
Change 284241 merged by jenkins-bot:
Lazy loaded references should not have side effects