Page MenuHomePhabricator

Clicking on a lazy-loaded reference should not re-render references section
Closed, ResolvedPublic

Description

This came up while I was testing 275724. Create a page with the following contents:

Test{{#tag:ref|This is a note.<ref>This is a nested ref.</ref>|group=note}}

<ref>Another references</ref>

Enable lazy loading references and click on a reference. Once both notes and references sections load, click on [1] in the notes section. I was expecting to see the reference drawer, but was merely shown the highlighted reference down the page. :(

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
DeclinedNone
OpenNone
Resolveddr0ptp4kt
DuplicateJhernandez
Duplicatedr0ptp4kt
OpenNone
ResolvedJdlrobson
DeclinedNone
DeclinedNone
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedNone

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2016, 10:22 PM
Jdlrobson triaged this task as Normal priority.Apr 19 2016, 5:13 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 5:13 PM

Spoke to @bmansurov to clarify this issue:
The issue is that clicking a reference populates the references and notes sections for the page. This shouldn't happen -

The method getReference should not have side effects on the current page.
Expected: A call to getReference doesn't re-render the content of the references page
Actual: It does.

Test{{#tag:ref|This is a note.<ref>This is a nested ref.</ref>|group=note}}

<ref>Another references</ref>

== Refs ==
<references></references>

== Notes ==
<references group="note"/>

Change 284241 had a related patch set uploaded (by Jdlrobson):
Lazy loaded references should not have side effects

https://gerrit.wikimedia.org/r/284241

jhobs renamed this task from Clicking on a lazy-loaded reference does not open the reference drawer to Clicking on a lazy-loaded reference should not re-render references section.Apr 19 2016, 8:51 PM

Change 284241 merged by jenkins-bot:
Lazy loaded references should not have side effects

https://gerrit.wikimedia.org/r/284241

bmansurov removed bmansurov as the assignee of this task.Apr 19 2016, 9:58 PM

Thanks for clarifying the nature of the bug in the title bug @jhobs.