| Volker_E | |
| Apr 22 2016, 9:50 PM |
| F3947375: OOjs UI Demos 2016-04-29 14-01-30.png | |
| Apr 29 2016, 9:04 PM |
| F3913173: T133429 ButtonSelectWidget focus OOjs UI Demos 2016-04-22.png | |
| Apr 22 2016, 9:53 PM |
The ButtonSelectWidget (internally ButtonOptionWidget) currently –as of v0.16.6– receives browser's default focus appearance and should follow button focus states.
Before  | After  |
Buttons, ButtonGroupWidget and ButtonSelectWidget of v0.16.6 in focus state
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T114026 Minimize differences between implemented components and in pholio mock-ups | |||
| Resolved | Volker_E | T114050 Get RadioSelectInputWidget to design spec | |||
| Resolved | Volker_E | T114049 Get CheckboxInputWidget to design spec | |||
| Open | None | T113560 Standardize MediaWiki components (tracking) | |||
| Resolved | Volker_E | T113225 Getting ToggleSwitchWidget to design spec | |||
| Resolved | Volker_E | T115293 Standardize on component focus states | |||
| Resolved | matmarex | T133429 ButtonSelectWidget (ButtonOptionWidget) should receive a custom focus appearance |
Change 284994 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Align ButtonSelectWidget :focus state with other widgets
I think we should make it look as if the currently selected option in the select widget has focus, and not the whole widget. This would probably be more consistent with how native interfaces behave, and as a bonus should be straightforward to implement.
The only problem is what to do if none of the options is selected… Given that select widgets don't generally allow the user to deselect all options, I don't think this is very important to worry about. We could just select one of the options on focus and avoid this problem.
@Volker_E, I'm going to take this over, I have a fairly good idea in my head how to implement this. I'll make it depend on your ButtonElement focus standardization (https://gerrit.wikimedia.org/r/#/c/285411/).
Change 285667 had a related patch set uploaded (by Bartosz Dziewoński):
MediaWiki theme: Custom :focus state for SelectWidgets
Change 285667 merged by jenkins-bot:
MediaWiki theme: Custom :focus state for SelectWidgets
Change 284994 abandoned by VolkerE:
MediaWiki theme: Align ButtonSelectWidget :focus state with other widgets
Reason:
Fixed in https://gerrit.wikimedia.org/r/#/c/285667/