Page MenuHomePhabricator
Create Task
Maniphest T114049

Get CheckboxInputWidget to design spec
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

  • M30 Checkbox
    10

    • Details

    SubjectRepoBranchLines +/-
    MediaWiki theme: Adjust CheckboxInputWidget to match M30 designoojs/uimaster+86 -59
    MediaWiki theme: Adjust CheckboxInputWidget to match M30 designoojs/uimaster+54 -28
    Customize query in gerrit

    Related Objects
    Search...

    Event Timeline

    • violetto created this task.Sep 28 2015, 10:37 PM
    • violetto assigned this task to Volker_E.
    • violetto raised the priority of this task from to Needs Triage.
    • violetto updated the task description. (Show Details)
    • violetto added a project: UI-Standardization.
    • violetto added a mock: M30: Checkbox.
    • violetto added subscribers: Volker_E, • violetto, Aklapper.
    • violetto added a parent task: T114026: Minimize differences between implemented components and in pholio mock-ups.Sep 28 2015, 10:48 PM
    • violetto reopened this task as Open.Oct 1 2015, 7:20 PM
    • violetto closed this task as a duplicate of T72909: checkboxes hover, focus, and click states are not to spec.
    • violetto set Security to None.
    • violetto merged a task: T72909: checkboxes hover, focus, and click states are not to spec.
    • violetto added subscribers: • Jaredzimmerman-WMF, • Mattflaschen-WMF, • wikibugs-l-list, Jdlrobson.
    Volker_E moved this task from Unsorted to Current Quarterly Goals on the UI-Standardization board.Oct 1 2015, 9:16 PM
    • violetto merged a task: T71200: Implement checkbox spec in mediawiki.ui.Oct 2 2015, 9:25 PM
    • violetto added a subscriber: Krinkle.
    gerritbot subscribed.Oct 10 2015, 1:18 AM

    Change 244838 had a related patch set uploaded (by VolkerE):
    Get CheckboxInputWidget to MediaWiki theme's design specs

    https://gerrit.wikimedia.org/r/244838

    gerritbot added a project: Patch-For-Review.Oct 10 2015, 1:18 AM
    Volker_E moved this task from Current Quarterly Goals to Doing… on the UI-Standardization board.Oct 10 2015, 1:24 AM
    matmarex subscribed.Oct 10 2015, 2:19 PM

    Screenshot of the proposed implementation (T114049 / T114050 / T113225), for the lazy:

    New design for OOjs UI checkbox/radio/toggle (509×390 px, 26 KB)

    matmarex mentioned this in T114050: Get RadioSelectInputWidget to design spec.Oct 10 2015, 2:19 PM
    matmarex mentioned this in T113225: Getting ToggleSwitchWidget to design spec.
    Jdforrester-WMF closed this task as Resolved.Oct 20 2015, 6:18 PM
    Jdforrester-WMF triaged this task as Medium priority.
    Jdforrester-WMF updated the task description. (Show Details)
    Jdforrester-WMF edited projects, added OOUI, OOjs-UI-next-release; removed Patch-For-Review.
    gerritbot added a comment.Oct 20 2015, 6:24 PM

    Change 244838 merged by jenkins-bot:
    MediaWiki theme: Adjust CheckboxInputWidget to match M30 design

    https://gerrit.wikimedia.org/r/244838

    Jdforrester-WMF reopened this task as Open.Oct 21 2015, 4:05 PM
    Jdforrester-WMF removed a project: OOjs-UI-next-release.
    Jdforrester-WMF subscribed.

    Reverted.

    gerritbot added a comment.Oct 21 2015, 5:46 PM

    Change 247875 had a related patch set uploaded (by Jforrester):
    MediaWiki theme: Adjust CheckboxInputWidget to match M30 design

    https://gerrit.wikimedia.org/r/247875

    gerritbot added a project: Patch-For-Review.Oct 21 2015, 5:46 PM
    Volker_E added a comment.Oct 21 2015, 6:37 PM

    Citing @matmarex from https://gerrit.wikimedia.org/r/#/c/244838/

    I'm seeing a pretty weird effect with the hover transition, though – the border (of both checkboxes and radios) seems to momentarily disappear when transitioning from hovered to non-hovered. https://phabricator.wikimedia.org/F2700526

    Myself answering there:

    You're right, the issue is border-width. I can (and have updated the patch set) replace it by box-shadow. Clearly, IE8 isn't supporting it. Focus in compounded form problem from T113225 isn't solved yet.

    • Mattflaschen-WMF unsubscribed.Oct 28 2015, 6:47 PM
    Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.Nov 17 2015, 1:26 AM
    Volker_E added a subtask: T115293: Standardize on component focus states.Jan 25 2016, 10:46 PM
    • ggellerman edited projects, added UI-Standardization-Kanban; removed UI-Standardization.Feb 23 2016, 7:32 PM
    • violetto moved this task from Backlog to Researching… on the UI-Standardization-Kanban board.Feb 23 2016, 7:33 PM
    • violetto moved this task from Researching… to Backlog on the UI-Standardization-Kanban board.Feb 23 2016, 7:35 PM
    Krinkle unsubscribed.Feb 23 2016, 7:38 PM
    Volker_E moved this task from Backlog to Doing… on the UI-Standardization-Kanban board.Feb 23 2016, 8:10 PM
    Jdforrester-WMF renamed this task from Getting CheckboxInputWidget to design spec to Get CheckboxInputWidget to design spec.Mar 2 2016, 2:00 AM

    Right now this is stalled because it's "too blue", right? :-(

    Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 8 2016, 11:15 PM
    Jdforrester-WMF closed subtask T115293: Standardize on component focus states as Resolved.Apr 29 2016, 6:10 PM
    Jdforrester-WMF moved this task from Reviewing to OOjs-UI-0.17.1 on the OOUI board.
    Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.1); removed OOUI.
    Jdforrester-WMF moved this task from OOjs-UI-0.17.1 to OOjs-UI-0.17.2 on the OOUI board.May 4 2016, 1:25 PM
    Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.2); removed OOUI (OOjs-UI-0.17.1).
    Volker_E updated the task description. (Show Details)May 5 2016, 8:52 PM
    Volker_E added a subscriber: Pginer-WMF.
    Volker_E added a comment.May 5 2016, 10:15 PM

    We're not going to care about the disabled state's color (adaptions) right now, nor about the border-color of normal state, as our accessible color palette discussion is going to play into that in a separate task still to come.
    This open task is about taking action to have the states getting rid of constructive checkmarks and the pseudo-3D effect on :hover, also aligning focus state with other widgets.

    Volker_E moved this task from Doing… to Review on the UI-Standardization-Kanban board.May 9 2016, 7:11 PM
    Jdforrester-WMF set the point value for this task to 8.May 9 2016, 8:15 PM
    Jdforrester-WMF moved this task from OOjs-UI-0.17.2 to OOjs-UI-0.17.3 on the OOUI board.May 10 2016, 11:11 PM
    Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.3); removed OOUI (OOjs-UI-0.17.2).
    Danny_B added a project: UI-Standardization.May 23 2016, 6:25 AM
    Danny_B moved this task from Doing… to OOUI on the UI-Standardization board.May 23 2016, 6:45 AM
    Jdforrester-WMF moved this task from OOjs-UI-0.17.3 to OOjs-UI-0.17.4 on the OOUI board.May 31 2016, 10:16 PM
    Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.4); removed OOUI (OOjs-UI-0.17.3).
    Jdforrester-WMF moved this task from OOjs-UI-0.17.4 to Reviewing on the OOUI board.Jun 7 2016, 10:55 AM
    Jdforrester-WMF edited projects, added OOUI; removed OOUI (OOjs-UI-0.17.4).
    Volker_E moved this task from Reviewing to Doing on the OOUI board.Jun 13 2016, 3:49 PM
    Jdforrester-WMF moved this task from Doing to OOjs-UI-0.17.9 on the OOUI board.Sep 7 2016, 5:41 PM
    Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.9); removed OOUI.
    Jdforrester-WMF closed this task as Resolved.Sep 12 2016, 6:20 PM
    gerritbot added a comment.Sep 12 2016, 6:27 PM

    Change 247875 merged by jenkins-bot:
    MediaWiki theme: Adjust CheckboxInputWidget to match M30 design

    https://gerrit.wikimedia.org/r/247875

    Volker_E removed a project: Patch-For-Review.Sep 12 2016, 8:42 PM
    Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.
    Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits