Page MenuHomePhabricator
Create Task
Maniphest T135270

Update LoginNotify for AuthManager
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

The AddNewAccount hook has been replaced by LocalUserCreated since 1.26. The AddNewAccount hook will no longer be reliably called under AuthManager.

The LoginAuthenticateAudit hook is deprecated and will no longer be called under AuthManager. You might use the AuthManagerLoginAuthenticateAudit hook instead.

Details

SubjectRepoBranchLines +/-
Update AddNewAccount->LocalUserCreated hook for LoginNotifymediawiki/extensions/LoginNotifymaster+26 -1
Update LoginNotify for AuthManager.mediawiki/extensions/LoginNotifymaster+51 -8
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT110291 Update all extensions to use AuthManager
Resolved• demonT11838 Send notification to account owner on multiple unsuccessful login attempts
ResolvedBawolffT135270 Update LoginNotify for AuthManager
· · ·

Event Timeline

Anomie created this task.May 13 2016, 8:22 PM
Restricted Application added a subscriber: Zppix. · View Herald TranscriptMay 13 2016, 8:22 PM
Bawolff claimed this task.May 14 2016, 9:27 AM
Nemo_bis unsubscribed.May 14 2016, 9:32 AM
gerritbot subscribed.Jul 7 2016, 6:59 PM

Change 297844 had a related patch set uploaded (by Brian Wolff):
Update LoginNotify for AuthManager.

https://gerrit.wikimedia.org/r/297844

gerritbot added a project: Patch-For-Review.Jul 7 2016, 6:59 PM
gerritbot added a comment.Jul 7 2016, 7:03 PM

Change 297844 merged by jenkins-bot:
Update LoginNotify for AuthManager.

https://gerrit.wikimedia.org/r/297844

Bawolff added a comment.Jul 7 2016, 7:03 PM

That patch was for the LoginAuthenticateAudit. AddNewAccount is still todo.

Bawolff mentioned this in rELGN143d7caa4484: Update LoginNotify for AuthManager..Jul 7 2016, 7:17 PM
Anomie removed a project: Patch-For-Review.Jul 7 2016, 9:17 PM
Niharika mentioned this in T153335: Investigation: Notify on multiple unsuccessful login attempts.Dec 23 2016, 3:36 PM
kaldari added a project: Community-Tech.Dec 23 2016, 10:18 PM
kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.
kaldari moved this task from Needs Discussion to Older: Team Work on the Community-Tech board.Dec 23 2016, 10:31 PM
kaldari moved this task from Older: Team Work to Needs Discussion on the Community-Tech board.Dec 24 2016, 12:17 AM
kaldari added a parent task: T11838: Send notification to account owner on multiple unsuccessful login attempts.Dec 24 2016, 12:30 AM
kaldari edited projects, added MediaWiki-extensions-LoginNotify; removed MediaWiki-extensions-Other.Dec 28 2016, 8:06 PM
kaldari raised the priority of this task from Low to Medium.Jan 3 2017, 5:46 PM
kaldari set the point value for this task to 3.
kaldari moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
• DannyH edited projects, added Community-Tech-Sprint; removed Community-Tech.Jan 17 2017, 5:41 PM
gerritbot added a comment.Jan 23 2017, 6:54 AM

Change 333563 had a related patch set uploaded (by Niharika29):
Update AddNewAccount->LocalUserCreated hook for LoginNotify

https://gerrit.wikimedia.org/r/333563

gerritbot added a project: Patch-For-Review.Jan 23 2017, 6:54 AM
Niharika moved this task from Ready to In Development on the Community-Tech-Sprint board.Jan 23 2017, 7:00 AM
Diffusion mentioned this in rELGNff379e960b19: Update AddNewAccount->LocalUserCreated hook for LoginNotify.Jan 23 2017, 7:38 AM
Diffusion mentioned this in rELGN81f9ff4fe8f7: Update AddNewAccount->LocalUserCreated hook for LoginNotify.Jan 23 2017, 4:16 PM
Niharika moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Jan 24 2017, 3:20 PM
kaldari moved this task from Needs Review/Feedback to In Development on the Community-Tech-Sprint board.Feb 9 2017, 3:07 PM
Diffusion mentioned this in rELGN0039820c91d2: Update AddNewAccount->LocalUserCreated hook for LoginNotify.Feb 15 2017, 12:11 PM
kaldari closed this task as Resolved.Feb 15 2017, 11:27 PM
kaldari moved this task from In Development to Q1 2018-19 on the Community-Tech-Sprint board.
kaldari mentioned this in T140167: Security Review of LoginNotify extension.Feb 15 2017, 11:29 PM
Liuxinyu970226 unsubscribed.Feb 16 2017, 4:34 AM
bd808 mentioned this in rELGN4fae81abed20: Update AddNewAccount->LocalUserCreated hook for LoginNotify.Feb 23 2017, 5:54 PM
gerritbot added a comment.Feb 23 2017, 6:07 PM

Change 333563 merged by jenkins-bot:
Update AddNewAccount->LocalUserCreated hook for LoginNotify

https://gerrit.wikimedia.org/r/333563

• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Mar 2 2017, 6:17 PM
• DannyH moved this task from Up Next (June 3-21) to Archive on the Community-Tech board.Mar 2 2017, 6:40 PM
MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-LoginNotify board.Aug 28 2017, 8:05 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits