Page MenuHomePhabricator

Special:Translate shows "not prioritized language" warning for unrelated group
Closed, ResolvedPublic

Description

There is an encourage/discourage feature from Special:PageTranslation but it doesn't seem to do anything other than adding a log entry? I would (at least) expect it to show that the page has been discouraged from translation on Special:Translate interface at least.

Details

Related Gerrit Patches:

Event Timeline

Glaisher created this task.May 14 2016, 5:16 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 14 2016, 5:16 PM

Ok, something seems to be very wrong here. I did this

22:06 . . Admin (talk | contribs | block) limited languages for translatable page Abc to تونسي and Acèh ‎

and then this

22:17 . . Admin (talk | contribs | block) discouraged translation of C/B ‎

and now on the translation interface for C/B it shows

Translation of the wiki page Abc from English (en).

Translating to English is not a priority for this page.

A translation administrator decided to focus the translation efforts on تونسي, Acèh.

Note that it says "Abc" wiki page instead of C/B.

Looks like that error is only appearing when you select English from the translation interface.

Thanks for testing. https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_administration says «hide them from the translation interface. [...] Discouraging and its reversion are done from Special:PageTranslation.»

Works for me with Meta's discouraged pages:


Can you find an example of discouraged page that still shows up in the group selector?

Glaisher added a comment.EditedMay 14 2016, 5:38 PM

Oh thanks. After reading the docs, it looks like what I thought about this feature was wrong. I expected the translation interface to show a message at the top saying it's discouraged (though it probably should). Discouraging doesn't prevent new translations; it only hides them from message group selectors (and this works properly).

But the wrong message being shown for an unrelated group still exists.

Nemo_bis added a comment.EditedMay 15 2016, 9:13 AM

But the wrong message being shown for an unrelated group still exists.

I'm not sure I understood this part. Does "Direct link to Special:Translate for disabled group shows mentions of another group" describe what you observe?

Glaisher renamed this task from Page translation's encourage/discourage doesn't seem to have any effect to Special:Translate shows "not prioritized language" warning for unrelated group.May 15 2016, 9:27 AM

Looks like state.group is undefined when source language is selected because TuxMessageTable is never loaded (and this has the information needed by the JS to set state.group correctly). This is also the root cause for Special:Translate always showing "Translation of the wiki page 100wikidays from English (en)." for translatable pages when English is selected. See https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=page-IP+block+exempt&action=page&filter=&language=en for example.

Nikerabbit triaged this task as High priority.Jun 7 2016, 11:30 AM
Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.
Nikerabbit added a subscriber: Nikerabbit.

I can confirm the part of wrong description being shown. Thanks for analyzing this.

Change 424607 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Move language validation from Special:Translate to ApiQueryMessageCollection

https://gerrit.wikimedia.org/r/424607

Change 424607 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Move language validation from Special:Translate to ApiQueryMessageCollection

https://gerrit.wikimedia.org/r/424607

Nikerabbit moved this task from Backlog to QA on the Language-2018-Apr-June board.
Nikerabbit moved this task from QA to Done on the Language-2018-Apr-June board.Jun 13 2018, 7:05 AM