Show changes button on edit page does not work when using a non-default format with a content model that supports multiple formats
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bawolff
	Jul 2 2016, 9:37 PM

Description

Steps to reproduce:

Have a content model with multiple formats
Edit the page, passing a non-default format with the url parameter &format=foo
Hit show changes
Expected behaviour: You get a diff
Actual behavior: MW seems to try to serialize the contents of the edit box as if they were the default format. This fails. Any subsequent preview/save button presses also fail.

Note that most normal editing/preview etc work fine with non-default format.

	Subject	Repo	Branch	Lines +/-
	Do not override content format in EditPage when loading rev.	mediawiki/core	master	+27 -3

Status	Assigned	Task
Resolved	Isarra	T116831 Women in Red workflow automation / optimization (tracking)
Declined	None	T106828 Make it easier for WikiProjects to shove long, narrow lists into columns
Declined	None	T106823 Discourage wikiprojects from shoving extra stuff into their headers
Resolved	Isarra	T97210 MediaWiki extension for WikiProjects / on-wiki working groups
Invalid	None	T137916 Detect CollaborationListContent pages and format output for those pages
Declined	None	T155680 Deploy CollaborationKit to all Wikipedias
Declined	None	T123028 Deploy CollaborationKit on English Wikipedia
Resolved	Reedy	T138326 Deploy CollaborationKit on Test Wikipedia
Resolved	None	T138325 Deploy CollaborationKit on Beta Wikipedia
Resolved	Reedy	T138324 Security review for CollaborationKit
Resolved	Bawolff	T136462 Create CollaborationListContent editor
Resolved	Bawolff	T139097 Create mass editing interface for lists
Resolved	Bawolff	T139249 Show changes button on edit page does not work when using a non-default format with a content model that supports multiple formats

I think this is a result of the side effect of the diff code calling $this->getCurrentContent()

Change 299440 had a related patch set uploaded (by Brian Wolff):
Do not override content format in EditPage when loading rev.

Change 299440 merged by jenkins-bot:
Do not override content format in EditPage when loading rev.

Bawolff closed this task as Resolved.Jul 22 2016, 3:43 PM

Bawolff claimed this task.