Page MenuHomePhabricator

Remove automatic beta updates for Parsoid
Closed, ResolvedPublic

Description

T90668: Replace custom server.js with service-runner makes Parsoid use service-runner as its run library, which changes may things around how it is started and run. We need to remove the automatic BC update job for Parsoid because of it. Additionally, the Parsoid beta hosts shouldn't be Zuul/Jenkins slaves any more.

Details

Related Gerrit Patches:

Event Timeline

mobrovac created this task.Jul 13 2016, 8:10 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 13 2016, 8:10 AM
mobrovac updated the task description. (Show Details)Jul 13 2016, 8:12 AM

I removed role::ci::slave::labs and role::parsoid::beta from deployment-parsoid0[56].

So if I understand properly Parsoid is going to move to the generic service runner system. For beta we would:

  • remove deployment-parsoid as a slave of Jenkins
  • drop the jenkins job that auto-update it (beta-parsoid-update-eqiad) and remove it from the repo postmerge pipeline in Zuul
  • clear up the puppet class role::parsoid::beta

Out of scope of this task but: how are you going to keep it up-to-date on beta?

Change 298701 had a related patch set uploaded (by Mobrovac):
Remove beta-parsoid-update-eqiad from mediawiki/services/parsoid

https://gerrit.wikimedia.org/r/298701

So if I understand properly Parsoid is going to move to the generic service runner system. For beta we would:

  • remove deployment-parsoid as a slave of Jenkins

Done by removing the roles from deployment-parsoid0[56]

  • drop the jenkins job that auto-update it (beta-parsoid-update-eqiad) and remove it from the repo postmerge pipeline in Zuul

Done in the above patch

  • clear up the puppet class role::parsoid::beta

It is likely that this role will go away. A WIP patch for that is in progress.


Out of scope of this task but: how are you going to keep it up-to-date on beta?

The Parsoid folks are ok with manually updating beta for now. We do need to find a generic way of deploying to beta for services that use service-runner / service::node (but that's definitely out of scope here).

Mentioned in SAL [2016-07-13T08:33:49Z] <hashar> removing deployment-parsoid05 from the Jenkins slaves T140218

Change 298701 merged by jenkins-bot:
Remove beta-parsoid-update-eqiad from mediawiki/services/parsoid

https://gerrit.wikimedia.org/r/298701

hashar closed this task as Resolved.Jul 13 2016, 8:35 AM
hashar assigned this task to mobrovac.

The Parsoid folks are ok with manually updating beta for now. We do need to find a generic way of deploying to beta for services that use service-runner / service::node (but that's definitely out of scope here).

If that can be handled with scap3 we eventually want to get a generic Jenkins job that will run on deployment-tin, does the git pull and scap deploy from there.

I have deployed the CI change, dropped the slave from Jenkins and delete the job.