Page MenuHomePhabricator
Create Task
Maniphest T142120

Remove UnitTestsList hook subscribers, move tests to be autodiscovered for extensions that have been converted to extension registration
Open, LowPublic
Actions

Description

Now https://gerrit.wikimedia.org/r/#/c/302944/ is merged, phpunit tests can be autodiscovered by moving them into the correct place. See https://gerrit.wikimedia.org/r/#/c/302958/ for example

Once this has been done, UnitTestsList subscribers can be removed

Ready to go list:

  • AbuseFilter
  • ActiveAbstract
  • AntiSpoof
  • ArticlePlaceholder
  • Babel
  • BaseHooks
  • BetaFeatures
  • BounceHandler
  • Capiunto
  • CentralAuth
  • Cognate
  • CollaborationKit
  • CommonsMetadata
  • ConfirmEdit
  • DonationInterface
  • Elastica
  • EventBus
  • ExtensionDistributor
  • Gadgets
  • GlobalCssJs
  • GoogleAPIClient
  • GuidedTour
  • Kartographer
  • LocalisationUpdate
  • LoginNotify
  • MaintenanceShell
  • MassMessage
  • Math
  • MathSearch
  • MobileFrontend
  • MolHandler
  • Newsletter
  • OAuthAuthentication
  • ORES
  • PageAssessments
  • PageForms
  • ParserFunctions
  • PhpTags
  • PhpTagsFunctions
  • PhpTagsWidgets
  • PhpTagsWiki
  • ProofreadPage
  • QuickSearchLookup
  • SendGrid
  • Sentry
  • TemplateData
  • TemplateStyles
  • TextExtracts
  • Thanks
  • TitleBlacklist
  • TwnMainPage
  • UploadWizard
  • UrlShortener
  • UserMerge
  • WikibaseMediaInfo
  • WikibaseQuality
  • Wikidata
  • WikidataPageBanner
  • WikimediaEvents
  • WikimediaIncubator

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove UnitTestsList in favor of autodiscoverymediawiki/extensions/PhpTagsStoragemaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/DonationInterfacemaster+15 -58
Remove UnitTestsList in favor of autodiscoverymediawiki/extensions/MediaWikiFarmmaster+0 -90
Remove UnitTestsList in favor of autodiscoverymediawiki/extensions/MultiMapsmaster+0 -18
Remove UnitTestsList in favor of autodiscoverymediawiki/extensions/SemanticSiftermaster+1 -8
Remove UnitTestsList in favor of autodiscoverymediawiki/extensions/googleAnalyticsmaster+0 -23
Remove UnitTestsList in favor of autodiscoverymediawiki/extensions/Acrolinxmaster+1 -14
Remove 'UnitTestList' hookmediawiki/extensions/PageFormsmaster+0 -17
Move tests to tests/phpunit/ and remove hookmediawiki/extensions/BounceHandlermaster+0 -31
Remove 'UnitTestList' hookmediawiki/extensions/PagedTiffHandlermaster+0 -12
Move phpunit test filesmediawiki/extensions/Mathmaster+0 -0
Remove 'UnitTestList' hookmediawiki/extensions/MathSearchmaster+0 -15
Remove 'UnitTestList' hookmediawiki/extensions/PhpTagsSMWmaster+1 -13
Remove 'UnitTestList' hookmediawiki/extensions/PhpTagsWidgetsmaster+4 -15
Remove 'UnitTestList' hookmediawiki/extensions/PhpTagsFunctionsmaster+1 -13
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceFoundationmaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/PhpTagsmaster+1 -13
Remove 'UnitTestList' hookmediawiki/extensions/PhpTagsWikimaster+1 -13
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpicePageTemplatesmaster+1 -11
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceReadersmaster+1 -13
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceInterWikiLinksmaster+0 -15
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceUserManagermaster+0 -14
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpicePageAssignmentsmaster+1 -13
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceSmartListmaster+0 -13
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceNamespaceManagermaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/MolHandlermaster+0 -17
Remove 'UnitTestList' hookmediawiki/extensions/NSFileRepomaster+1 -18
Remove 'UnitTestList' hookmediawiki/extensions/OAuthAuthenticationmaster+2 -12
Remove 'UnitTestList' hookmediawiki/extensions/NewUserActionsmaster+0 -14
Remove 'UnitTestList' hookmediawiki/extensions/MultiLanguageManagermaster+0 -11
Move tests to tests/phpunit/ and remove hookmediawiki/extensions/BaseHooksmaster+1 -23
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceAvatarsmaster+0 -13
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceRSSFeedermaster+0 -11
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceInsertMagicmaster+1 -13
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceInsertFilemaster+0 -14
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceChecklistmaster+1 -14
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceGroupManagermaster+0 -15
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceExtendedStatisticsmaster+1 -10
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceExtendedSearchmaster+0 -11
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceContextMenumaster+1 -13
Remove 'UnitTestList' hookmediawiki/extensions/BlueSpiceDashboardsmaster+1 -13
Remove 'UnitTestList' hookmediawiki/extensions/SendGridmaster+1 -28
Remove 'UnitTestList' hookmediawiki/extensions/QuickSearchLookupmaster+0 -14
Remove 'UnitTestList' hookmediawiki/extensions/Newslettermaster+0 -29
Remove 'UnitTestList' hookmediawiki/extensions/MaintenanceShellmaster+0 -8
Remove 'UnitTestList' hookmediawiki/extensions/CentralNoticemaster+6 -28
Move tests into tests/phpunit and remove UnitTestsList hookmediawiki/extensions/Scribuntomaster+5 -36
Remove UnitTestList hook subscribermediawiki/extensions/CirrusSearchmaster+1 -26
Remove 'UnitTestList' hookmediawiki/extensions/UserMergemaster+1 -30
Remove 'UnitTestList' hookmediawiki/extensions/VipsScalermaster+0 -16
Remove 'UnitTestList' hookmediawiki/extensions/TextExtractsmaster+0 -9
Remove 'UnitTestList' hookmediawiki/extensions/MassMessagemaster+2 -27
Add extension.json, empty PHP entry pointmediawiki/extensions/JsonConfigmaster+205 -166
Move tests to tests/phpunit/ and remove hookmediawiki/extensions/LoginNotifymaster+1 -15
Remove "UnitTestsList" hookmediawiki/extensions/ArticlePlaceholdermaster+0 -11
Remove 'UnitTestList' hookmediawiki/extensions/Gadgetsmaster+0 -14
Remove 'UnitTestList' hookmediawiki/extensions/TemplateStylesmaster+0 -13
Remove 'UnitTestList' hookmediawiki/extensions/CollaborationKitmaster+0 -26
Remove 'UnitTestList' hookmediawiki/extensions/WikibaseMediaInfomaster+0 -25
Remove 'UnitTestList' hookmediawiki/extensions/ParserFunctionsmaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/WikibaseQualitymaster+1 -18
Remove 'UnitTestList' hookmediawiki/extensions/TwnMainPagemaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/Sentrymaster+0 -7
Remove 'UnitTestList' hookmediawiki/extensions/ProofreadPagemaster+6 -34
Remove 'UnitTestList' hookmediawiki/extensions/Mathmaster+0 -16
Remove 'UnitTestList' hookmediawiki/extensions/GlobalCssJsmaster+2 -23
Remove 'UnitTestList' hookmediawiki/extensions/Babelmaster+0 -8
Remove 'UnitTestList' hookmediawiki/extensions/GuidedTourmaster+0 -15
Remove 'UnitTestList' hookmediawiki/extensions/Capiuntomaster+0 -15
Remove 'UnitTestList' hookmediawiki/extensions/Elasticamaster+0 -42
Remove 'UnitTestList' hookmediawiki/extensions/CommonsMetadatamaster+0 -14
Remove 'UnitTestList' hookmediawiki/extensions/EventBusmaster+0 -11
Remove 'UnitTestList' hookmediawiki/extensions/ExtensionDistributormaster+0 -30
Remove 'UnitTestList' hookmediawiki/extensions/Kartographermaster+0 -16
Remove 'UnitTestList' hookmediawiki/extensions/ConfirmEditmaster+7 -36
Remove 'UnitTestList' hookmediawiki/extensions/WikimediaIncubatormaster+1 -11
Remove 'UnitTestList' hookmediawiki/extensions/WikimediaEventsmaster+0 -23
Remove 'UnitTestList' hookmediawiki/extensions/TitleBlacklistmaster+0 -14
Remove 'UnitTestList' hookmediawiki/extensions/WikidataPageBannermaster+0 -24
Remove 'UnitTestList' hookmediawiki/extensions/Thanksmaster+0 -18
Remove 'UnitTestList' hookmediawiki/extensions/PageAssessmentsmaster+0 -10
Remove 'UnitTestList' hookmediawiki/extensions/ORESmaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/TemplateDatamaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/LocalisationUpdatemaster+0 -21
Remove 'UnitTestList' hookmediawiki/extensions/RelatedArticlesmaster+0 -21
Remove 'UnitTestList' hookmediawiki/extensions/MobileFrontendmaster+0 -16
Remove 'UnitTestList' hookmediawiki/extensions/UploadWizardmaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/UrlShortenermaster+0 -25
Move tests to tests/phpunit/ and remove hookmediawiki/extensions/BetaFeaturesmaster+1 -14
Move tests to tests/phpunit/ and remove hookmediawiki/extensions/ActiveAbstractmaster+2 -23
Remove 'UnitTestsList' hookmediawiki/extensions/CentralAuthmaster+0 -14
Move tests to tests/phpunit/ and remove hookmediawiki/extensions/AntiSpoofmaster+1 -27
Remove 'UnitTestsList' hookmediawiki/extensions/AbuseFiltermaster+1 -21
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Apr 20 2018, 8:08 AM

Change 427739 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceInsertMagic@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427739

gerritbot added a comment.Apr 20 2018, 8:44 AM

Change 427733 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceRSSFeeder@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427733

gerritbot added a comment.Apr 20 2018, 8:48 AM

Change 427724 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceAvatars@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427724

Reedy removed projects: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), Patch-For-Review.Apr 20 2018, 9:08 AM
Jayprakash12345 added a project: Patch-For-Review.Apr 20 2018, 9:17 AM
Jayprakash12345 subscribed.

Some are in review https://gerrit.wikimedia.org/r/#/q/status:open+topic:T142120, feel free to merge.

Liuxinyu970226 subscribed.Apr 20 2018, 12:05 PM
gerritbot added a comment.Apr 20 2018, 6:31 PM

Change 303349 merged by jenkins-bot:
[mediawiki/extensions/BaseHooks@master] Move tests to tests/phpunit/ and remove hook

https://gerrit.wikimedia.org/r/303349

gerritbot added a comment.Apr 20 2018, 6:32 PM

Change 427721 merged by jenkins-bot:
[mediawiki/extensions/NewUserActions@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427721

gerritbot added a comment.Apr 20 2018, 6:33 PM

Change 427725 merged by jenkins-bot:
[mediawiki/extensions/MultiLanguageManager@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427725

Umherirrender mentioned this in rEMLM9b6fe8a483fc: Remove 'UnitTestList' hook.Apr 20 2018, 6:36 PM
gerritbot added a comment.Apr 20 2018, 6:41 PM

Change 427716 merged by jenkins-bot:
[mediawiki/extensions/OAuthAuthentication@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427716

gerritbot added a comment.Apr 20 2018, 6:42 PM

Change 427741 merged by jenkins-bot:
[mediawiki/extensions/NSFileRepo@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427741

gerritbot added a comment.Apr 20 2018, 6:48 PM

Change 427726 merged by jenkins-bot:
[mediawiki/extensions/MolHandler@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427726

gerritbot added a comment.Apr 20 2018, 6:54 PM

Change 427736 merged by Umherirrender:
[mediawiki/extensions/BlueSpiceNamespaceManager@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427736

Umherirrender mentioned this in rEBTX05d4ea1d7df7: Remove 'UnitTestList' hook.Apr 20 2018, 6:55 PM
gerritbot added a comment.Apr 20 2018, 6:55 PM

Change 427731 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceSmartList@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427731

gerritbot added a comment.Apr 20 2018, 6:57 PM

Change 427735 merged by Umherirrender:
[mediawiki/extensions/BlueSpicePageAssignments@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427735

gerritbot added a comment.Apr 20 2018, 6:58 PM

Change 427730 merged by Umherirrender:
[mediawiki/extensions/BlueSpiceUserManager@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427730

gerritbot added a comment.Apr 20 2018, 6:59 PM

Change 427738 merged by Umherirrender:
[mediawiki/extensions/BlueSpiceInterWikiLinks@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427738

gerritbot added a comment.Apr 20 2018, 7:00 PM

Change 427732 merged by Umherirrender:
[mediawiki/extensions/BlueSpiceReaders@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427732

gerritbot added a comment.Apr 20 2018, 7:01 PM

Change 427734 merged by Umherirrender:
[mediawiki/extensions/BlueSpicePageTemplates@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427734

Umherirrender mentioned this in rEBHK3c024ea99842: Move tests to tests/phpunit/ and remove hook.Apr 20 2018, 7:04 PM
Umherirrender mentioned this in rEBHKa2a53f860cd9: Move tests to tests/phpunit/ and remove hook.
gerritbot added a comment.Apr 20 2018, 7:05 PM

Change 427706 merged by Umherirrender:
[mediawiki/extensions/PhpTagsWiki@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427706

gerritbot added a comment.Apr 20 2018, 7:05 PM

Change 427713 merged by Umherirrender:
[mediawiki/extensions/PhpTags@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427713

gerritbot added a comment.Apr 20 2018, 7:10 PM

Change 427749 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427749

gerritbot added a comment.Apr 20 2018, 7:10 PM

Change 427712 merged by Umherirrender:
[mediawiki/extensions/PhpTagsFunctions@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427712

gerritbot added a comment.Apr 20 2018, 7:15 PM

Change 427708 merged by Umherirrender:
[mediawiki/extensions/PhpTagsWidgets@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427708

gerritbot added a comment.Apr 20 2018, 7:15 PM

Change 427711 merged by Umherirrender:
[mediawiki/extensions/PhpTagsSMW@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427711

Umherirrender updated the task description. (Show Details)Apr 20 2018, 7:56 PM
Reedy unsubscribed.Apr 20 2018, 8:01 PM
SamanthaNguyen unsubscribed.Apr 20 2018, 8:45 PM
gerritbot added a comment.Apr 21 2018, 11:57 AM

Change 428056 had a related patch set uploaded (by Gopavasanth; owner: Gopavasanth):
[mediawiki/extensions/PageForms@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/428056

Gopavasanth mentioned this in rEPFMa24d08917b90: Remove 'UnitTestList' hook.Apr 21 2018, 12:01 PM
Gopavasanth mentioned this in rEPFM219b8c47e19b: Remove 'UnitTestList' hook.
Gopavasanth mentioned this in rEPFM9d88675bb0cb: Remove 'UnitTestList' hook.Apr 21 2018, 12:05 PM
gerritbot added a comment.Apr 21 2018, 12:22 PM

Change 428057 had a related patch set uploaded (by Gopavasanth; owner: Gopavasanth):
[mediawiki/extensions/MathSearch@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/428057

gerritbot added a comment.Apr 21 2018, 1:03 PM

Change 428059 had a related patch set uploaded (by Gopavasanth; owner: Gopavasanth):
[mediawiki/extensions/DonationInterface@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/428059

gerritbot added a comment.Apr 21 2018, 1:21 PM

Change 428060 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt):
[mediawiki/extensions/Math@master] Move phpunit test files

https://gerrit.wikimedia.org/r/428060

gerritbot added a comment.Apr 21 2018, 2:17 PM

Change 428057 merged by jenkins-bot:
[mediawiki/extensions/MathSearch@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/428057

Gopavasanth updated the task description. (Show Details)Apr 21 2018, 3:05 PM
gerritbot added a comment.Apr 23 2018, 9:34 AM

Change 428060 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Move phpunit test files

https://gerrit.wikimedia.org/r/428060

gerritbot added a comment.May 22 2018, 7:26 PM

Change 427715 merged by jenkins-bot:
[mediawiki/extensions/PagedTiffHandler@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/427715

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)); removed MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).May 22 2018, 8:00 PM
Jayprakash12345 mentioned this in rEBSL12d354adf8ab: Final NoteDb migration updates.Jun 8 2018, 10:40 PM
Jayprakash12345 mentioned this in rEBSN6ee8c0d9a7f7: Final NoteDb migration updates.Jun 8 2018, 11:54 PM
Jayprakash12345 mentioned this in rEBTM5a824f6ae216: Final NoteDb migration updates.Jun 9 2018, 1:07 AM
Jayprakash12345 mentioned this in rEBSES2bf4ab22e7fa: Final NoteDb migration updates.Jun 9 2018, 1:28 AM
Jayprakash12345 mentioned this in rEBTX1e57edfee9f1: Final NoteDb migration updates.Jun 9 2018, 4:53 AM
Jayprakash12345 mentioned this in rEBSUc688131970e5: Final NoteDb migration updates.Jun 9 2018, 1:45 PM
Jayprakash12345 mentioned this in rEBSW3cdb821f2637: Final NoteDb migration updates.Jun 9 2018, 1:57 PM
Jayprakash12345 mentioned this in rEBTRd2887493f9c5: Final NoteDb migration updates.Jun 9 2018, 2:32 PM
Gopavasanth mentioned this in rEPFM24bdf76869b2: Final NoteDb migration updates.Jun 9 2018, 6:56 PM
Legoktm mentioned this in rELGN457411278f9f: Final NoteDb migration updates.Jun 10 2018, 2:47 AM
Jayprakash12345 mentioned this in rEBSBba39aa03585e: Final NoteDb migration updates.Jun 11 2018, 1:01 AM
Jayprakash12345 mentioned this in rEBTAd7fcfa2d33a4: Final NoteDb migration updates.Jun 11 2018, 1:05 AM
Jayprakash12345 mentioned this in rEMLM7004fb0085cb: Final NoteDb migration updates.Jun 11 2018, 2:24 AM
Jayprakash12345 mentioned this in rEBTF7c0fe4bf01d1: Final NoteDb migration updates.Jun 11 2018, 2:49 AM
Jayprakash12345 mentioned this in rEBTO55855fc0b85b: Final NoteDb migration updates.Jun 11 2018, 8:30 AM
Jayprakash12345 mentioned this in rESNG083c98db7161: Final NoteDb migration updates.Jun 11 2018, 8:51 AM
Legoktm mentioned this in rEBHKf4e8c63317f9: Final NoteDb migration updates.Jun 11 2018, 5:06 PM
Jayprakash12345 mentioned this in rENUACe971134a161e: Final NoteDb migration updates.Jun 11 2018, 9:15 PM
gerritbot added a comment.Sep 19 2018, 5:33 PM

Change 302996 abandoned by Jforrester:
Move tests to tests/phpunit/ and remove hook

Reason:
Done in Iac91c86fc66ef99bbc838b7458e8efcdcd2bcfb8.

https://gerrit.wikimedia.org/r/302996

thiemowmde mentioned this in rEPFMbee2ffda4b20: Remove 'UnitTestList' hook.Dec 12 2018, 9:22 AM
jeblad subscribed.Dec 30 2018, 6:37 PM

Please mark hooks as deprecated before such changes, and update the documentation accordingly.
This (in combo with a change in PHPunit) trigger some very strange bugs.

Aklapper added a comment.Dec 31 2018, 9:09 PM

@jeblad: Since August 2016, https://phabricator.wikimedia.org/source/mediawiki/browse/master/maintenance/convertExtensionToRegistration.php$254-260 has

if ( $hookName === 'UnitTestsList' ) {
	$this->output( "Note: the UnitTestsList hook is no longer necessary as " .
		"long as your tests are located in the \"tests/phpunit/\" directory. " .
		"Please see <https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/" .
	"Writing_unit_tests_for_extensions#Register_your_tests> for more details.\n"
	);
}

To clarify, which other kind of deprecation and documentation would you have expected and where?
The current policy is at https://www.mediawiki.org/wiki/Deprecation_policy

gerritbot added a comment.Feb 21 2019, 7:28 PM

Change 428056 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/428056

Nikitrain updated the task description. (Show Details)Mar 31 2019, 9:04 AM
Kizule subscribed.Mar 5 2023, 3:09 AM

Oh, I just wanted to close this, but there are a few usages which are left to be removed, per https://codesearch.wmcloud.org/search/?q=onUnitTestsList&i=nope&files=&excludeFiles=&repos=

Kizule removed a project: Patch-For-Review.Mar 5 2023, 3:10 AM

No patches to review, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/428059/ can be abandoned.

Kizule added a comment.Mar 5 2023, 3:11 AM
In T142120#8666085, @Kizule wrote:

No patches to review, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/428059/ can be abandoned.

Oh my mistake, I haven't used the right query. https://codesearch.wmcloud.org/search/?q=UnitTestsList&i=nope&files=&excludeFiles=&repos=

Reedy mentioned this in rEPS63a8bcc148c6: Remove 'UnitTestList' hook.May 25 2023, 6:46 PM
Jayprakash12345 mentioned this in rEQSL960e5b00adb9: Remove 'UnitTestList' hook.May 25 2023, 7:11 PM
Daimona added a parent task: T298509: Deprecate UnitTestsListHook.Aug 19 2023, 4:59 PM
gerritbot added a comment.Jun 25 2025, 7:40 PM

Change #1163865 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Acrolinx@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163865

gerritbot added a project: Patch-For-Review.Jun 25 2025, 7:40 PM
gerritbot added a comment.Jun 25 2025, 7:47 PM

Change #1163866 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/MediaWikiFarm@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163866

gerritbot added a comment.Jun 25 2025, 7:51 PM

Change #1163867 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/googleAnalytics@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163867

gerritbot added a comment.Jun 25 2025, 7:54 PM

Change #1163868 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/SemanticSifter@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163868

gerritbot added a comment.Jun 25 2025, 7:56 PM

Change #1163869 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/PhpTagsStorage@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163869

gerritbot added a comment.Jun 25 2025, 7:57 PM

Change #1163871 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/MultiMaps@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163871

hashar removed a subtask: T142121: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for WMF extensions that have been converted to extension registration.Jun 25 2025, 8:00 PM
hashar subscribed.Jun 25 2025, 8:08 PM

DonationInterface and Wikibase would be addressed via the sibling task T142121

hashar removed a subtask: T98668: Convert all extensions and skins on gerrit to use extension registration.Jun 25 2025, 8:09 PM
gerritbot added a comment.Jun 25 2025, 10:56 PM

Change #1163865 merged by jenkins-bot:

[mediawiki/extensions/Acrolinx@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163865

hashar mentioned this in rEAKLe717ad4d369f: Remove UnitTestsList in favor of autodiscovery.Jun 25 2025, 10:56 PM
gerritbot added a comment.Jun 27 2025, 5:27 PM

Change #1163867 merged by jenkins-bot:

[mediawiki/extensions/googleAnalytics@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163867

gerritbot added a comment.Jun 27 2025, 5:27 PM

Change #1163871 merged by jenkins-bot:

[mediawiki/extensions/MultiMaps@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163871

gerritbot added a comment.Jun 27 2025, 5:27 PM

Change #1163868 merged by jenkins-bot:

[mediawiki/extensions/SemanticSifter@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163868

gerritbot added a comment.Jun 27 2025, 6:34 PM

Change #1163869 merged by Umherirrender:

[mediawiki/extensions/PhpTagsStorage@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163869

gerritbot added a comment.Jul 8 2025, 1:17 PM

Change #1163866 merged by jenkins-bot:

[mediawiki/extensions/MediaWikiFarm@master] Remove UnitTestsList in favor of autodiscovery

https://gerrit.wikimedia.org/r/1163866

gerritbot added a comment.Jul 8 2025, 2:38 PM

Change #428059 abandoned by Hashar:

[mediawiki/extensions/DonationInterface@master] Remove 'UnitTestList' hook

Reason:

I did not notice that patch. It is superseded by I813b5107d72e434b71a6839140dbea72f8f400d8 and I9ac3c6543c06f07ea5270d28c56cf2048077f92c

https://gerrit.wikimedia.org/r/428059

hashar mentioned this in rEMWF77450b2f8cd9: Remove UnitTestsList in favor of autodiscovery.Jul 8 2025, 5:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits