| dr0ptp4kt | |
| Aug 10 2016, 4:51 PM |
| F4351301: Screen Shot 2016-08-10 at 10.56.03 AM.png | |
| Aug 10 2016, 5:56 PM |
| F4351182: grade_c_edit_pencil.jpg | |
| Aug 10 2016, 4:51 PM |
The mobile web presentation should not, for the time being, show the edit pencil when JS is disabled. In the future we may want to explore supporting the option to get to plain wikitext editing, but for now it's suboptimal to take the user to a page that says it's redirecting, but never redirects the user. This appears to be a regression that slipped through the cracks.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Hide edit and watch icons when JS disabled | mediawiki/extensions/MobileFrontend | master | +2 -1 |
Let's fix this by adding an inline style that we remove with JS and SWAT deploy ASAP.
For the record I don't agree this is unbreak now (I'd say high as it doesn't cause fatals or break the primary reading experience), nor that it needs a SWAT. It's unsightly yes and we should fix it asap but I actually think it is going to be useful to get a sense of how many users want to edit without JS for T125174. cc @Jdforrester-WMF
@Jdlrobson It doesn't break the reading experience per say, but if a user taps the icon they reach a page with an infinite "Loading editor" message. I'd say that warrants the priority, since we can potentially fix it before the cache clears, avoiding most users ever experiencing it.
Tapping an edit icon is leaving the reading experience. I agree it sucks but with JS disabled it tells you that editing is unavailable. You can click back to exit or follow the return link.
@MBinder_WMF sounds like a retro item - what does unbreak now mean.
It's worth noting many users subscribe to unbreak now bugs so it should really be used lightly.
Also, I check all UBN! tasks at least once a day to make sure none fall through the cracks.
I'd prefer if you could reduce it to High if you don't plan to fix this now (as per the priority name). Or, fix it now and deploy it.
Downgrading to High, but please do pull this in first to the sprint if looking for work, followed by the Hovercards 8 hour spike.
Change 304297 had a related patch set uploaded (by Jdlrobson):
Hide edit and watch icons when JS disabled
This LGTM.
I tested this on our staging server with the old action bar and the new action bar ($wgMinervaUsePageActionBarV2 set to true), with and without JavaScript enabled in Chrome (52.0.2743.116) on OS X El Capitan (10.11.6) and an emulated Nokia N900 Maemo.