Maniphest T143435

Purge asks for "Clear the cache of this page" for logged in users with the "purge" right
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Multichill
	Aug 19 2016, 5:02 PM

Tags

Referenced Files

None

Subscribers

View All 12 Subscribers

Tokens

"Cup of Joe" token, awarded by Esc3300.

Description

I merged an item on Wikidata and I was a bit puzzled because at https://www.wikidata.org/w/index.php?title=Q26308744&action=purge I got the question " Clear the cache of this page?" and I never had that with merging. I checked https://www.wikidata.org/wiki/Special:ListGroupRights and sure enough "Purge the site cache for a page without confirmation (purge)" was still there. I'm logged in (and admin) so I should have that right. I see the same behavior on https://en.wikipedia.org/w/index.php?title=Category:2016_Summer_Olympics&action=purge (normal user), https://commons.wikimedia.org/w/index.php?title=Category:2016_Summer_Olympics&action=purge (admin) and https://nl.wikipedia.org/w/index.php?title=Olympische_Zomerspelen_2012&action=purge .

This looks a bit like T143372 , but that report is different. I guess recently the code around purging got changed and deployed. First time I've encountered this behavior is today (19 Aug), I see that I merged an item a couple of days ago (16 Aug) and I don't remember running into it.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		aaron	T88445 MediaWiki active/active datacenter investigation and work (tracking)
		Open		None	T92357 Fix database master queries from HTTP GET/HEAD before active-active multi-dc
		Resolved		aaron	T135170 Require POST in ?action=purge
		Duplicate		None	T143435 Purge asks for "Clear the cache of this page" for logged in users with the "purge" right

Event Timeline

Multichill created this task.Aug 19 2016, 5:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2016, 5:02 PM

Did @aaron break this in https://gerrit.wikimedia.org/r/#/c/304157/1/includes/actions/PurgeAction.php ? Sure looks like it.

Multichill added a subscriber: Legoktm.Aug 19 2016, 5:08 PM

Nemo_bis added a parent task: T135170: Require POST in ?action=purge.Aug 19 2016, 5:13 PM

See also T143263

hoo closed this task as a duplicate of T143263: Merge.js: purge items after merging without confirmation.Aug 19 2016, 5:27 PM

Come on @hoo , this is not a duplicate. This affects more than just Wikidata.

In T143435#2568776, @Multichill wrote:

Come on @hoo , this is not a duplicate. This affects more than just Wikidata.

Sorry, misread this bug :(

• MZMcBride subscribed.Aug 21 2016, 3:03 AM

Is this task about the text at Special:ListGroupRights (i.e., https://www.mediawiki.org/wiki/MediaWiki:Right-purge)?

Everything else seems covered by T143263: Merge.js: purge items after merging without confirmation and T135170: Require POST in ?action=purge.

Liuxinyu970226 subscribed.Aug 21 2016, 3:36 AM

It's about neither of them, this bug is about https://en.wikipedia.org/w/index.php?title=Category:2016_Summer_Olympics&action=purge that stopped working and that is used quite a lot, see for example https://en.wikipedia.org/wiki/Template:Purge

Esc3300 awarded a token.Aug 21 2016, 2:34 PM

Esc3300 subscribed.

In T143435#2570128, @Multichill wrote:

It's about neither of them, this bug is about https://en.wikipedia.org/w/index.php?title=Category:2016_Summer_Olympics&action=purge that stopped working and that is used quite a lot, see for example https://en.wikipedia.org/wiki/Template:Purge

When you say "stopped working", you mean that purging now requires an additional click? When I visit https://en.wikipedia.org/w/index.php?title=Category:2016_Summer_Olympics&action=purge, I get prompted with "Clear the cache of this page? [Yes]". I believe this "Yes" button is still functional/working.

I still think T135170#2416859 is relevant here. Saying that https://en.wikipedia.org/wiki/Template:Purge is used quite a lot doesn't really justify this misfeature's continued existence, in my opinion.

If you want a confirmation-less purge link, I think JavaScript is the only available option if the purge action now requires using POST instead of GET.

BethNaught subscribed.Aug 21 2016, 9:58 PM

T143531 is a request to rollback the change

• MZMcBride mentioned this in T143531: Back out the change that changed action=purge to require a confirmation page.Aug 22 2016, 3:41 AM

jayvdb subscribed.Aug 22 2016, 4:20 AM

In T143435#2570624, @MZMcBride wrote:

When you say "stopped working", you mean that purging now requires an additional click?

I'm also curious here.

If you want a confirmation-less purge link, I think JavaScript is the only available option if the purge action now requires using POST instead of GET.

https://phabricator.wikimedia.org/T143531#2578508 says that "Solutions that use JavaScript to bypass the form are *welcome*".

Aklapper mentioned this in T135170: Require POST in ?action=purge.Aug 24 2016, 1:57 PM

Urbanecm subscribed.Aug 24 2016, 5:20 PM

@Multichill: Could you reply to T143435#2578974 please?

There is a user-right that stopped working at Wikidata.

Given that many pages on Wikidata make use of Wikidata statements and labels, "purge" is needed to view the current status of such statements.

@Esc3300 short story: this is a a users v. sysadmins issue here - and the sysadmins decided they don't want this - I'm a bit surprised these tickets haven't been closed out yet as WONTFIX.

Maybe this user-right should be moved to sysadmins instead?

https://www.wikidata.org/wiki/Special:ListGroupRights

Currently it's assign to all users, but autoconfirmed might solve it for most users.

Pikne closed this task as a duplicate of T143531: Back out the change that changed action=purge to require a confirmation page.Apr 6 2017, 12:39 PM

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptApr 6 2017, 12:39 PM